Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Gaurav Jain <gaurav.jain@nxp.com>
To:     Eric Biggers <ebiggers@kernel.org>
CC:     Horia Geanta <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Silvano Di Ninno <silvano.dininno@nxp.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [EXT] Re: [PATCH] crypto: caam/jr - fix Chacha20 + Poly1305 self
 test failure
Thread-Topic: [EXT] Re: [PATCH] crypto: caam/jr - fix Chacha20 + Poly1305 self
 test failure
Thread-Index: AQHZ7Ikn5EtLvx/uSE+ZWTGko+Cjx7AmI14AgAA/4tA=
Date:   Fri, 22 Sep 2023 06:34:17 +0000
Message-ID: <AM0PR04MB60043F6A9B0BCED6BC1827CDE7FFA@AM0PR04MB6004.eurprd04.prod.outlook.com>
References: <20230921124237.2364827-1-gaurav.jain@nxp.com>
 <20230922024100.GA935@sol.localdomain>
In-Reply-To: <20230922024100.GA935@sol.localdomain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Jo3ORqhyUz9UKb+Wl73i02yXkprJ5lZHFiqEwGkB3PfeQ+XiBg9wPByg+qyO?=
 =?us-ascii?Q?t+cGTNs9jScGh6b27Hw9ygCrqdJeu0wTtcR1K+im8qgmZGiQe8JXJYzPZG6L?=
 =?us-ascii?Q?D8IpnN3Zp2PN37Rs7nSDxspMNFJrCle/S9rFkK2LqvaTSuIKAkPAhoGxO4Rk?=
 =?us-ascii?Q?+3VxsH8mYkiidftBRrUU7NgUhveS2NaabCtEUeSwScfgeUo8t6J4tkC1+X6L?=
 =?us-ascii?Q?Rn47AC6+fdSDAHx3RoimBR9LTYLXUP81p6Ns0aEewFRhyGTBsRlt7y2Ecux0?=
 =?us-ascii?Q?EmDyh7mDggyRpUZ0mpXHBVeAPB/oK6EyQQGYfsv4cykxT705wa6yKwb338vP?=
 =?us-ascii?Q?UHUe7oevKY3izrJ2LYDO+Bs68EsuUgj9g3bP4ni6jw/hLUIRFQODOuYdXfK9?=
 =?us-ascii?Q?Zk+xLSZzW2Ms0q5LsTUqDHXHo+aeKOxqVMCf3fWM2tJ3+9Z+ChWNawQvU44c?=
 =?us-ascii?Q?9umiwbEysPYr+zqjQkGnuZme+KoBWHAQWcDp0AMC75+1NnKK0FAkkKrZOFlI?=
 =?us-ascii?Q?8SRhR4U5yctLOWDEsvH/dxCbbr0l+Uy/WF/l6Huaqt6AG9+uNJDWFreikD79?=
 =?us-ascii?Q?h2FhOV8rxF7MLb+vS3HSGEOYxx0sKnBfa0cTHLde+NqMrUABYLgsXisGV0z/?=
 =?us-ascii?Q?ZuE/GzsgGT4fyXY2xkrR/iNtIwK5le0ex0d1sOQhsu8vUcHz+G0zeSl3fgzD?=
 =?us-ascii?Q?j8xTpygP+m3CdbJIvYj9SKAm+SVN7qtZA9t6oWKrUJnGknoXIZtqac7zTJ3X?=
 =?us-ascii?Q?TPAk2wmCDaGJ7XH4liXcGFKvK0vD9f8jOnwmz4UtZbTR0YDVhofGIJ70wgsV?=
 =?us-ascii?Q?LPjlAsvKrvI6FZ2/oQcue/RmOUaqp6tBtA4DYl91YNgvCdAvrOLhI+bTWr7D?=
 =?us-ascii?Q?tZCgxzhFQq3BaT9fQGCz/6bvc92127kJqNXBrso+Jipk0snxgqu5/0XZ5g6W?=
 =?us-ascii?Q?7ImzMUjsi4rm5iC/scNJjm/2Kf/GX7uH+qe8yedvOLdIlfa/eeA9Zjvlx90B?=
 =?us-ascii?Q?rI0rx0tcGY6RJGisFVu2snVwCvH/IB9oxmM6t5PBpZGjEcieft3zRSuFUyya?=
 =?us-ascii?Q?Tz4rmqM+/9NBtXqZaeHH7XPr/3rJUB6CYATpyNyJhKxWor7+DBvfTR12fvQx?=
 =?us-ascii?Q?zE7CU/vR25NDJCqPNNE5BfxpVuSEyQTiR1fzW2D3zHx1bWebRYuUroiqCgku?=
 =?us-ascii?Q?87sUaqEdHSoW0AvOXrOa/SMOhuy/v6bpjr/lN0fsLLjR4AUMlz5otywyiOC1?=
 =?us-ascii?Q?S4K+AILNQjV4oOHS0yI+F5Y+ahx3JYQ6zXPijz3zBA3mM7mYA+vBklBGmDah?=
 =?us-ascii?Q?AIkzmHSVdmj1wVZdn7jrxD3v5wJeY0zsKEj5BchmvpLe6ql/Qc0x2oYPzjZE?=
 =?us-ascii?Q?3W0AKZfPk15NFOPRHpQk2N2fr+XGdBN8MtyIT7u3aK6lNgQBR4hhdnEXGclf?=
 =?us-ascii?Q?RtchKTelhOZkpXSuV2FrOOzesOSSpfvhBlin6fvoX5KMApqnE2wCVRvrxONt?=
 =?us-ascii?Q?Ecyq8KZNKtlouL7h2IAyU9fjNlGvt3VJNwwAXs5X93VE8aEes7SI77ImQ28P?=
 =?us-ascii?Q?oKILqLwUdyAvtIPxipGYzfO8A/yHyGVs46GE9wI7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6004.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f877989-dce1-4dbf-170e-08dbbb35f20d
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2023 06:34:17.1221
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gOFEBn7lniW04GuJ59KEckR9gsJvYgRVd7DuNgcb5nS4UXRR/NreTF/K6Eo+R/BBCEOTqWY3WO8BF4xSNq2lZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6815
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 21 Sep 2023 23:34:29 -0700 (PDT)

Hi Eric

> -----Original Message-----
> From: Eric Biggers <ebiggers@kernel.org>
> Sent: Friday, September 22, 2023 8:11 AM
> To: Gaurav Jain <gaurav.jain@nxp.com>
> Cc: Horia Geanta <horia.geanta@nxp.com>; Pankaj Gupta
> <pankaj.gupta@nxp.com>; Varun Sethi <V.Sethi@nxp.com>; Meenakshi
> Aggarwal <meenakshi.aggarwal@nxp.com>; Herbert Xu
> <herbert@gondor.apana.org.au>; David S . Miller <davem@davemloft.net>;
> Aisheng Dong <aisheng.dong@nxp.com>; Silvano Di Ninno
> <silvano.dininno@nxp.com>; linux-crypto@vger.kernel.org; linux-
> kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: [EXT] Re: [PATCH] crypto: caam/jr - fix Chacha20 + Poly1305 self=
 test
> failure
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report =
this
> email' button
>=20
>=20
> On Thu, Sep 21, 2023 at 06:12:37PM +0530, Gaurav Jain wrote:
> > key buffer is not copied in chachapoly_setkey function, results in
> > wrong output for encryption/decryption operation.
> >
> > fix this by memcpy the key in caam_ctx key arrary
> >
> > Fixes: d6bbd4eea243 ("crypto: caam/jr - add support for Chacha20 +
> > Poly1305")
> > Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
> > ---
> >  drivers/crypto/caam/caamalg.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/caam/caamalg.c
> > b/drivers/crypto/caam/caamalg.c index eba2d750c3b0..066f08a3a040
> > 100644
> > --- a/drivers/crypto/caam/caamalg.c
> > +++ b/drivers/crypto/caam/caamalg.c
> > @@ -575,7 +575,8 @@ static int chachapoly_setkey(struct crypto_aead *ae=
ad,
> const u8 *key,
> >       if (keylen !=3D CHACHA_KEY_SIZE + saltlen)
> >               return -EINVAL;
> >
> > -     ctx->cdata.key_virt =3D key;
> > +     memcpy(ctx->key, key, keylen);
> > +     ctx->cdata.key_virt =3D ctx->key;
> >       ctx->cdata.keylen =3D keylen - saltlen;
> >
>=20
> Huh, so this driver just ignored the key?  Is anyone using the ChaCha20Po=
ly1305
> support in this driver?  Based on this bug existing, that seems unlikely.=
  If that's
> the case, wouldn't it be better just to remove the ChaCha20Poly1305 suppo=
rt
> from this driver so that the code doesn't need to be maintained?

This algorithm is used in IPSEC and we are also going to use ChaCha20Poly13=
05 support for Kernel TLS.
Gaurav
>=20
> - Eric