Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   Ma Ke <make_ruc2021@163.com>
To:     mchehab+huawei@kernel.org, sboyd@kernel.org
Cc:     linux-kernel@vger.kernel.org, Ma Ke <make_ruc2021@163.com>
Subject: [PATCH] spmi: hisi-spmi-controller: fix potential memory leak in spmi_controller_probe()
Date:   Fri, 22 Sep 2023 10:52:16 +0800
Message-Id: <20230922025216.3604978-1-make_ruc2021@163.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

spmi_controller_alloc() allocates a memory space for ctrl. When some
errors occur, ctrl should be handled by spmi_controller_put() and set
spmi_controller->controller = NULL because spmi_controller->controller
has a dangling pointer to the freed memory. When the failure happens,
the function returns without calling spmi_controller_put() and setting
spmi_controller->controller = NULL, which will lead to a memory leak.

When the failure happens, we can fix it by calling spmi_controller_put()
and setting spmi_controller->controller = NULL in all of the places
where we call spmi_controller_put().

Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
 drivers/spmi/hisi-spmi-controller.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
index 9cbd473487cb..5b3cfa7f5056 100644
--- a/drivers/spmi/hisi-spmi-controller.c
+++ b/drivers/spmi/hisi-spmi-controller.c
@@ -321,6 +321,7 @@ static int spmi_controller_probe(struct platform_device *pdev)
 
 err_put_controller:
 	spmi_controller_put(ctrl);
+	spmi_controller->controller = NULL;
 	return ret;
 }
 
-- 
2.37.2