Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
MIME-Version: 1.0
References: <20230918103055.5471-1-victorshihgli@gmail.com>
 <CAAd53p4qhf+3j=zMs_RXSpLQzn6RGD9yUNcSA12V5aACswgeeQ@mail.gmail.com>
 <CAK00qKDnG1o6ZxzY=pGs0J7o_RYYsr1XHxJKirRKeghsp6QOBg@mail.gmail.com>
 <CAAd53p6cgN7QDZXzTsw_DVgOmpv46DY+Ttom5V0vTBVn2jpUQg@mail.gmail.com> <CAK00qKA2kaQ2k0Tp=F86BmAMEK=GiAmtLiAQcZRBGVvHOd64MQ@mail.gmail.com>
In-Reply-To: <CAK00qKA2kaQ2k0Tp=F86BmAMEK=GiAmtLiAQcZRBGVvHOd64MQ@mail.gmail.com>
From:   Kai-Heng Feng <kai.heng.feng@canonical.com>
Date:   Fri, 22 Sep 2023 15:10:42 +0800
Message-ID: <CAAd53p4EemJQfp2nwKTPoGpwPJchZKfC8hKU8zuvtK-YKmM9bQ@mail.gmail.com>
Subject: Re: [PATCH V1] mmc: sdhci-pci-gli: GL975[05]: Mask the replay timer
 timeout of AER
To:     Victor Shih <victorshihgli@gmail.com>
Cc:     ulf.hansson@linaro.org, adrian.hunter@intel.com,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        benchuanggli@gmail.com, HL.Liu@genesyslogic.com.tw,
        Greg.tu@genesyslogic.com.tw, kangzhen.lou@dell.com,
        Victor Shih <victor.shih@genesyslogic.com.tw>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Victor,

On Wed, Sep 20, 2023 at 4:54=E2=80=AFPM Victor Shih <victorshihgli@gmail.co=
m> wrote:
>
> On Tue, Sep 19, 2023 at 3:31=E2=80=AFPM Kai-Heng Feng
> <kai.heng.feng@canonical.com> wrote:
> >
> > Hi Victor,
> >
> > On Tue, Sep 19, 2023 at 3:10=E2=80=AFPM Victor Shih <victorshihgli@gmai=
l.com> wrote:
> > >
> > > On Tue, Sep 19, 2023 at 12:24=E2=80=AFPM Kai-Heng Feng
> > > <kai.heng.feng@canonical.com> wrote:
> > > >
> > > > Hi Victor,
> > > >
> > > > On Mon, Sep 18, 2023 at 6:31=E2=80=AFPM Victor Shih <victorshihgli@=
gmail.com> wrote:
> > > > >
> > > > > From: Victor Shih <victor.shih@genesyslogic.com.tw>
> > > > >
> > > > > Due to a flaw in the hardware design, the GL975x replay timer fre=
quently
> > > > > times out when ASPM is enabled. As a result, the system will resu=
me
> > > > > immediately when it enters suspend. Therefore, the replay timer
> > > > > timeout must be masked.
> > > >
> > > > This patch solves AER error when its PCI config gets accessed, but =
the
> > > > AER still happens at system suspend:
> > > >
> > > > [ 1100.103603] ACPI: EC: interrupt blocked
> > > > [ 1100.268244] ACPI: EC: interrupt unblocked
> > > > [ 1100.326960] pcieport 0000:00:1c.0: AER: Corrected error received=
:
> > > > 0000:00:1c.0
> > > > [ 1100.326991] pcieport 0000:00:1c.0: PCIe Bus Error:
> > > > severity=3DCorrected, type=3DData Link Layer, (Transmitter ID)
> > > > [ 1100.326993] pcieport 0000:00:1c.0:   device [8086:7ab9] error
> > > > status/mask=3D00001000/00002000
> > > > [ 1100.326996] pcieport 0000:00:1c.0:    [12] Timeout
> > > >
> > > > Kai-Heng
> > > >
> > >
> > > Hi, Kai-Heng
> > >
> > > Could you try applying the patch and re-testing again after restartin=
g
> > > the system?
> >
> > Same issue happens after coldboot.
> >
> > > Because I applied the patch and restarted the system and it didn't ha=
ppen.
> > > The system can enter suspend normally.
> > >
> > > If you still have the issue after following the above instructions,
> > > please provide me with your environment and I will verify it again.
> >
> > The patch gets applied on top of next-20230918. Please let me know
> > what else you want to know.
> >
> > Kai-Heng
> >
>
> Hi, Kai-Heng
>
> If I want to mask the replay timer timeout AER of the upper layer root po=
rt,
> could you give me some suggestions?
> Or could you provide sample code for my reference?

I am not aware of anyway to mask "replay timer timeout" from root port.
I wonder if the device supoprt D3hot? Or should it stay at D0 when
ASPM L1.2 is enabled?

Kai-Heng

>
> Thanks, Victor Shih
>
> > >
> > > Thanks, Victor Shih
> > >
> > > > >
> > > > > Signed-off-by: Victor Shih <victor.shih@genesyslogic.com.tw>
> > > > > ---
> > > > >  drivers/mmc/host/sdhci-pci-gli.c | 16 ++++++++++++++++
> > > > >  1 file changed, 16 insertions(+)
> > > > >
> > > > > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/=
sdhci-pci-gli.c
> > > > > index d83261e857a5..d8a991b349a8 100644
> > > > > --- a/drivers/mmc/host/sdhci-pci-gli.c
> > > > > +++ b/drivers/mmc/host/sdhci-pci-gli.c
> > > > > @@ -28,6 +28,9 @@
> > > > >  #define PCI_GLI_9750_PM_CTRL   0xFC
> > > > >  #define   PCI_GLI_9750_PM_STATE          GENMASK(1, 0)
> > > > >
> > > > > +#define PCI_GLI_9750_CORRERR_MASK                              0=
x214
> > > > > +#define   PCI_GLI_9750_CORRERR_MASK_REPLAY_TIMER_TIMEOUT        =
 BIT(12)
> > > > > +
> > > > >  #define SDHCI_GLI_9750_CFG2          0x848
> > > > >  #define   SDHCI_GLI_9750_CFG2_L1DLY    GENMASK(28, 24)
> > > > >  #define   GLI_9750_CFG2_L1DLY_VALUE    0x1F
> > > > > @@ -152,6 +155,9 @@
> > > > >  #define PCI_GLI_9755_PM_CTRL     0xFC
> > > > >  #define   PCI_GLI_9755_PM_STATE    GENMASK(1, 0)
> > > > >
> > > > > +#define PCI_GLI_9755_CORRERR_MASK                              0=
x214
> > > > > +#define   PCI_GLI_9755_CORRERR_MASK_REPLAY_TIMER_TIMEOUT        =
 BIT(12)
> > > > > +
> > > > >  #define SDHCI_GLI_9767_GM_BURST_SIZE                   0x510
> > > > >  #define   SDHCI_GLI_9767_GM_BURST_SIZE_AXI_ALWAYS_SET    BIT(8)
> > > > >
> > > > > @@ -561,6 +567,11 @@ static void gl9750_hw_setting(struct sdhci_h=
ost *host)
> > > > >         value &=3D ~PCI_GLI_9750_PM_STATE;
> > > > >         pci_write_config_dword(pdev, PCI_GLI_9750_PM_CTRL, value)=
;
> > > > >
> > > > > +       /* mask the replay timer timeout of AER */
> > > > > +       pci_read_config_dword(pdev, PCI_GLI_9750_CORRERR_MASK, &v=
alue);
> > > > > +       value |=3D PCI_GLI_9750_CORRERR_MASK_REPLAY_TIMER_TIMEOUT=
;
> > > > > +       pci_write_config_dword(pdev, PCI_GLI_9750_CORRERR_MASK, v=
alue);
> > > > > +
> > > > >         gl9750_wt_off(host);
> > > > >  }
> > > > >
> > > > > @@ -770,6 +781,11 @@ static void gl9755_hw_setting(struct sdhci_p=
ci_slot *slot)
> > > > >         value &=3D ~PCI_GLI_9755_PM_STATE;
> > > > >         pci_write_config_dword(pdev, PCI_GLI_9755_PM_CTRL, value)=
;
> > > > >
> > > > > +       /* mask the replay timer timeout of AER */
> > > > > +       pci_read_config_dword(pdev, PCI_GLI_9755_CORRERR_MASK, &v=
alue);
> > > > > +       value |=3D PCI_GLI_9755_CORRERR_MASK_REPLAY_TIMER_TIMEOUT=
;
> > > > > +       pci_write_config_dword(pdev, PCI_GLI_9755_CORRERR_MASK, v=
alue);
> > > > > +
> > > > >         gl9755_wt_off(pdev);
> > > > >  }
> > > > >
> > > > > --
> > > > > 2.25.1
> > > > >