Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <39f264e0-bcc4-97f8-57ca-8a8bee28c27b@linux.alibaba.com>
Date:   Fri, 22 Sep 2023 15:55:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.0
Subject: Re: [PATCH net-next v3 09/18] net/smc: introduce SMC-D loopback
 device
To:     Wenjia Zhang <wenjia@linux.ibm.com>, kgraul@linux.ibm.com,
        jaka@linux.ibm.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com
Cc:     alibuda@linux.alibaba.com, tonylu@linux.alibaba.com,
        linux-s390@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1695302360-46691-1-git-send-email-guwen@linux.alibaba.com>
 <1695302360-46691-10-git-send-email-guwen@linux.alibaba.com>
 <2ab26484-3abe-f741-e7b1-83135dd95d2c@linux.ibm.com>
From:   Wen Gu <guwen@linux.alibaba.com>
In-Reply-To: <2ab26484-3abe-f741-e7b1-83135dd95d2c@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/9/22 07:32, Wenjia Zhang wrote:
> 
> 

<..>

>> +
>> +#ifndef _SMC_LOOPBACK_H
>> +#define _SMC_LOOPBACK_H
>> +
>> +#include <linux/device.h>
>> +#include <linux/err.h>
>> +#include <net/smc.h>
>> +
>> +#define SMC_LODEV_MAX_DMBS 5000
>> +
>> +struct smc_lo_dev {
>> +    struct smcd_dev *smcd;
>> +    struct device dev;
>> +};
>> +
> I'm just wondering why don't use pointer for dev?
> 

The 'struct device' is a generic structure embeded, used to associate a Linux device
with a specific device. So I think variable for dev here is OK. See also struct ism_dev.

Thanks.

>> +int smc_loopback_init(void);
>> +void smc_loopback_exit(void);
>> +
>> +#endif /* _SMC_LOOPBACK_H */