Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Fri, 22 Sep 2023 11:44:18 +0800
From:   Yi Sun <yi.sun@intel.com>
To:     Andi Kleen <ak@linux.intel.com>
CC:     Ingo Molnar <mingo@kernel.org>, <dave.hansen@intel.com>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <sohil.mehta@intel.com>, <ilpo.jarvinen@linux.intel.com>,
        <heng.su@intel.com>, <tony.luck@intel.com>,
        <yi.sun@linux.intel.com>, <yu.c.chen@intel.com>
Subject: Re: [PATCH v7 1/3] x86/fpu: Measure the Latency of XSAVE and XRSTOR
Message-ID: <ZQ0NkklaVzFgoeww@ysun46-mobl.ccr.corp.intel.com>
References: <20230921062900.864679-1-yi.sun@intel.com>
 <20230921062900.864679-2-yi.sun@intel.com>
 <ZQvqvpSbyub6gFZX@gmail.com>
 <ZQx01AfyvbJQYPsi@tassilo>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Disposition: inline
In-Reply-To: <ZQx01AfyvbJQYPsi@tassilo>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3V1MHJTd20rMUREeW9FdU9wOTNIWFlDdEswWmlFNUYrRjNtSkZKMkwvenBR?=
 =?utf-8?B?Skw2YVdUS1dpa0FUKzMrYUs1V2tOV3hvMkJEbUxZUStLdmtzanN0dzV5blJ4?=
 =?utf-8?B?L2pLOTZ0SDNDbUpQT1cwQ0pVbjVMajdmT0RGNFZvQzYzbU5NL2dWTktoZFNw?=
 =?utf-8?B?OUt2bDVSejNSWXpudmdxM3ZrV1ptaTBNdUpUcytQakJvZGhnRXFrcjR4NndX?=
 =?utf-8?B?TGluajF5emR5bHY5Mng0WWFXaHBRQ0s5VzhnTzVnaCsvekE5b0JZS1hTSmJF?=
 =?utf-8?B?LzhzcGpZKy9XMFRJc1pRbW5jZVZVZVVVMkY0T1EvMkhhYUc5NENheWxtdGM2?=
 =?utf-8?B?U0hwbzY4V2l1aDZDekwvVzlOUFN1Y0IzVTJvLzdJQXZLU1J6RHl2RzdGUVQx?=
 =?utf-8?B?ZkpWWmpPWnBKVVErWExtNlFBUXl3SkpGM0swb1VTWXdRMjJieFE3RTgybURH?=
 =?utf-8?B?bHZ1L1RLK3ZVeFpNM1YwVXl1ZkNXbzNrbzlXU29TUThTUmdNVi9ldVZrb2Vv?=
 =?utf-8?B?WnFxOXRlQzlQZk9wQVlQWWcyWCtYdzkyTnlESWgxTFlxNThXU01rbE43WDlp?=
 =?utf-8?B?QkVVLzQrVTc4cFB6U3BXMGxBa0ptS0xta0gxSmZSS1FJMGhGNFZWZ1k4dWov?=
 =?utf-8?B?MTk3cjZxNkpueEkyU2UvVU9MS2hsVFNwdWNLZXA5Ylh6TjFpeEtJOHJtYW1K?=
 =?utf-8?B?M0F0M203RUZ2L2FJdXgyOUZMNXEzR0ltek9kd3NOMU1DZkZ2NVM2bjVJQXp0?=
 =?utf-8?B?ejlVZXQrYUNLTjhlcHNMTlZjaGJ4dEl6VWQ4ZTBsM2VMV1YzSXpHakZRRWFk?=
 =?utf-8?B?V1d4UUE5ZDBqM2h4cVV1Z09sdXNLbmEvdmVjYW1sLy9VcFZwUTdrMVNJQnJn?=
 =?utf-8?B?Nzh1VnRFMlhITzRBV2F4eEFSREZJSEpyVjNWdlFnUG1DalN0YVR0RzhJa1dy?=
 =?utf-8?B?ZXJseTRmaGE3K1VYa28wZ24ySmVyS1JtMnBFa2llSjBlNjV4MFU3ZkZLL1Jp?=
 =?utf-8?B?S2o1RVV4ME1HRHBLN081YnFyK3M0MzQzNWRabDlzQzBEcHppdnEyS2NvTjRt?=
 =?utf-8?B?WUcxU0pVc3JJUWI1NkFQNEllT0lYbUhBRFhjbFNtRDBmODkrNVp5THYzRjlI?=
 =?utf-8?B?ak95OXRFZ1pZMmFLSis0bEZVcURsR3ZyRFd0K2VNSDlmM1gzNkNyeFU0WG9r?=
 =?utf-8?B?bndVVS81aUNoNGxRQVJmWWNEd25PZEl3emx0V1J2WUtXMnJZcFBKTGxXblBL?=
 =?utf-8?B?YTYrU1k4ODBwUFh1TFZOV1BoWElQS2FRV2VJQkxRbnNvNXNMc0Ird3hMK3Rs?=
 =?utf-8?B?a21SVlJHTC83bElCdDkwSjFwM3N5MU1kZEhiV3N4Vno0Q0NCMW5QbDZDZTUv?=
 =?utf-8?B?dUJ5cUtkNnQ0d1FKdEp5SGpNYzVLUFZmRVFvUWc0RzBLZmM3ZG9hdG5XdVJ4?=
 =?utf-8?B?SkJDSkVmWm05MHZxUk1MaVhIaWl2clRVdjVHV3ZoMkRiUWZRbGtaUzFzL0Jx?=
 =?utf-8?B?QmNoZTl0TUU3L2tXU3dWeUJvVVBSZXVZeTMxWU1vRDh0MXZvWllsTGJ4SlAr?=
 =?utf-8?B?RVBOL3QrdWJRblpVL2Vub0NyRXBHYldyZkNSSzMvczVlMWxQd2ZHY1VveTBD?=
 =?utf-8?B?VlYzK1NQc1RLMzVjcDRNbEU4cForcEQyTW1PWUQwZ3YwZmF1U3ZsbVZMSE8r?=
 =?utf-8?B?UEU1TUtZVGdZZm9hVmViNHNZdUgrKy95SjBwUWZJRTVsK1QyKytkQUNSZ1hR?=
 =?utf-8?B?RDFIU1F0V0pRQkh2d2FlbVRlNmpxOHN6NjAybXYvZnZQY0tnSkFpTnR2QXpm?=
 =?utf-8?B?WlRDQ1pmcUVLeUxFdC9YbjJrcm45N0VhRVhldG9zVzhBSzlRTlpmMGRQdWV6?=
 =?utf-8?B?VVI1eVZjZC9EdFgyTFFkUXA1OWJGSE13L0F3Q2JtTVNMaDJpcjBoWTFYbU8w?=
 =?utf-8?B?RnhrQ0hIbzgvVExranlOMWRSbjVGUXFRNnVtd0lnUEcvcDJ2Z2Z4L05NQ01W?=
 =?utf-8?B?RW1tQkgrS2NZUGdQTkpTMHgvMzQ3cmxZeTVkNkViUEszb28zVVRRbWJDWGYv?=
 =?utf-8?B?Y0MzOVY2WEFDMnVFQlkxclBWTHBEUlVaMGpXbk0zS011WTd1TFZvWmp3VWdO?=
 =?utf-8?Q?oguF+JHJTK6y+9J+Yhfu8gn/g?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 522a4c03-3583-44b0-b69b-08dbbb1e3d20
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3094.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 03:44:35.5345
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bDy4JdlgC2s+pDf2hHeph5dOHoDCVMPlf7iutZjYAua4uyS8pl8bB0dNJsHf0QtpkV5zx32jaWlxcLHvWkjI4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4878
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 21 Sep 2023 20:46:32 -0700 (PDT)

On 21.09.2023 09:52, Andi Kleen wrote:
>> It seems unnecessarily complex: why does it have to measure latency
>> directly? Tracepoints *by default* come with event timestamps. A latency
>> measurement tool should be able to subtract two timestamps to extract the
>> latency between two tracepoints...
>>
>> In fact, function tracing is enabled on all major Linux distros:
>>
>>   kepler:~/tip> grep FUNCTION_TRACER /boot/config-6.2.0-33-generic
>>   CONFIG_HAVE_FUNCTION_TRACER=y
>>   CONFIG_FUNCTION_TRACER=y
>>
>> Why not just enable function tracing for the affected FPU context switching
>> functions?
>
>Or use PT address filters to get it even accurately, as described
>in [1]. In any case I agree the trace points are not needed.
>
Hi Andi,

Here, we have implemented latency measurement for all x86 platforms, not
just for Intel but also for other vendors like AMD. This allows us to 
obtain comparable data.

Thanks
    --Sun, Yi