Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <c2b92ff2-d077-4588-9d5c-93dfec0037ee@mailbox.org>
Date:   Fri, 22 Sep 2023 10:25:55 +0200
MIME-Version: 1.0
Subject: Re: [PATCH] Use CRC32 and a 1MiB dictionary for XZ compressed modules
Content-Language: en-US
To:     Martin Nybo Andersen <tweek@tweek.dk>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>,
        Nick Terrell <terrelln@fb.com>, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <3d34a965-ab9c-d549-0c63-c717ab5d2edc@tweek.dk>
From:   Tor Vic <torvic9@mailbox.org>
In-Reply-To: <3d34a965-ab9c-d549-0c63-c717ab5d2edc@tweek.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

> 
> Hello?

Hello,

> Anyone?
> 
> Best regards,
> - Martin
> 
> On Fri, 15 Sep 2023, Martin Nybo Andersen wrote:
> 
>> Kmod is now using the kernel decompressor which doesn't handle CRC64
>> and dictionaries larger than 1MiB.
>>
>> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050582
>> Signed-off-by: Martin Nybo Andersen <tweek@tweek.dk>
>> ---
>> scripts/Makefile.modinst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
>> index c59cc57286ba..ffbafbd3aeea 100644
>> --- a/scripts/Makefile.modinst
>> +++ b/scripts/Makefile.modinst
>> @@ -144,7 +144,7 @@ endif
>> quiet_cmd_gzip = GZIP    $@
>>       cmd_gzip = $(KGZIP) -n -f $<
>> quiet_cmd_xz = XZ      $@
>> -      cmd_xz = $(XZ) --lzma2=dict=2MiB -f $<
>> +      cmd_xz = $(XZ) --check=crc32 --lzma2=dict=1MiB -f $<

I wonder whether it should be guarded with
     ifdef CONFIG_MODULE_DECOMPRESS

But on the other hand, the difference between 1M and 2M is likely very 
small in terms of compression ratio.

Cheers,
Tor Vic

>> quiet_cmd_zstd = ZSTD    $@
>>       cmd_zstd = $(ZSTD) -T0 --rm -f -q $<
>>
>> -- 
>> 2.40.1
>>
>>
>