Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <23d0ef96-ca51-4fe0-b2e6-af0e188fbb6d@quicinc.com>
Date:   Fri, 22 Sep 2023 12:21:55 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From:   Raghavendra Kakarla <quic_rkakarla@quicinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: Enable RPMh Sleep stats
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <quic_mkshah@quicinc.com>, <quic_lsrao@quicinc.com>
References: <20230920052349.9907-1-quic_rkakarla@quicinc.com>
 <68fb2f4f-ba21-21b0-ddbe-aab92991ec44@linaro.org>
Content-Language: en-US
In-Reply-To: <68fb2f4f-ba21-21b0-ddbe-aab92991ec44@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Konrad,

Thank you for your review. will address your comments in next patch.


Regards,

Raghavendra K.

On 9/20/2023 3:15 PM, Konrad Dybcio wrote:
>
>
> On 9/20/23 07:23, Raghavendra Kakarla wrote:
>> Add device node for Sleep stats driver which provides various
>> low power mode stats on sa8775p SoC.
>>
>> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
>> ---
> The subject must include the platform name
>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi 
>> b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 9f4f58e831a4..23ae404da02e 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -1912,6 +1912,11 @@
>>               #clock-cells = <0>;
>>           };
>>   +        sram@c3f0000 {
>> +            compatible = "qcom,rpmh-stats";
>> +            reg = <0x0c3f0000 0x400>;
> Please test your patches before sending. This one has clearly
> hasn't been.
>
> Konrad