Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Ramya SR <rsr@qti.qualcomm.com>
To:     "Ramya SR (QUIC)" <quic_rsr@quicinc.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, Lyude Paul <lyude@redhat.com>,
        Wayne Lin <Wayne.Lin@amd.com>,
        Jani Nikula <jani.nikula@intel.com>,
        Imre Deak <imre.deak@intel.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Jeff Layton <jlayton@kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port
 detect
Thread-Topic: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port
 detect
Thread-Index: AQHZ55DQhVb08bi8cEKL8zMH3hln2LAmoqyA
Date:   Fri, 22 Sep 2023 09:41:34 +0000
Message-ID: <BN0PR02MB7951B2EC4718D7E2BDD4DC3E81FFA@BN0PR02MB7951.namprd02.prod.outlook.com>
References: <1694753689-29782-1-git-send-email-quic_rsr@quicinc.com>
In-Reply-To: <1694753689-29782-1-git-send-email-quic_rsr@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6aL+9/K3wnx2hv4bkbFrbs5ozdc+o6SjighwWrvSNRBs7A2jF0F5+pI7zj/s?=
 =?us-ascii?Q?fS3RaHWekdfXGdu+PBWaXBIKIQZmprEuJ2TuPchyBzTMgaCgVf4CLWsIlyU0?=
 =?us-ascii?Q?qAAcmrDjbATEPuLoXGW8o1YGiD/ur3sQ3hibvywSboGNvvJgDs7e5Bc/seZH?=
 =?us-ascii?Q?/FA2jSp8IO8JUBIUx0nX+090JgJBU/bGv377tWe6gtFHD4AwkJFcf5jEZOUK?=
 =?us-ascii?Q?SzzTbOx8urpluvqLVPdwqPdwEDLxzdvfzGSFmPzBWBFt7YaDNEOSA7OEfikB?=
 =?us-ascii?Q?fWmPGsMpQo1HZXeTZSYQNTNaIEBIObPRiTQkT+4oSUFZDIuP1dFc9D5/qyjG?=
 =?us-ascii?Q?HYGFvxg52Suqs59dLbMaeQkrPDi9RwzADJfhKLbd9bvsDYgvKXPZ0PawrUEu?=
 =?us-ascii?Q?XS4ZaPgP1SmMwwPzoByKO6+bNrGLf3iaZkqFpgEX8SF1hrEfZxk+sdkbhzsr?=
 =?us-ascii?Q?lAC9ZAF3mVfbcs4aXrf303QSMp0Tv7TEI978Vsr+lNlO8pJTelfuvKL9Obt2?=
 =?us-ascii?Q?Pq2UHuLK8M3X0rKtGz7Y9pnZAqf+lF3JcIDUZcESTDY2ETQ2sEdy91FxRnEM?=
 =?us-ascii?Q?jAJnOL92pnXpSJ/Gd9/cDjFdtKHgGSizKQpdiXYbrsRejrVsc6gNM2tMs58L?=
 =?us-ascii?Q?zIQoZx7Nf3WMCul/s0y6c0cQuas6cw+X7xvWwHL1m41R7Pe5L/Ap34b2SX3W?=
 =?us-ascii?Q?jIEALu+rq7MD2aeBomTvU9DJJskRriBA0VKkGfcwngc/wztiFUx+4Ka3I8iD?=
 =?us-ascii?Q?Yb7d7JYOcVonXbF7rMyt/3HzPjSK62kTuBlZYdSw16FAqNUvdZyYja7NHBkj?=
 =?us-ascii?Q?smHcQ2QlbE05+5e0/bc3euVCl/ONYvmsm+/0jPgNRJSJRqdMHKh7o61/PeK7?=
 =?us-ascii?Q?D4pnsKCqswylBOnBAg8wxw4P1nLXayRZvYqRwMgBwhD27nZHHxBsFMCbBo93?=
 =?us-ascii?Q?NLnNXtR94p6fxoDLZolJFz0mQefycc08Hmip2oTC9dSpWa3U172H2DC5Oc8n?=
 =?us-ascii?Q?vO6699dpwife9kBHgFAC1/dvPKlOJRYaC+nY1d4W/qtDJjPRz9bfeCMuq5Iq?=
 =?us-ascii?Q?z5gtqy6jdSTqVWio5Dfdf5sQTQkIu+kEybat0TTdgBpgKMSnn87UnJAqdLRG?=
 =?us-ascii?Q?CfMKwXyk1I0nblPQgnUcbgIyHrMl2mHMYrOplmM2HjGXEjoWs2ebLlRTRuin?=
 =?us-ascii?Q?YDditdtoJNoLYF2JcpmVAtw6aDrtsHCMMR7lUr3lHA6ZoBfMBKaZFbj2Hp8M?=
 =?us-ascii?Q?57v+PG6S8GPDMGHf6EiWXm1v4GLEzGQnK466D1+iRqSfown7DiaUXRWksG3v?=
 =?us-ascii?Q?nRL80jGIF9j3K5NWV/YdghRO43TdJYLHq2IsWRpk2h8sawauTywhFZiRK/ZA?=
 =?us-ascii?Q?NA3W9JZH93DQYpyg0J4mnPftyW8Pqcfl1QHoSHRwSIH+/GE3VnXACgnSlOMs?=
 =?us-ascii?Q?+9w6xsCDheTzET35yiFT6upIYAumV5WJfbah1Nu6przMuoOksbEVYN7EVj+A?=
 =?us-ascii?Q?D+mpUzXMO/7eqC/Ux0LDk6EzO9tyEEd+nsmheHQ4mrhpUk0GHb03Ro18DnrI?=
 =?us-ascii?Q?d8/kdekxWCx0vIlygChyYCeVqo3eMN0C2FZoy7L2?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?UaeDKb1owkdElHr6MDpKpapq1KAFat90DycyeIacmLRvQeSvjQxhNyuCY4Yr?=
 =?us-ascii?Q?nRBjaxn1vTnbAoXZEEQFfWirEU0Q3PpCky6Dw3rsEx3sjStdzsRYT1wXWQsr?=
 =?us-ascii?Q?BcSunUDRIJ7DiBykDDM837Nx+N3I03hhXX/4v5Z4J6a8bRshIfM16FMJyycr?=
 =?us-ascii?Q?gUlcNNtMh7EWd++fQCMTsD3JK+1hL11eilxvfEWwo/D2sLDrl3ujaNBwCwIY?=
 =?us-ascii?Q?PA26FK9F8e+8FCoFVCqWU/kcp+Xt/gy98kumP6o20HrmotJpNh/yZF6bB0uw?=
 =?us-ascii?Q?FdOkgItb8wHrVhNevJXf0D0EfH/9IQwfvU0EzQTJSJKe4B7L93t6zQCXCoSh?=
 =?us-ascii?Q?8O/RVEuyzoLd2E+yP2jMUEqIrbtbZ/gNIUajA9CADIgP7xqx1+iYK/0Ybnyj?=
 =?us-ascii?Q?edv8xWY2Z6Iqw5OiuSiv7HKKy6iCpsykECaBeieVIc5V/xZv0kFiVJgmNsfu?=
 =?us-ascii?Q?zsI4Pw2/zzGOCjhl776ZXkeLu43QD6MeflJ46sMjK17qFnx9RS2+DODU1BZG?=
 =?us-ascii?Q?2hOIwMCLgHCHY3HU0uZKxsGM1z4vWJQHXcPhDzj/4/JsLZiqwYYIjSjluFvN?=
 =?us-ascii?Q?J1RmFoTPbJswAK9ez+IyOhDbGcqaus6kVukBGbhmaWTguOV1CcQLAlF8YzIK?=
 =?us-ascii?Q?+L4jTKgneCf32z8jUN1yR0yl6f+ssZNVo7OhdQvZxULYeBWPl7KwSwykQQsm?=
 =?us-ascii?Q?EEKRFOExn5G2KhKd/4MIdaVcAUaUp2qJKPYRs93Rl6Ka+QSkcc7dIjf7X/i0?=
 =?us-ascii?Q?7Al5ONU8iReFqVTw6DIpf6wwG5VeNRBAKVfZioWvyErXb8lADmjfHPhyoiU0?=
 =?us-ascii?Q?ibOXNKlAE49ybGIhwaxKCJjDzb0Mvlc2iIpapZqfj8VDkUQ15nKUclmuMyGw?=
 =?us-ascii?Q?LTfY/JlMRfsNa4kvZdF57s4NoNlgrhJ/+Za5TohAbcUrW4M97G8UHaDiGQ4V?=
 =?us-ascii?Q?5cr6R6A7CinteP1zKr3rKOt8VcKkwe+xpf3DH7c5nAUmnS0NIj5zAeYskSAe?=
 =?us-ascii?Q?gIlh?=
X-OriginatorOrg: qti.qualcomm.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR02MB7951.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca0b8dd1-ede2-4fa6-05c6-08dbbb501c1d
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2023 09:41:34.6486
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i38qMe+HF/iTRYNJ1MiGJ7K2Q3sxs0c1nMn0HQu14dxgoxN2ockCSFNpd5tbWHCODk/tynLoUWjGE4qSmMF1Yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6694
X-Proofpoint-GUID: gdz57Yt294UDLUloNogL_pX6ab8U7lsS
X-Proofpoint-ORIG-GUID: gdz57Yt294UDLUloNogL_pX6ab8U7lsS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-09-22_07,2023-09-21_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0
 priorityscore=1501 malwarescore=0 adultscore=0 mlxlogscore=999 mlxscore=0
 impostorscore=0 clxscore=1011 suspectscore=0 phishscore=0 bulkscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2309180000 definitions=main-2309220080
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 22 Sep 2023 02:42:22 -0700 (PDT)

Gentle Reminder. Please review the commit.

-----Original Message-----
From: Ramya SR (QUIC) <quic_rsr@quicinc.com>=20
Sent: Friday, September 15, 2023 10:25 AM
To: David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; Lyud=
e Paul <lyude@redhat.com>; Wayne Lin <Wayne.Lin@amd.com>; Jani Nikula <jani=
.nikula@intel.com>; Imre Deak <imre.deak@intel.com>; Alex Deucher <alexande=
r.deucher@amd.com>; Jeff Layton <jlayton@kernel.org>; dri-devel@lists.freed=
esktop.org; linux-kernel@vger.kernel.org
Cc: Ramya SR (QUIC) <quic_rsr@quicinc.com>
Subject: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port det=
ect

Modeset mutex unlock is missing in drm_dp_mst_detect_port function.
This will lead to deadlock if calling the function multiple times in an ato=
mic operation, for example, getting imultiple MST ports status for a DP MST=
 bonding scenario.

Signed-off-by: Ramya SR <quic_rsr@quicinc.com>
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/dr=
m/display/drm_dp_mst_topology.c
index ed96cfc..d6512c4 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -4154,7 +4154,7 @@ drm_dp_mst_detect_port(struct drm_connector *connecto=
r,
=20
 	ret =3D drm_modeset_lock(&mgr->base.lock, ctx);
 	if (ret)
-		goto out;
+		goto fail;
=20
 	ret =3D connector_status_disconnected;
=20
@@ -4181,6 +4181,8 @@ drm_dp_mst_detect_port(struct drm_connector *connecto=
r,
 		break;
 	}
 out:
+	drm_modeset_unlock(&mgr->base.lock);
+fail:
 	drm_dp_mst_topology_put_port(port);
 	return ret;
 }
--
2.7.4