Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Alexey Romanov <avromanov@salutedevices.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     Alexey Romanov <avromanov@salutedevices.com>,
        "narmstrong@baylibre.com" <narmstrong@baylibre.com>,
        "neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
        "olivia@selenic.com" <olivia@selenic.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "conor@kernel.org" <conor@kernel.org>,
        "khilman@baylibre.com" <khilman@baylibre.com>,
        "jbrunet@baylibre.com" <jbrunet@baylibre.com>,
        "martin.blumenstingl@googlemail.com" 
        <martin.blumenstingl@googlemail.com>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "lists@kaiser.cx" <lists@kaiser.cx>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-amlogic@lists.infradead.org" 
        <linux-amlogic@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        kernel <kernel@sberdevices.ru>
Subject: Re: [PATCH v3 1/3] drivers: rng: meson: add support for S4
Thread-Topic: [PATCH v3 1/3] drivers: rng: meson: add support for S4
Thread-Index: AQHZ5JhbK/N+gymR9EW47MRKmDtTx7AjAeSAgANcfQA=
Date:   Fri, 22 Sep 2023 08:15:27 +0000
Message-ID: <20230922081514.p7patdvkp4mujk6k@cab-wsm-0029881.sigma.sbrf.ru>
References: <20230911101129.10604-1-avromanov@salutedevices.com>
 <20230911101129.10604-2-avromanov@salutedevices.com>
 <ZQp7Rf3qzoN6c2Le@gondor.apana.org.au>
In-Reply-To: <ZQp7Rf3qzoN6c2Le@gondor.apana.org.au>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <649DC8FD1411CD4C87B0DBDF3645D2E3@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Hi Herbert,

On Wed, Sep 20, 2023 at 12:55:33PM +0800, Herbert Xu wrote:
> On Mon, Sep 11, 2023 at 01:11:27PM +0300, Alexey Romanov wrote:
> >
> > +struct meson_rng_priv {
> > +	int (*read)(struct hwrng *rng, void *buf, size_t max, bool wait);
> > +};
> > =20
> >  struct meson_rng_data {
> >  	void __iomem *base;
> >  	struct hwrng rng;
> > +	struct device *dev;
> > +	const struct meson_rng_priv *priv;
> >  };
>=20
> Is data->priv really necessary? It doesn't seem to be used anywhere
> after the probe.
>=20

Are you suggesting remove meson_rng_priv and putting a pointer to read
function in meson_rng_data?


> Thanks,
> --=20
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

--=20
Thank you,
Alexey=