Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
From:   Inochi Amaoto <inochiama@outlook.com>
To:     Conor Dooley <conor@kernel.org>
Cc:     Anup Patel <apatel@ventanamicro.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        aou@eecs.berkeley.edu, chao.wei@sophgo.com,
        evicetree@vger.kernel.org, emil.renner.berthing@canonical.com,
        guoren@kernel.org, jszhang@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org, palmer@dabbelt.com,
        paul.walmsley@sifive.com, robh+dt@kernel.org,
        xiaoguang.xing@sophgo.com, Chen Wang <wangchen20@iscas.ac.cn>,
        Inochi Amaoto <inochiama@outlook.com>
Subject: Re: [PATCH v2 06/11] dt-bindings: timer: Add Sophgo sg2042 clint
Date:   Fri, 22 Sep 2023 16:18:27 +0800
Message-ID: <IA1PR20MB49538AD51ADC3349B2AE8542BBFFA@IA1PR20MB4953.namprd20.prod.outlook.com>
In-Reply-To: <20230922-thumb-galvanize-bef393a1bda4@spud>
References: <20230922-thumb-galvanize-bef393a1bda4@spud>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|SA1PR20MB6987:EE_
X-MS-Office365-Filtering-Correlation-Id: 2c488745-cc43-4ef3-eaf5-08dbbb4485b2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: bbzRDTiFkx2RkOACkdoTBqF08xnwlRv4xwchDLcS1YDl9vFpAxgkbuSWlQ6EMS+qTtCjoDo+C2efWIivuyKuxuNVbrSGjQCgxg20vT+C9A3Nxl5cL8RSS1qfRaMXAg00wMJG/39FfbV0YnLXF7i8V4BKGwYW2netv+DSDqN7ctDjuKafRLsP4Wealktck7z+q3GNogXGTwnJCy0s9OL+xyK978SQ+hSp9NEN7QR23etuVOOACSpetQy3ZoOEWNLv4jM1lwRYP+Mu3y9HENgTTLHJdYPS9iOoi+qLLYxfDRwa20x9CUIgBH1LF4bBm6YpE+OPzXkWI3eyIB0nHHDL44J0Pk3tv1y814WWQ8c9sZZ/FtMqHMUT82Outz3+Mrx2U0fh2at+8BfGv9ZFnyycHJSQ7ccAgbYPHoqJrLUpUzfPNe+uLJn3Sz+Jg/L3DHLULiNo4XHX/Tye5uF2vgpksvncKMg0vyfa1LoH9SgeT/WkllQoe/xqttBYNUXInMoLlL32nU7HynHdYODWDQWhA+Gc5Xi+pG2EZpoKUObwGUOe7lPv3Fb/9jpMRRZ97dg4LVrTDr1qRuQMrcaekeRiK1XXqSYur4+o8j0onqboZOe+4K7r7YIQZcGy0t69mAup
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ov/G7UtRLRVKRcfVf9JLB8gDMkGahpFj2L9bc8Hhq39oAkX/OkqKBaMpAb2d?=
 =?us-ascii?Q?HiIPsIjjiKFlsoaTU9ABrJA+C4VmtFPpmbjvU+yptNwbuaTcOsxd9+lv9OJM?=
 =?us-ascii?Q?1OVvqoRxZ1KmmAD4JYPl4BxV0kdZimOqdcjj6k1ueSdy0PbgTltlSW+M7wge?=
 =?us-ascii?Q?+xJt0n9VhC6KiWCJ3doVneWeaQUcyshzEjn4Ey2w3e25EgAt8GY6W2hdirIB?=
 =?us-ascii?Q?He4nEAGTlwolVCBUrsvp40gSegPsOVLxoZW5HkGHTNubYt7k5p87NtwQhIwG?=
 =?us-ascii?Q?bLWdAM9shsJ/eFNlbzu8PLa6u2lZU91zmX8VX0n7VByrnYkcm+zeKMzoK4uc?=
 =?us-ascii?Q?o4VsomkRMF1hqM3/TR3hmQzq6uA/gM7gdn2XlCFhk85xVUgrn+SeqWlOpC6g?=
 =?us-ascii?Q?S0GXIpKhVbTnG+KhFiAs60Iklk+ORv6RYmZIqWi+kccEhyTrcoQ0fcBgQave?=
 =?us-ascii?Q?WTw3fBqUQYxF7pBEzoj6np/zq6i9OFDiA4/vtJPrcLWsiqxdZrORY2ckNfRK?=
 =?us-ascii?Q?EEl4KhMKoTxtZ+xd0b5JK1IK81OUmpY+qM9vmePCk66irb4L9vBC8pXvlpH/?=
 =?us-ascii?Q?wHnWjwr8CeBvOWjivvGKnDJQUyCePM5TmiLvv1VUN9pZg8ZtduUIdC+rPsxf?=
 =?us-ascii?Q?v2ohF1nAUKW8NPsa5o0m/a2SWuuy5zgHeK51r2iOe074jJ8h4Q2QIr1Qsxwc?=
 =?us-ascii?Q?vPMI8KDFSwb1CFnH9wyVKSSc7YJhF6T2zx6MAeiY6c3mQZXR/PDBq+TSTHLV?=
 =?us-ascii?Q?eMECCYqJDJWBdRBSQaJnOH3VhBd87vr0LMP+Wq6Ae6pf0uHcaLzT1sbG8xU6?=
 =?us-ascii?Q?qdPRTTt3HY+I9SZI3aEhPG5ENdtMKH3SjDl/png9BO/MZ4tUBzWq3QVP8XIN?=
 =?us-ascii?Q?/OxnV3I4NJpkvhASbvoQIGzxlolyOPYdN2F3+x6sGx1YrELjIdoCOBbRAQLt?=
 =?us-ascii?Q?OvnSpQPdJ4FfKeDfZQW5pHHGVXoepMGs4n61qBEB6LqG4DmneMStb3XDpPpL?=
 =?us-ascii?Q?E91TbCnMK6PqCgJ/PaFLPilqPfAuj0pM25efe/NIIfcBL2DzkUjsihxO5lql?=
 =?us-ascii?Q?zkdItfPVpZgR+MgJvSUob9epaLUccRSXfWJKJkBodY1EqBBpNGucrNpLPf7I?=
 =?us-ascii?Q?udQVJqnMdEPmButFYUy/BeM9hvT/QbNTiMdZiHzBI1YIbP0oFqWz88RHCF+I?=
 =?us-ascii?Q?vWuaiY6w1JwxFH4f5ePLpSVtkqgeONyj13gP6v7+aMfVUzyvj4/CUNcYD5Q?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c488745-cc43-4ef3-eaf5-08dbbb4485b2
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 08:18:38.1794
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR20MB6987
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 22 Sep 2023 01:18:53 -0700 (PDT)

>
>On Fri, Sep 22, 2023 at 01:16:35PM +0800, Inochi Amaoto wrote:
>
>>>> The SiFive CLINT has flexibility related limitations which makes it
>>>> not useful for multi-socket and mult-die systems. The SiFive CLINT
>>>> is also not useful for systems with AIA because with AIA M-mode has
>>>> a new way of doing M-mode IPIs. Due to this reasons, the RISC-V
>>>> ACLINT spec breaks down traditional SiFive CLINT into two separate
>>>> devices namely mtimer and mswi. This allows platforms to implement
>>>> only the required set of devices. The mtimer as defined by the ACLINT
>>>> specifications also allows platforms to place mtime and mtimecmp
>>>> registers at different locations.
>>>>
>>>> Refer, https://github.com/riscv/riscv-aclint/blob/main/riscv-aclint.adoc
>>>>
>>>> We need a separate DT bindings document for ACLINT MTIMER
>>>> and ACLINT MSWI because these are separate devices. The
>>>> Sophgo sg2042 SoC should add their implementation specific
>>>> compatible strings in this document.
>>>
>>> If the spec isn't frozen, I'm not accepting a binding for the "generic"
>>> version of it. Bindings for this specific implemtnation are okay.
>>> For sure though, squeezing this into the sifive,plic binding isn't
>>> appropriate.
>>>
>>
>> It seems I have missed a point. I wonder whether it is better to add a
>> "aclint" binding firstly and then add sg2042 to it, or just use sg2042
>> specific binding?
>
>sg2042 specific, being frozen is a requirement for merging patches
>related to RVI specifications.
>

Thanks

>> If use "aclint" binding, I wonder it is OK to add
>> thead quirks as compatible specific properties, or left this to the SBI to
>> handle? e.g. T-HEAD timer is not 64bit timer, and we should identify this.
>
>The compatible string alone should be sufficient to identify the width
>of the timer etc.
>

OK, I will take it

>Thanks,
>Conor.
>