Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <8df8d6dd-d0fc-908e-77c7-a67167e1c74f@redhat.com>
Date:   Fri, 22 Sep 2023 09:33:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] memory-hotplug.rst: fix wrong /sys/device/ path
Content-Language: en-US
To:     Wang Jinchao <wangjinchao@xfusion.com>,
        Oscar Salvador <osalvador@suse.de>,
        Jonathan Corbet <corbet@lwn.net>, linux-mm@kvack.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     xulei <stone.xulei@xfusion.com>
References: <ZQz1NUATBMOb3RT+@fedora>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <ZQz1NUATBMOb3RT+@fedora>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22.09.23 04:00, Wang Jinchao wrote:
> Actually, it should be /sys/devices/
> 
> Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
> ---
>   Documentation/admin-guide/mm/memory-hotplug.rst | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/admin-guide/mm/memory-hotplug.rst b/Documentation/admin-guide/mm/memory-hotplug.rst
> index cfe034cf1e87..01595965734a 100644
> --- a/Documentation/admin-guide/mm/memory-hotplug.rst
> +++ b/Documentation/admin-guide/mm/memory-hotplug.rst
> @@ -250,15 +250,15 @@ Observing the State of Memory Blocks
>   The state (online/offline/going-offline) of a memory block can be observed
>   either via::
>   
> -	% cat /sys/device/system/memory/memoryXXX/state
> +	% cat /sys/devices/system/memory/memoryXXX/state
>   
>   Or alternatively (1/0) via::
>   
> -	% cat /sys/device/system/memory/memoryXXX/online
> +	% cat /sys/devices/system/memory/memoryXXX/online
>   
>   For an online memory block, the managing zone can be observed via::
>   
> -	% cat /sys/device/system/memory/memoryXXX/valid_zones
> +	% cat /sys/devices/system/memory/memoryXXX/valid_zones
>   
>   Configuring Memory Hot(Un)Plug
>   ==============================
> @@ -326,7 +326,7 @@ however, a memory block might span memory holes. A memory block spanning memory
>   holes cannot be offlined.
>   
>   For example, assume 1 GiB memory block size. A device for a memory starting at
> -0x100000000 is ``/sys/device/system/memory/memory4``::
> +0x100000000 is ``/sys/devices/system/memory/memory4``::
>   
>   	(0x100000000 / 1Gib = 4)
>   

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb