Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <641d0bc9-94ba-478b-9626-b5acef4ef892@amd.com>
Date:   Fri, 22 Sep 2023 15:53:31 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: rom 3540f985652f41041e54ee82aa53e7dbd55739ae Mon Sep 17 00:00:00
 2001
To:     Ingo Molnar <mingo@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        x86@kernel.org, peterz@infradead.org, leitao@debian.org,
        mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, leit@fb.com, dcostantino@meta.com,
        jhladky@redhat.com, eranian@google.com, ananth.narayan@amd.com,
        ravi.bangoria@amd.com, santosh.shukla@amd.com
References: <20230914140604.267672-1-sandipan.das@amd.com>
 <ZQ1mdoMBJd4PCvZa@gmail.com>
Content-Language: en-US
From:   Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <ZQ1mdoMBJd4PCvZa@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU9OcGxBZitYVW02OGxvajMwVFJLUXhQWjVITStOeFZHcmZGaDRWQTc3T2RO?=
 =?utf-8?B?YzNkbld0ckZwL1hxdjcySnJsc3RiaE1hRmNORVYrMjBESEV4akVKY1U1ZThC?=
 =?utf-8?B?Y1VCWll3M29IVFZFL3VtMjFDbGtmQWJPOWp1QVR3Zzl4SlpCM3E1MzhLR3VG?=
 =?utf-8?B?WlpvTDZSZG1BUHZMamRNOHgyR3VPTlFic29za1Z5UXE4czFhVGpYODVlYlRB?=
 =?utf-8?B?Q0FuQ1RPV2pjaWhXUFBPb0liWFE1QmNsdGpZR3RTbkxaMStNZTlEQklMaXVw?=
 =?utf-8?B?N0VHSlNhNW9MTzRJNzlCaVZ3am80S2lVNnhva0NuVjB2QXNvenF2NEhtdlV5?=
 =?utf-8?B?N2pwUmxwQjNueCthRzdPS0tJOTRobFp5dVVabGEyOEpSVTl0VGxiUlNubGtU?=
 =?utf-8?B?bmZCTjVwVi9PV3NjV0cvQTRZR242VUZZSGpvckZZYjFQbmNaTjA5aUpaeWIw?=
 =?utf-8?B?WVlHTC9iOFBUaTBzSWVSWHlzUURDNmdQTTFoZkE0SDlrdUVHcmxnVWk0aDQ1?=
 =?utf-8?B?ditBZGR6ZTdkZ3NhaHlMUTIzbFAvRjlmR1ZVVVQvWGVQNXZPYXNZZW10bUdH?=
 =?utf-8?B?TTZYN0lhOWhlU3RxdG9GSGk3anl2MkQ2YWdhSlJEU2gyYWwrSVhrbUFqNjdu?=
 =?utf-8?B?c1dnWEJEaUY2aTdGQStXdE95ekxVbkZSU1hLMUd4ZnNHWXZEMS9yR3ZOYjI3?=
 =?utf-8?B?Vnd0V2IzNnIrMFRhcVh6a3JITnBrOW9GTWs5VU9kL1Vrb2NnR3M5all2ejcw?=
 =?utf-8?B?TU1maWNBUzhlZDZqZ2ZQTjZTNlROUTFaLzRGTWxwajF0ZGdDcDlWSUtJOTV0?=
 =?utf-8?B?T3R3Q2FjRlNZQURnalVGUkk2b2lrZzE3US85ZExrN1dRVi9oeDhjcXFFMEVw?=
 =?utf-8?B?amM4U3dscGg4N01Ed1lQNW1waTIrUFdabjdNVTVZZytLOGp5UXVNZHI0NHNw?=
 =?utf-8?B?RUNsRm1qYkgzQzdGNEtSZmF3d2lPSVRHdHlMVDVOVXE2cGFtQ3U1dlFQZm83?=
 =?utf-8?B?VVczKzFIbkluL0YwSkh0Ym90RkY5LzFKZkNUeWN4aVJaUnA4dXd0SGx4ekZJ?=
 =?utf-8?B?bEl5MTZnUHh1QXhKanlsTzBhQTJPZVB5NTVmcVhEdW9JSFJaU0pCL3U4WFkr?=
 =?utf-8?B?TE85K2swY2dMTzkrczc1NXBDR21sSkpyS0FacmRiY0svUmhzWFl4Nmp1b3NI?=
 =?utf-8?B?dmExY2x3cGhISDVaWFRpbC9nZitXV0ZEZ1ZvSkpXeE83SmFXcGpLR25QRGdW?=
 =?utf-8?B?cFBsOGFBTnNFQXg3VWc1MytzUm5OUWZXWVQrRUJTZTJGa3RHYlFCRFFOMllC?=
 =?utf-8?B?WDAvK1k2QjNHS2srR3hkbG50bGZvcEdoTU9zWjBwMFBkVS9EWmorZDhwMUpL?=
 =?utf-8?B?WEh5SEJZUGtmVHNoMjllcFNNbHpWS081Qjl2cXZ6cnVidUhISEl0NHRlNXZR?=
 =?utf-8?B?ek5iKzJSNEFsdElVOHJHSzRRcHI2ajQvNGZuaFBBZk83RTlmUmdaVmg3dEZw?=
 =?utf-8?B?NmJDTWVpbUU1aldrcmpVVjVyN2lMbStsQS9rbDFSRSsxSjJhLzlRNEJHQUdi?=
 =?utf-8?B?eGZTcXpvWVBYS2NDZVBxTXZhWXNwUjhZMi9NMU9CUHEzd1JTWC8rZDRCTlls?=
 =?utf-8?B?TVQxb0N4VHBCck5iNDlLWGRMN0RMSGhBZTBxVGZ6WmhBSHcwa2pGWEFtYUVa?=
 =?utf-8?B?QmZMZXNvTisyZGJreFVOM1pKY1JsRkIzZWpJbkQwQVFScjFPOFU2RWpuMDZw?=
 =?utf-8?B?MFdLNVN3RVd1d08wa1dNOGJyUEVBUVcvZnhWOGxCYU9QbXo2SmYrRjBEZDE5?=
 =?utf-8?B?eXdTVE5MN0JUeit2RHhTMlM4aUE0ZDNSc01BZS8xOU1UN2pzZGJCUTRKOHRR?=
 =?utf-8?B?QXN5c0RWVEpuTkU5UUREOCs4UW12d2FzenVSYWNKeXRZQ3B1QldqUC90MzBJ?=
 =?utf-8?B?SkZLdURpUVpKb1R4NE5paTZMWVpwL3ROK2dqMFl4TDJ2dTYvb2F5dFdKcVhK?=
 =?utf-8?B?eEJFVUgrU3UrTWdwYVBwU3M0TkRQMVRrRTVZVTdXZFNMZW5EREVLR1VudVdu?=
 =?utf-8?B?T1lXcFpTZmJocDMwUWN4emI2bVMyUnAyaC82Zng1SnloVkp5YWlqSUZrVGhX?=
 =?utf-8?Q?HOBWlsFeN51MlYasuYremXXs4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b1f564b-656e-4725-9f2a-08dbbb55fba3
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 10:23:37.5469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Wsw/FynxVcpuT1bDnxUzJfkR2XBT5knifBzIU6V1ylhs0bdHc4mOMbPy8t6g8u+nAvSCNE+r3eFJ7u04qZjHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5310
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 22 Sep 2023 03:23:50 -0700 (PDT)

On 9/22/2023 3:33 PM, Ingo Molnar wrote:
> 
> * Sandipan Das <sandipan.das@amd.com> wrote:
> 
>> Zen 4 systems running buggy microcode can hit a WARN_ON() in the PMI
>> handler, as shown below, several times while perf runs. A simple
>> `perf top` run is enough to render the system unusable.
>>
>> WARNING: CPU: 18 PID: 20608 at arch/x86/events/amd/core.c:944 amd_pmu_v2_handle_irq+0x1be/0x2b0
>>
>> This happens because the Performance Counter Global Status Register
>> (PerfCntGlobalStatus) has one or more bits set which are considered
>> reserved according to the "AMD64 Architecture Programmer???s Manual,
>> Volume 2: System Programming, 24593". The document can be found at
>> https://www.amd.com/system/files/TechDocs/24593.pdf
>>
>> To make this less intrusive, warn just once if any reserved bit is set
>> and prompt the user to update the microcode. Also sanitize the value to
>> what the code is handling, so that the overflow events continue to be
>> handled for the number of counters that are known to be sane.
>>
>> Going forward, the following microcode patch levels are recommended
>> for Zen 4 processors in order to avoid such issues with reserved bits.
>>
>>   Family=0x19 Model=0x11 Stepping=0x01: Patch=0x0a10113e
>>   Family=0x19 Model=0x11 Stepping=0x02: Patch=0x0a10123e
>>   Family=0x19 Model=0xa0 Stepping=0x01: Patch=0x0aa00116
>>   Family=0x19 Model=0xa0 Stepping=0x02: Patch=0x0aa00212
>>
>> Commit f2eb058afc57 ("linux-firmware: Update AMD cpu microcode") from
>> the linux-firmware tree has binaries that meet the minimum required
>> patch levels.
>>
>> Fixes: 7685665c390d ("perf/x86/amd/core: Add PerfMonV2 overflow handling")
>> Reported-by: Jirka Hladky <jhladky@redhat.com>
>> Signed-off-by: Breno Leitao <leitao@debian.org>
>> [sandipan: add message to prompt users to update microcode]
>> [sandipan: rework commit message and call out required microcode levels]
>> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
> 
>> v2:
>>  - Use pr_warn_once() instead of WARN_ON_ONCE() to prompt users to
>>    update microcode
>>  - Rework commit message and add details of minimum required microcode
>>    patch levels.
> 
> 1)
> 
> I don't think you ever re-sent this patch with the correct subject line.
> ( Or at least it's not in my mbox. )
> 
> 2)
> 
> So if the fix is from Breno Leitao originally, then there should be a:
> 
>    From: Breno Leitao <leitao@debian.org>
> 
> at the beginning of the patch to make authorship clear.
> 
> You might also want to add:
> 
>   Co-developed-by: Sandipan Das <sandipan.das@amd.com>
> 
> to make your contributions clear.
> 

Sorry for the confusion. I did resend this patch with the correct authorship
and it can be found here:

https://lore.kernel.org/all/3540f985652f41041e54ee82aa53e7dbd55739ae.1694696888.git.sandipan.das@amd.com/