Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <115d5d08-c81d-6206-84fa-15b70d1ab4b3@axentia.se>
Date:   Fri, 22 Sep 2023 11:15:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] i2c: mux: gpio: adhere to coding style
Content-Language: sv-SE
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>,
        linux-renesas-soc@vger.kernel.org
Cc:     Peter Korsgaard <peter.korsgaard@barco.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230921085752.8686-1-wsa+renesas@sang-engineering.com>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20230921085752.8686-1-wsa+renesas@sang-engineering.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ly9FOHZ0dEo4V2xLVERocWRNL0xnR3hxeGRpOWhXcmRmYzVVUDJ1WXFMNGhr?=
 =?utf-8?B?MXFTMWdUbGVRb2kyRGljZEIrQW1Wb2tzd1ZxVmNVOG0yVDVzSDMwc29LNy9x?=
 =?utf-8?B?S0FHOTQ3Um5sYzc4cFhiVS9QVFpXYVlUUVNBMmd5MVRSUUwxUnRZaHJ2Z0tX?=
 =?utf-8?B?UnFFVUZkVE4xTmI4MFlEWmgya1FYT05DanZTNElOVkVYb1prZ3ZqdldtL3ZM?=
 =?utf-8?B?Zit3WkJ6U0ltanRVUjlJaTVhOWNHTFZUazZrYitHaGZXdVovRkJJMUtOdG5a?=
 =?utf-8?B?SFBnNTg3T3J0Y2pCUStPUG96SGlicEsrYnJOcHEzS01ZcEVMTk5GMzdNV09R?=
 =?utf-8?B?cGNFeVlib3MxUC9SRUhLZkg1Wm8yRkl2UlZYRkpkd3hpZTI1MG1vTzRLTkxM?=
 =?utf-8?B?U2xhbGk1RmJCUmkxWEQvb3hacUhCSEdmN2hKbUt4ZTdOYllia1NESTBKZkRh?=
 =?utf-8?B?THhVZnFwNkJwWVJvbENwZ3M0RGtITXNIRzdRbVZQSjdpa2JHMWRtMGdPNXlF?=
 =?utf-8?B?SkRLdDFoNlNwNXFDdng3eWN6dklJcUYrSVBYSGV5WjBXL0t4UDExd0UyT05P?=
 =?utf-8?B?dG4xaEwzbzVmbUFCL3BnaHl1TGtFbGl3ekJSanJXbVdUZC9rdzNvU1d3cGxl?=
 =?utf-8?B?Q0VjYTQ4QnhzMzlvYlpQams4NnN1SUFLUFlubkRsVVlpR0MweHRtK2xvZ0JC?=
 =?utf-8?B?aklvWEloV1F1QnpCaWxKaHllRGltVDQ5cnFJWGtST3lyK2x3ZjZUYmJsMlFW?=
 =?utf-8?B?d0hnOC9KbWJsam9yMmtOMEhUMVRwVXlub2xXRTJEUEMyL0Rlck9SOHpMRVo1?=
 =?utf-8?B?TmQyUVBlQTdBMzE1TlRRZm5DNWptMTFGaXh1MGVJdlp2MlA0MkMvWGt5TlhM?=
 =?utf-8?B?VWlRK0VQbmtQVHZ4UFNaM21PaDg2SkVvMTRZbXhuTFZOZ1dZbWU2L0UwUU9R?=
 =?utf-8?B?eVdtQnZTOGpKRzY4R3lYUDJ0SDhoN3BHaXEvQ0hWVC9jRnQyK3RIdGhKNWt4?=
 =?utf-8?B?cXNiUjFLVjR4MkxpNHB5V05XQ1c1L011RFZyY3hJTDNSaFZlQlhTdmIwaEU0?=
 =?utf-8?B?YkwyKzM2ZXpHL3J6UTU2WXhaZGs4Q0hNUi9sTUsvc3JqUTg5TGFRUFBXOHl3?=
 =?utf-8?B?eEx5c2lqbmxjZ2pCUGlvM09jcnBtQ3RUVENxaUF6UUZpNTlRMy92bTlzNnJI?=
 =?utf-8?B?djNmYjVLTjMwVzB6dnNOTkJYY1NFWnNpNlpZeVhLMWtzbDV4LzE4V095Rk1W?=
 =?utf-8?B?OUpwQVRudEpJM29vRER6TTVhRVlYOUJRNkprYmtKV3JxNkFoSEE3blRMNTVj?=
 =?utf-8?B?WTVtN0lPQzBEU2tnYmZDWWRFbzFMZm1mcjBiWnZPSzJaOGRoWmJoVU4xRE5l?=
 =?utf-8?B?QmhwVDNqTWV2aUVaMnp0d3B4YmNPQWkrKzJmdWdrOWtnNDhuYUdFOEp6S1N5?=
 =?utf-8?B?QkFzZEVkYThFcHMwWkZITzB4UHNFN0k0Q3h1MERRT2c3N283cDkyWk9PQ1pw?=
 =?utf-8?B?LzZnVjJpSkZMeHBaZUNhS3EzdzIrRGYydFNiZTFGajFQdklyZWdUTG9jY2Zy?=
 =?utf-8?B?OUJhSDRoL3d6V3d0dHh3SXN1djZkYXF4ajFBSVdZTGZBczRRMDAyWUJlUGUz?=
 =?utf-8?B?VXFrcnhTWTZSZHQveE85NFUvMmZ6UHV1MDlSSTNOa2hwcjdoUnQ0MmV0b3B3?=
 =?utf-8?B?ak56VEw3TmU0NEJSSG9MRXVPSEk2aGt2QVZ0SVJXeEVZeitSZmFKd2xYVU1t?=
 =?utf-8?B?UWx6Rm8wUU9JYXJ6OXhZNVZWRGVKTVNmdlFDcmFJVmlsZ0pldjg0VGF6RFZk?=
 =?utf-8?B?ODQ4Q1lkZ0l5M1U4ZjllZ0huOGxSelNwTzFWckRWM29XZzlSekFGemdiWE1K?=
 =?utf-8?B?TDM2TU40VGtTZXNENnlmVkFxYlk3aTBjRUpkc0NEOXo5SnJEMWhYVFlQUzhq?=
 =?utf-8?B?ZzF6VUV4d3g0dWxlTlJLcGpBakNpdXNsRWVDZFBycUV5ajFXTmhuczZ3N2tn?=
 =?utf-8?B?dXlmbG1ZNWhYWTliSnV6QlVxRldLampGZGxtYmpwamJra2tSaWZubE5CTUJP?=
 =?utf-8?B?NHlHZEVWMXBhamptaTJzVGxHRVlqWWJldVEzcjdpaEhEZ05jMCtLc0RtTmlQ?=
 =?utf-8?Q?vhPUSqoCbHfI0EXX4C3Y7H3la?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: a8f151a0-c6b1-412a-4be3-08dbbb4c7e2a
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 09:15:41.3372
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LoRJSmIGLR8ZAnLIDEUtmmN+Doh93YClb6kcZIgl58hvnoMyIRfWPbTmmSEq4qmH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR02MB9816
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 22 Sep 2023 02:16:13 -0700 (PDT)

2023-09-21 at 10:57, Wolfram Sang wrote:
> Advertise our coding style by following it :)
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

A no-brainer...

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter

> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index 5ca03bd34c8d..0419c7453281 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -23,7 +23,7 @@ struct gpiomux {
>  	struct gpio_desc **gpios;
>  };
>  
> -static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
> +static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned int val)
>  {
>  	DECLARE_BITMAP(values, BITS_PER_TYPE(val));
>  
> @@ -59,7 +59,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>  	struct device_node *adapter_np;
>  	struct i2c_adapter *adapter = NULL;
>  	struct fwnode_handle *child;
> -	unsigned *values;
> +	unsigned int *values;
>  	int rc, i = 0;
>  
>  	if (is_of_node(fwnode)) {
> @@ -102,7 +102,6 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>  	device_for_each_child_node(dev, child) {
>  		if (is_of_node(child)) {
>  			fwnode_property_read_u32(child, "reg", values + i);
> -
>  		} else if (is_acpi_node(child)) {
>  			rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i);
>  			if (rc) {
> @@ -127,7 +126,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>  	struct gpiomux *mux;
>  	struct i2c_adapter *parent;
>  	struct i2c_adapter *root;
> -	unsigned initial_state;
> +	unsigned int initial_state;
>  	int i, ngpios, ret;
>  
>  	mux = devm_kzalloc(&pdev->dev, sizeof(*mux), GFP_KERNEL);