Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <13c19c01-65ee-44ae-e11a-d3b108c5a97c@intel.com>
Date:   Thu, 21 Sep 2023 10:52:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time
 undefined reference errors
To:     Alexander Lobakin <aleksander.lobakin@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     Michal Michalik <michal.michalik@intel.com>,
        <netdev@vger.kernel.org>,
        Richard Cochran <richardcochran@gmail.com>,
        <linux-kernel@vger.kernel.org>,
        Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        <intel-wired-lan@lists.osuosl.org>,
        "Milena Olech" <milena.olech@intel.com>
References: <20230920180745.1607563-1-aleksander.lobakin@intel.com>
Content-Language: en-US
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20230920180745.1607563-1-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFk1MlBLWUNubThCRWlhaFlzNStZUWdIQXlLeks4OWw5ejR6N2tIc29aMHlv?=
 =?utf-8?B?RjVoY01KdkFXOHFvMk9XM0ZQUG1pbndTaGkrS2lobGRRUEZXbExzZXlHMTZX?=
 =?utf-8?B?WjN2cUZDbTRXQW9nOUNDUm9iQjlER0JTR3B1Z2UvQThqUlZBMlFuMnlLaE1I?=
 =?utf-8?B?SGZXcDF4czNTNjNPQmVxcHRxVzBwR0lkTXdUUHY3VEtHWFpXSkFISC9EdHp4?=
 =?utf-8?B?Z3Z4V21IdmcvbzI3VWlmSERjOTVURVZKem5VUUJzcUFwTmUzYy9IVlBQOHNH?=
 =?utf-8?B?V0xmemw1NHhodEg0MjhCcnJQMExsWmhuVklxdHBjdzZDaEQvc3dJc3NGMDBP?=
 =?utf-8?B?SU9OZzgvc3RXN05ZWk15VEdrTDVHUStNdE9sK3NVM0pVMEVmRjNWZ1FWcjJD?=
 =?utf-8?B?cTNDVEQyUnZDSjBSUVdVTjdhQU9WY0VrVHg2dzFGZ1VaWGk5SGt1SXI4ZVpH?=
 =?utf-8?B?WENmQi9nQXJYWDZLd2FNL1JTZHlWU2RzNmwxM1I3Vkp1TVNrejU1cXVaRlU1?=
 =?utf-8?B?Zkp6V0s3d3F4VEJoU2pHdEtmOXRNZ3phcGwxVU5MaXpENVhSaHhlTzN0blpU?=
 =?utf-8?B?U1Y4U0pCeTdqVndSdUdHVXdESlA5clNQU3VjMCtJN2JodDgydWZSb2lPNFIz?=
 =?utf-8?B?d3lxTDhYTk8vL1NobHlqL2twQUVpK2lRTkFKSVg0anhHSElQUi9QV1F6UlQ5?=
 =?utf-8?B?RnB1UVNyTEVlWkJIaHNYdkNNakZ4Z0VrNUNiMHE2Nkw3aXRXbENPOHRMYm4z?=
 =?utf-8?B?eDAyV0NQejFrQkF4WTNUeFVsb1lkY0RGVHhyNkFIZUZUM3BzMnVIbjg4YmRX?=
 =?utf-8?B?aFpxdnBYNUc4R1AvOERSeEVmVG9uSFhnODhrK3BMSkZTSWtsRWpyREpXS0VF?=
 =?utf-8?B?RGJmdUlrejRMNzlzSEY1TVFQc3gwSjl5Y1U4L25yT05iLy9jRnJYLzZPaGhj?=
 =?utf-8?B?cEQ3U0hFM1Zib04zTURJRDA5a1F6ZVNBekpuSDdBeTFaM3RReUc4cC9VdWMz?=
 =?utf-8?B?N29LcFZSMG5kRk1WQUl6Z3ZzcWFCaDdGRm9kNmp4LzhTR25RdlVPRFpPcldO?=
 =?utf-8?B?YVM2dGlRVERNWitQSVdKbzc0bkM4cGJ3WXdLcGROcHlXT1lzRjgxV2JwODNm?=
 =?utf-8?B?ZkFGdllyaUx3QzlaRzg5YXV2SFhTa0I5cWFBWU9VaFQ0czhxOExiZDFDa21p?=
 =?utf-8?B?K29UaHpYalZFOG5GaFVBSlNjY3ZnZThIVDRuZmRjSW15N0pUUEtOUnFaUm81?=
 =?utf-8?B?a2VSL1VTVEtBb3RJS3g2cmo0TDhYWlVOM3Y3MW5XYXFpWHdUVTN6SnEwc3VR?=
 =?utf-8?B?bEgvUGtadDlyNUN6R1FaS0IzbUhhOEh4YWVBTEpEb0hYYlhTTk40cVdxWjJQ?=
 =?utf-8?B?Tm4yUVRmRnJySzVWRUhTMkdhRVdPWWlCSjRiR3gvbDJaNVRrOUpGcDZhQzY3?=
 =?utf-8?B?MlpMZk5kOGZhWHNCS2RWTGZwL0t0Vzk2YncvaE1jbWwyb1g3Ylg2ZEkvU1dw?=
 =?utf-8?B?VjJUd2tUbkYyKy83WHl2eXc2bkZFZUdDb2lwVkxESDBUTEgzRDJiTi9SNTUw?=
 =?utf-8?B?UEtmbEFYRzZpM1g0OEJEbnlPc1BlTnpWNTdVTTk3RUQ0RUVBTjg5cXpYa3dZ?=
 =?utf-8?B?elZ4R2I0RjN3a3Irbzl1bTZVOEg0VFlLS1F5NlduYmJEYzNwZDh1UzN0NGVC?=
 =?utf-8?B?dEpJbDYxWHBILzhGeWdHeEVZNGVvTk40YTc2UVdRTFFWRWY0VHQxNGNGSzBD?=
 =?utf-8?B?WGlWd1lqOVZuUDZjSk1ZMERWRmptSm13R3JCcEJEUTJvc0p0TXJZYzMzQko4?=
 =?utf-8?B?Qmw3cnBCdWpGRnduNWJMS2ZweC9WckNjQ1NHRjlyc0kvQzVtVUR4dk1kZkU5?=
 =?utf-8?B?Kzg4andkNGlUWHVkQUtNeThMWVQyNFdCM3VUVTlURlpvUjVid3VNOXBNNTQw?=
 =?utf-8?B?WHQ4bzJoaFl1OS9kNGpCdVM3cW4yMnpqbHFrWVpPb3dlZ0ZHWFgxNU50eGZK?=
 =?utf-8?B?MXJ4WnpWN3ljMUNIaFlmZ014aFo0bk1MVkJ2eDBkbVJlazFKYUJsRkoxSjBu?=
 =?utf-8?B?OHpuRklua0Zic1JjOHVvQnlqUitacHpsWUwzejVTYkduRnk4N3l5WGJESlNR?=
 =?utf-8?B?aWZZOHkxbGJDVlhHSXhhWVZ6K1F1MDdENU5Pd09hTzZPQVNFcFk1K0YrVHJV?=
 =?utf-8?B?dnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8695cbdb-f9ab-404c-dfcb-08dbba8027a3
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 08:52:59.3361
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iS7mHUKTxSujl+354q5MxItwOiwPp+jBCxPKDXJ2mVnD5TwLn547lUYgJSnp+BJqlSuZ2ZmWQPGlFbJHJMapKJnp/iBVb+wvklGHykPovrI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8696
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 21 Sep 2023 15:03:37 -0700 (PDT)

On 9/20/23 20:07, Alexander Lobakin wrote:
> Recently, several link-time issues were spotted in the ethernet/intel/
> folder thanks to Kbuild bots and linux-next.
> The fixes are pretty straightforward, just some stubs and CONFIG_*
> guards, so resolve all of them in one shot and unbreak randconfig
> builds.
> 
> Alexander Lobakin (3):
>    ice: fix undefined references to ice_is_*() when
>      !CONFIG_PTP_1588_CLOCK
>    ice: fix undefined references from DPLL code when
>      !CONFIG_PTP_1588_CLOCK
>    idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET
> 
>   drivers/net/ethernet/intel/ice/Makefile     |  5 ++---
>   drivers/net/ethernet/intel/ice/ice_main.c   |  8 ++++---
>   drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 25 ++++++++++++++++++++-
>   drivers/net/ethernet/intel/idpf/idpf_txrx.c |  3 +++
>   4 files changed, 34 insertions(+), 7 deletions(-)
> 
> ---
> Directly to netdev/net-next, build bots are not happy and the next
> linux-next is approaching :s

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

I like the `if (IS_ENABLED(xxx))` approach more than stubs :)