Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20230921114940.957141-1-pbonzini@redhat.com> <169537583818.27769.18320521458994415527.tip-bot2@tip-bot2>
 <ZQ1rwSJsO7A4HR8O@gmail.com>
In-Reply-To: <ZQ1rwSJsO7A4HR8O@gmail.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Date:   Fri, 22 Sep 2023 13:18:09 +0200
Message-ID: <CABgObfbiO5Jm-S_1TVi-NdO4GxMsJeagaEHYEFBJ_6ABFdhicg@mail.gmail.com>
Subject: Re: [tip: x86/cpu] x86/cpu: Clear SVM feature if disabled by BIOS
To:     Ingo Molnar <mingo@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
        "Borislav Petkov (AMD)" <bp@alien8.de>, x86@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 22, 2023 at 12:26=E2=80=AFPM Ingo Molnar <mingo@kernel.org> wro=
te:
> It's a bit sad that we are duplicating identical code.
> We are doing it in other cases as well: for example nearby_node() is
> duplicated between arch/x86/kernel/cpu/amd.c and
> arch/x86/kernel/cpu/hygon.c too.

It is sad, and yeah I looked at nearby_node() to see if that was neverthele=
ss
expected.

AMD and Hygon pretend that they are different, and use different families
for what is effectively the same processor, and that's silly. In fact back =
in
2018 (https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1741155.=
html)
I complained that if AMD and Hygon are organizing the family numbers so
that there's never going to be a conflict, it makes no sense to have a
separate vendor at all.

Yes it's not a lot of code but sooner or later some change will be applied
only to amd.c, because honestly who even thinks of Hygon...

Paolo