Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <d188250d3feb3926843f76ef3ca49e9d5baa97a7.camel@kernel.org>
Subject: Re: [PATCH] overlayfs: set ctime when setting mtime and atime
From:   Jeff Layton <jlayton@kernel.org>
To:     Christian Brauner <brauner@kernel.org>,
        Amir Goldstein <amir73il@gmail.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
        Nathan Chancellor <nathan@kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>
Date:   Fri, 22 Sep 2023 09:52:27 -0400
In-Reply-To: <20230914-hautarzt-bangen-f9ed9a2a3152@brauner>
References: <20230913-ctime-v1-1-c6bc509cbc27@kernel.org>
         <20230914-hautarzt-bangen-f9ed9a2a3152@brauner>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-09-14 at 10:39 +0200, Christian Brauner wrote:
> On Wed, 13 Sep 2023 09:33:12 -0400, Jeff Layton wrote:
> > Nathan reported that he was seeing the new warning in
> > setattr_copy_mgtime pop when starting podman containers. Overlayfs is
> > trying to set the atime and mtime via notify_change without also
> > setting the ctime.
> >=20
> > POSIX states that when the atime and mtime are updated via utimes() tha=
t
> > we must also update the ctime to the current time. The situation with
> > overlayfs copy-up is analogies, so add ATTR_CTIME to the bitmask.
> > notify_change will fill in the value.
> >=20
> > [...]
>=20
> Applied to the vfs.ctime branch of the vfs/vfs.git tree.
> Patches in the vfs.ctime branch should appear in linux-next soon.
>=20
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
>=20
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
>=20
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
>=20
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs.ctime
>=20
> [1/1] overlayfs: set ctime when setting mtime and atime
>       https://git.kernel.org/vfs/vfs/c/f8edd3368615

Christian, are you still planning to pick up this patch? I saw that it
was dropped from linux-next. Since the mgtime patches have been reverted
for now, it may be best for this to go in via the overlayfs tree ?

Thanks,
--=20
Jeff Layton <jlayton@kernel.org>