Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2726526rdb; Fri, 22 Sep 2023 06:59:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgdrCKLSToVeFx/85oA5Vd0zvms2O+63kkjAtWmmW7o17boBSgkcWzAhdWBMYSMnoycDsP X-Received: by 2002:a05:6a21:7895:b0:123:149b:a34f with SMTP id bf21-20020a056a21789500b00123149ba34fmr8769405pzc.1.1695391172219; Fri, 22 Sep 2023 06:59:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695391172; cv=none; d=google.com; s=arc-20160816; b=BsCEYOhQNEXaFCyivmh6Is6quENAOHVjrCFalUvg9TD/CSBFL063g+rNQ9UeXzH1ko u5JtOfNNvHl40PeUKw/xuDmImH1AuwvPpQxnxBFJ3zXgCpHfMC/wA01Ur9OBVSGDi9BX oncb3ywMsi3Z82x53EM8zBulC3IZ5znEHouQsAujXngR9jPoNWoKyCc8TAv/hQAx3X2l xoYcPN7zaNMBZ8WAhDqY/7z+OXKhGbNyfZOkAq7pip7tM6opIcI1E420/A94rNRvA3tn wZJ5sjFK0eVy4gNQO4RaIdC8mBMAVAIN5I58dzOTpCXOEUNh2iBxLKCOgXBGeyGDFE/E e8xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=a3e1ePilfke/k6Qp7d9hYq2+nWldVAMt7RwsHxtlTL4=; fh=5MxYHZNRJO1TqvxOGpImF9WsvfHxDBExNZIEX1T3FQ8=; b=XlpKfaVIwmTyA6X1BxkzVCEE6cr8P16qczm1EclQLNJPXTO0aIFMtbKtc80egeGw9X vxUvY4YhpiGPcZq9f1XyVkDpriwejDeYjsUWCWJY+eYIt/zbA5gU/+gp1ZhrrriDRJjb 7El0YSAqtNSWkAfd+6VyH4VN/rQ+Pder5IjNQ+Sa1VuA6J1yvBcJJW3csGO5dSQvc2U7 SuB+OuC5hG85+jdhmiHDjB41o879WhxHfykfFfdEikyblCO2Uha0aMUKeyjYcrepPOoa dDRUaY5lv4vceeo0hbUn9tHgnTfFFwpqyWyEPbEHt73g5VIW8CA2jntmS8A1FPutAVJ6 zg/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=A5NdbWWy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id h8-20020a636c08000000b005740d553e73si3837350pgc.114.2023.09.22.06.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 06:59:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=A5NdbWWy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 08F3C82F9275; Fri, 22 Sep 2023 02:28:50 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231328AbjIVJ2y (ORCPT + 99 others); Fri, 22 Sep 2023 05:28:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232887AbjIVJ2v (ORCPT ); Fri, 22 Sep 2023 05:28:51 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDFD5194; Fri, 22 Sep 2023 02:28:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3831BC433C9; Fri, 22 Sep 2023 09:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695374925; bh=1N0RINgSti7GRzCMQyRJ+M265Zpr0LcGBAeXkkytdkk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A5NdbWWyfeQM/bF2iQ2T5AUgeg79reBVyxgFzUiKXbM67xK/NrTLd1oohP74mkBl1 iIjMYzjzNI/6mPqWZp2kv3iCxemEu3ir0qK/ygNglaJS0Ti+WpoDhRR7vO6lNm3AYJ fN4lAXYOcKRM+UgWuVU5icQERgIgHYCTqwgI1luk= Date: Fri, 22 Sep 2023 11:28:44 +0200 From: Greg KH To: Brian Geffon Cc: "Rafael J . Wysocki" , Pavel Machek , Len Brown , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Kaehlcke , stable@vger.kernel.org Subject: Re: [PATCH] PM: hibernate: use __get_safe_page() rather than touching the list. Message-ID: <2023092227-underline-gave-cbef@gregkh> References: <20230921170045.4189251-1-bgeffon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230921170045.4189251-1-bgeffon@google.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 22 Sep 2023 02:28:51 -0700 (PDT) On Thu, Sep 21, 2023 at 01:00:45PM -0400, Brian Geffon wrote: > We found at least one situation where the safe pages list was empty and > get_buffer() would gladly try to use a NULL pointer. > > Signed-off-by: Brian Geffon > Fixes: 8357376 ("swsusp: Improve handling of highmem") > Cc: stable@vger.kernel.org > > Change-Id: Ibb43a9b4ac5ff2d7e3021fdacc08e116650231e9 Please always use checkpatch.pl so that maintainers don't have to ask you to use checkpatch.pl :(