Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2744391rdb; Fri, 22 Sep 2023 07:20:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyfU7F8uqa5zhuwm1hg7dH+euGsMy1Tv1ssRfYK5CwRBby7qQns8C38vdheXOwryL6HwVy X-Received: by 2002:a17:90a:ad04:b0:274:686d:497b with SMTP id r4-20020a17090aad0400b00274686d497bmr8138009pjq.27.1695392441296; Fri, 22 Sep 2023 07:20:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695392441; cv=none; d=google.com; s=arc-20160816; b=lJElyJQyFCOkms6Oa2ty/tj7DGe6Hk8cBpAADNyq1SQv0Et9umoKSVkY2s1CGKiZ/g OeVZrM8KdqtVClpkjICRDq+l6azNLTSG1CG+NTWtBdD+CS8VWN55ZJSBir0wwhhNI5R1 BX8VkkF6t+ijRFNjqaYYnzCzCFbEg5/YNJlHpnm9PIbk1iQzcEd+UR23glwc6uG79gZt nU+vDmeHAbeorOQ85OtUHagqQvRsdgVaFc2mwu+RkghsIwDLRI4L6T2ELGhhcrCSnQ/R aUGidbo3P87L6jMeNz6U4XokcAkCeE4L7bKxIfGtoXAuZ308cYnRi1xEB5rKh+bhESsj zDCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MdAErFIDtJF2aok0GnVr4qbvS7wlbfhjW31kAsaT0TM=; fh=3oUSWWYQ0rMHaNqDlm8j09K7pkfJE062n+5jIRWafQ4=; b=V1NvXuwqEgtsAktSv3N5FrfexdI1fNpdgXzyY0YfXoJtHNhLgekHURK4qPpYa7JyhG 7pnb2ioZqUJ5hsVEnI78yj8LhOvV/Ekhu1+M2JRetdeDKpcvyDrLGx5lshRgfMMwk05L VitIZ6nIxeXTDxrbsqVLjzigvUeQV9DMQ5Mhw9hUsW1h1PUsAYH/YGs8KVwlFnSPKIIe 5sGLwt9buztkD+jg6rkE4Gvdsmg4wqjT9Omh4+vMHGV9CFsWeAUKXvJn1W6Uzn95K8XF BHsb7n/bQHtgoSIbbGVSO1VQWgAlWxzHQx0pvluG18TrNAnxoJHPY9/FpzteoKx8Hyqi 7aGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b="LdcE/mVD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id ds12-20020a17090b08cc00b00263d00e1c54si3967693pjb.54.2023.09.22.07.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 07:20:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b="LdcE/mVD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 150C8807BEDD; Fri, 22 Sep 2023 01:42:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232662AbjIVImA (ORCPT + 99 others); Fri, 22 Sep 2023 04:42:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232589AbjIVIl7 (ORCPT ); Fri, 22 Sep 2023 04:41:59 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A56BCA for ; Fri, 22 Sep 2023 01:41:53 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id F1A6C1F45A; Fri, 22 Sep 2023 08:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1695372111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MdAErFIDtJF2aok0GnVr4qbvS7wlbfhjW31kAsaT0TM=; b=LdcE/mVDbs5WzXZqs+t8k/TsRrT9cfNDeqn6vNspXKLljjwMNEUaVRldUYdTMzjr98Syln TWvp71nvLHwXgAkAV3fF+sa37DJxaiKLB1GTkMRsU18NxjQX5jJ3BWJ6vfQDxQ17ZJZnJM dDrnC9H5xXcxiVR6Q2gajnXADH5G+Yo= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C0F952C142; Fri, 22 Sep 2023 08:41:51 +0000 (UTC) Date: Fri, 22 Sep 2023 10:41:49 +0200 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v2 03/11] printk: Add @flags argument for console_is_usable() Message-ID: References: <20230919230856.661435-1-john.ogness@linutronix.de> <20230919230856.661435-4-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230919230856.661435-4-john.ogness@linutronix.de> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 22 Sep 2023 01:42:02 -0700 (PDT) On Wed 2023-09-20 01:14:48, John Ogness wrote: > The caller of console_is_usable() usually needs @console->flags > for its own checks. Rather than having console_is_usable() read > its own copy, make the caller pass in the @flags. This also > ensures that the caller saw the same @flags value. > > Signed-off-by: John Ogness Reviewed-by: Petr Mladek Best Regards, Petr