Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2819188rdb; Fri, 22 Sep 2023 09:09:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjVjWxsyH5QrM8Ddw0HLmvQVUBaQD1eZzzcABnxmK0pgp9lQSzwC0yBLLc0lpklNI39Qcv X-Received: by 2002:a17:902:e74b:b0:1c1:fc5c:b31b with SMTP id p11-20020a170902e74b00b001c1fc5cb31bmr185263plf.9.1695398942555; Fri, 22 Sep 2023 09:09:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695398942; cv=none; d=google.com; s=arc-20160816; b=E10QpsvEKzCq3rb5A+DCSJ+ptUofguPV43Do3OCoPUwJ0y7Evw872kTxz09uNPqQ6c xAnOwIeuf5FMRNsqC/eXjkGsM7kIZL/xrxu5KWSG7ewAvNEYq60vvRQ7d3rH5z6YRV9u BCno457inV+yvichFFUM8ZFY6nWTOr+R/UHd7V1L6KTWiDi3Xs19QEPYUx9qodgj8cM9 blth4x0Vk6NpUPL6L1VATttin6WuUr1PP08xzJC43whpbQb/2IrDwyq16Z/XtKCSzpqq Fzihy/Q9+GaslE8DX6whTQubARscisdg3j4us6O8xarTp3v+1gpZYZZl/D4+tCRYzDIw Uttg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=iX4Uc8FfvKx4ID/8LMl3b/nkaYdNiiwnRRroEk8T5ss=; fh=zYvm2HZ41JMX9wa9RC7C29l5mRYJwaopQpGNM03iHiM=; b=qiVej/b8FvKVHkDkcQsiXSxcPLvVp1A+DxnawaSgqQVEDKiLfTN6wpQxZO4nhOYil+ FSM5PFx9m5aXMq0GpGAwENiepMXRQWj6ns81jkNIf61wVpTfkFXsVlUHNZWJNeo4LJES ihxBlD1dzb9ANdAaaBz4+I3PA1ZNp+pRlsl2fReHshlpPutZQl6cBQfSXYYmqcry7SwT L6AJy/4hPfC40s+caYNZI+nZs4P2oaBdbVUYmd33groHeZLKCvwK5blrDXKELsr9/6Dg 0RAJa+3kvXPmAhJATyvojlR8kkxrTZw+Pav+7BMx6Lw7UjXl4y9TsBU1UmZ2pRRnqPXs 4JJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=FeJ3OJit; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id w3-20020a170902c78300b001c469b401bfsi3877724pla.93.2023.09.22.09.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 09:09:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=FeJ3OJit; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 66749838F061; Thu, 21 Sep 2023 17:23:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229753AbjIVAW4 (ORCPT + 99 others); Thu, 21 Sep 2023 20:22:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjIVAWu (ORCPT ); Thu, 21 Sep 2023 20:22:50 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD2FE110 for ; Thu, 21 Sep 2023 17:22:44 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEF1EC433C8; Fri, 22 Sep 2023 00:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695342164; bh=5Y1dSArHCMohqCCw0o+1oDIRhU1jcUN2P68mhAF6WFk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FeJ3OJitd872v1C/2Uyd7XFKUmhWDaw0zhm25WIny4fOvHZpqhhmO5v43lXKFE5+x TIIrvH9ch66DY6PZDUcWLBovkJR7K7H0exdUOk9/44MV820WpWDBdvXQGu22PftktX 3TSb5VzLlMZZZfRx+M39E3Hmvxe8+siE/7QSS5Tc= Date: Thu, 21 Sep 2023 17:22:43 -0700 From: Andrew Morton To: Eric DeVolder Cc: linux-kernel@vger.kernel.org, bhe@redhat.com, vgoyal@redhat.com, dyoung@redhat.com, ebiederm@xmission.com, kexec@lists.infradead.org, sourabhjain@linux.ibm.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH] kexec: change locking mechanism to a mutex Message-Id: <20230921172243.d86a649d7afc835ff2caac26@linux-foundation.org> In-Reply-To: <20230921215938.2192-1-eric.devolder@oracle.com> References: <20230921215938.2192-1-eric.devolder@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 21 Sep 2023 17:23:02 -0700 (PDT) On Thu, 21 Sep 2023 17:59:38 -0400 Eric DeVolder wrote: > Scaled up testing has revealed that the kexec_trylock() > implementation leads to failures within the crash hotplug > infrastructure due to the inability to acquire the lock, > specifically the message: > > ... > > Convert the atomic lock to a mutex. > Do you think this problem is serious enough to warrant a backport into -stable kernels?