Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20230911214609.2201040-1-robh@kernel.org> <20230912065946.GC5285@atomide.com>
 <28c862d9-ca39-2dda-86dd-9ccc206c3a1d@ti.com>
In-Reply-To: <28c862d9-ca39-2dda-86dd-9ccc206c3a1d@ti.com>
From:   Rob Herring <robh@kernel.org>
Date:   Fri, 22 Sep 2023 11:23:29 -0500
Message-ID: <CAL_Jsq+8jisrwEqzz7tZnsV9g2+LmThwpO7sHRFA-zh+6q8XuA@mail.gmail.com>
Subject: Re: [PATCH] arm: dts: omap: Apply am57xx-idk overlays to base dtbs
To:     Andrew Davis <afd@ti.com>
Cc:     Tony Lindgren <tony@atomide.com>,
        =?UTF-8?Q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-omap@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 22, 2023 at 9:38=E2=80=AFAM Andrew Davis <afd@ti.com> wrote:
>
> On 9/12/23 1:59 AM, Tony Lindgren wrote:
> > * Rob Herring <robh@kernel.org> [230911 21:46]:
> >> DT overlays in tree need to be applied to a base DTB to validate they
> >> apply, to run schema checks on them, and to catch any errors at compil=
e
> >> time.
> >>
> >> Signed-off-by: Rob Herring <robh@kernel.org>
> >> ---
> >> Note that I have no idea if this combination of overlays makes sense.
> >
>
> It does make sense, but it is only one of many valid combinations. I'm
> guessing the goal here is just to make sure they all get applied in
> at least one way so the scheme check runs. In that case this is fine
> other than it might give the impression this is the only valid combinatio=
ns.

I only care that an overlay is applied to one base. You should care
about any combination a user might do in a bootloader because who
wants to debug a failure a) on a board and b) in the bootloader.

> Also now we end up with these odd `am57{1,2}x-idk-overlays.dtb` files
> which also might confuse folks, I wonder if there is some way to
> apply and check, but not ship/install these..

There's already a config option, CONFIG_OF_ALL_DTBS, which adds
$(dtb-) entries to the build. So if you have "dtb- +=3D
foo-overlays.dtb" it will only be built in that case. Note that they'd
probably get installed too, but who installs allyesconfig builds.

Rob