Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2844400rdb; Fri, 22 Sep 2023 09:48:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7fCQgq2Eo5f1uqeJ4QeGO4sVFIMl0xaWGSedKNdQ6idieCCFVq5j++L1UgyMEyrDzfoU6 X-Received: by 2002:a17:90b:38cd:b0:271:78a0:8ab2 with SMTP id nn13-20020a17090b38cd00b0027178a08ab2mr4301317pjb.24.1695401287038; Fri, 22 Sep 2023 09:48:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695401287; cv=none; d=google.com; s=arc-20160816; b=fkWsNR+oZe2KO71GTfLv1tLMbKH6z77JSGTqBxqc18WO5zLOaQEQXWS/hUWc8mfWyE hvpYEkEwuj3iv84EarDyDhn0n4wZEbxp76OPV2AQMeRRi+eBqaCGKc7qNRFbffDATfOy LC8A0YZr3RW0yGqyOA9hwVRwqy6O5XFJUoXhINpBJaikTg9+g0V9mkAEz2kc1VKTEpV1 +jfoe4//OkOss8hTAH8unkjdR9nBKKfa/yF9QEM2FdcsL3OElbOFHjPBlcTaw7Pa4vt4 F7e8deLTE80Z6+q3HWT8Bd1SL3VFLqBE/iKHaoDvqRtQiK+RKGrU6hQqdDOtfW09tMff mrZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0Sb/5Zc4jnMyvOYIuTGynHd4gTUJXJ8TiUqHAqxEkI8=; fh=3oUSWWYQ0rMHaNqDlm8j09K7pkfJE062n+5jIRWafQ4=; b=XQExOg3XAO2LwG53dM650Y2IzgzdIOk5DP/UUPZWfzFZBYUsndv3aTFmgfIoy8cHv2 OvNGkjlIa/65SELvaqAAnKBid04hPcTjyY4Mdu6Bio2mvPlZbHHQBcOzxW5AhjPMJF5I rHeT1dTwVQt7BUAsqnUl5s4FW+GOYjYF0fdf/Xjp4dL22ZPHIT0xc2UYOuCbsQmZkQdM Ncb5PW9fNeNSWQoRfFEoumdvmsYiammxoCyaTPC9QesH5WD+ETL92sWeKGPu6emKEtzL 7pHifz9E/WFA5lxdHC/oYxD/kzKQ8WKWrj1Zcnd1zX8kbhdZQj7ebAum0ijQIOf72ZIG wFMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=gpyeCkYL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id x23-20020a631717000000b00570a4303746si4082484pgl.560.2023.09.22.09.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 09:48:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=gpyeCkYL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 97A748343529; Fri, 22 Sep 2023 01:33:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232492AbjIVId4 (ORCPT + 99 others); Fri, 22 Sep 2023 04:33:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbjIVIdz (ORCPT ); Fri, 22 Sep 2023 04:33:55 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73D988F for ; Fri, 22 Sep 2023 01:33:49 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 30E8A21B4E; Fri, 22 Sep 2023 08:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1695371628; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0Sb/5Zc4jnMyvOYIuTGynHd4gTUJXJ8TiUqHAqxEkI8=; b=gpyeCkYLac/ut4aaXHbvmJ2u3lwCjh0H9A3BVTNlkks+nG6acV+yIaVu27cXlk17zYGZbG A90ObM/I2xeaISq481DJC1QasodlXwpgWYcvLYz0FKweq4MDr7YJbvwuw9EF0qGvyik20I i5G+reiiXpDZRfYoXUkOVqoa20XEzLM= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id CAFDB2C142; Fri, 22 Sep 2023 08:33:47 +0000 (UTC) Date: Fri, 22 Sep 2023 10:33:45 +0200 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v2 01/11] printk: Make console_is_usable() available to nbcon Message-ID: References: <20230919230856.661435-1-john.ogness@linutronix.de> <20230919230856.661435-2-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230919230856.661435-2-john.ogness@linutronix.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 22 Sep 2023 01:33:53 -0700 (PDT) On Wed 2023-09-20 01:14:46, John Ogness wrote: > Move console_is_usable() as-is into internal.h so that it can > be used by nbcon printing functions as well. > > Signed-off-by: John Ogness The function is relatively complex for being defined as inline in a header file. IMHO, it is around a sane limit, especially because it is not used in fast paths. Anyway... Reviewed-by: Petr Mladek Best Regards, Petr