Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2856387rdb; Fri, 22 Sep 2023 10:06:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESRQCNlMlUTZBar62XPQdkUxxMCt6SQ6oF6NkuohTQ8/aG9iwhniyzp6rnZgRW9x0gMy5/ X-Received: by 2002:a17:90a:8a0d:b0:271:ae4f:dd12 with SMTP id w13-20020a17090a8a0d00b00271ae4fdd12mr312122pjn.26.1695402417209; Fri, 22 Sep 2023 10:06:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695402417; cv=none; d=google.com; s=arc-20160816; b=OalUYPbfEWxgA4flY1ccEMUQEunMQcQhTp5j5ioSX6OJqF/V1FGRxvR5dDBnedP9wX UfoFNgM9OF5avgxlb0gN8m6rKzQvjHVBeX9GwOe7h79LAjpofbemeUWAcM0eHWyKtHSC 3gk4Zk7b9vGLL534/sIzUdcGeucwH0jgXsh8u1kRqCEByJk1Uv6KK7SxrNu85ce2QqBw s1+hH/VO5qLmZ8prWJAi/i7JTzYqHm3MHBtwpUhv/VY3TAbq67VCLgRvNr0S+GqfhtVh 3xKECdUrLrbioAlS2bdMY8KU/YwQ3RfyJXdEm/5J/odOMiSdIsTmPItPKi6GDd4Q1A3X TpVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ixwiziejrjHWtGdqHlJNM8EioiUtzsU3cyvRsBLO27Q=; fh=7KOcH8f2IU3ABqNJtZeHZKGRQRvWqmtZ+VKUtyiKxIQ=; b=HbQyrJ/E3g1+DTybFxBP0eEBb9tFd2qME3hZ9KFAXVMu64AZKNdVLDLyoXja8C8URv ddWWUw8tjuekMLTf+HnfwUmXmn4XhhPhmTlmYgsHvOvyk78IBPmzJmpCabLworSHktKJ 1dZbDx3nM/+lpOqvfxV22KqZRfDTtO/lgy9+666ByQGIWXJ+IbQ9gNf4dWMbQU5wYtEY juZDq/bV8k4cmTHHTbDFt+WFSwZ8NCeCEuAM3jjPW84gIBTB8UEz19edophda4m4kgcL /thWng1QrC/5rLFGrrW6jPJXVqlf8DKxQRtRR3yWwCEmKp0Unxc2oLGciOQIJ3mMWYdq uhXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linux-foundation.org header.s=korg header.b=uZWF7kJr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id e17-20020a17090a9a9100b00273f61d8773si4295608pjp.160.2023.09.22.10.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 10:06:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=fail header.i=@linux-foundation.org header.s=korg header.b=uZWF7kJr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 8B0AA844AB9D; Fri, 22 Sep 2023 10:03:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232846AbjIVRDT (ORCPT + 99 others); Fri, 22 Sep 2023 13:03:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230443AbjIVRDS (ORCPT ); Fri, 22 Sep 2023 13:03:18 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C39C194; Fri, 22 Sep 2023 10:03:12 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E909C433C8; Fri, 22 Sep 2023 17:03:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695402192; bh=qa/QJ12DIUWvIeySIX2g6kqd2yUHHXJ+BRw50a4IKNU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uZWF7kJrm5w73mco/RN5kh0tFZqol/wzUHts2vidpRz38ZzJryh0F8Jo8FNJ1KjRS fvytGPaP6DT92lWdNVq/FOf7os8h8kRVgIb6Q+blcoSlcD8L3qWYBYT5RU0unpOhYv ZQz8Myb6yh3K4y1JaIiCCoPWXMFcaasTV8Kdbmps= Date: Fri, 22 Sep 2023 10:03:10 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , =?ISO-8859-1?Q? "Michal_Koutn=FD" ?= , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] mm: memcg: fix tracking of pending stats updates values Message-Id: <20230922100310.102aa12ac2bdf0568e6e7432@linux-foundation.org> In-Reply-To: <20230922082542.466579-1-yosryahmed@google.com> References: <20230922082542.466579-1-yosryahmed@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 22 Sep 2023 10:03:36 -0700 (PDT) On Fri, 22 Sep 2023 08:25:40 +0000 Yosry Ahmed wrote: > While working on adjacent code [1], I realized that the values passed > into memcg_rstat_updated() to keep track of the magnitude of pending > updates is consistent. It is mostly in pages, but sometimes it can be in > bytes or KBs. Fix that. Clashes with "memcg: remove unused do_memsw_account in memcg1_stat_format", and maybe other things. Can you please redo against mm-unsstable or linux-next?