Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Fri, 22 Sep 2023 18:24:29 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        "Chang S. Bae" <chang.seok.bae@intel.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Nikolay Borisov <nik.borisov@suse.com>
Subject: Re: [patch V3 20/30] x86/microcode: Sanitize __wait_for_cpus()
Message-ID: <20230922162429.GKZQ2/vfYY21ty5bqR@fat_crate.local>
References: <20230912065249.695681286@linutronix.de>
 <20230912065502.022650614@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230912065502.022650614@linutronix.de>
Precedence: bulk

On Tue, Sep 12, 2023 at 09:58:15AM +0200, Thomas Gleixner wrote:
> +	for (timeout = 0; timeout < USEC_PER_SEC; timeout++) {
> +		if (!atomic_read(cnt))
> +			return true;

<---- newline here.

> +		udelay(1);

And here.

Otherwise it looks too crammed.

> +		if (!(timeout % 1000))

MSEC_PER_SEC - no naked numbers pls.

> +			touch_nmi_watchdog();
>  	}
> -	return 0;
> +	/* Prevent the late comers to make progress and let them time out */

s/to make progress/from making progress/

Nice, otherwise.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette