Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2903255rdb; Fri, 22 Sep 2023 11:28:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKayN0jumXqy5rml0Hdg9hEZrYI5jf7+BmfwC3hgP+y/TJQQrky2UFCfHgXB8wDZawfCt/ X-Received: by 2002:a05:6a00:1585:b0:68f:cf6f:e228 with SMTP id u5-20020a056a00158500b0068fcf6fe228mr236612pfk.23.1695407338511; Fri, 22 Sep 2023 11:28:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695407338; cv=none; d=google.com; s=arc-20160816; b=pOVTVGrWwbbtGx6jSYCoD8rC9cPV2ADB4NIjfjfbRqv/YdbyI1j5lNTaBdmDx1MB57 305+OK6jaPPC5TyTzUCrGefBLocmFFkbAiWvL6ajStk179nEI5i9Sgr42sljN6Mq4c/x p6Ezvlf7FMABP+8Z+WklMWAPACjuaF2LGkNi0B/gjAz2VUy4kt+M2jiYpHt7QKkWY6+o Cu5aPp4hVaP1ir6mi6uvlGuAAAoSFXqQDjVMm4fyowqsDjuooiBs/6bjm7W2clpTUgP5 pJvB4DI84BAeoR7SDhsv+hCPbnoYOcBVra08gF7nhCyAdcR9T/7xInDG6Y0cRc7IQVp/ VVSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=+xyd9IwCpJTRpcGWBwVDyX7y0WiRng0i7g5laRI0u+Q=; fh=9cVOWjEhgwQ2U5mTMuEbzNgoX0lbhP7Tfmd+yTG5cxE=; b=BjKBnI/a1oSX86k6ySlW4BBonvHRtJ9ZPdRa7T9kVN8zVqi5EskKI+FkkjxLaT1vR3 mPbn0xe3rgqVCuoE+7toB40EkD76n6YARQWAq1fx0bYlfBAYM5rRtmVOpzOKvhQ5FyjM peBM8mkQWTn3xggDt4wApPG+HzfEcJLSp7ztM+3kABRa3vuOCKbkgETgLBwdwVAKJOuF m9AoogO6EgpOlBT0RMAHkhh92NCeW6Mt5r1S9tQhLd0esnU8dSU5HAheqtn7NmJV6qOJ RLIS8MCA+b03gD+4ZXmQuB5k/ugYSnNZqEUPCfX7oTiHb9/NbYHCbM5XXoc3xsAIHrAg eGWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=a7nW5ZyU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id cn1-20020a056a020a8100b00573fffb12a6si4170203pgb.793.2023.09.22.11.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 11:28:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=a7nW5ZyU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E37EC82B4865; Fri, 22 Sep 2023 05:02:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233924AbjIVMCF (ORCPT + 99 others); Fri, 22 Sep 2023 08:02:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233961AbjIVMCD (ORCPT ); Fri, 22 Sep 2023 08:02:03 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 286E91A2; Fri, 22 Sep 2023 05:01:56 -0700 (PDT) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38MBpMlL001221; Fri, 22 Sep 2023 12:01:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=+xyd9IwCpJTRpcGWBwVDyX7y0WiRng0i7g5laRI0u+Q=; b=a7nW5ZyUwgPTbmBBG/6DK8XTnPAIoliMMHkEF53T74gvZWDxqCIxt6G3hYtpbUhSlpFO 9jetWeCqyzW8s3Lynom77Q8O32/H1THidrxZ+2VlB2EbbbxRkhPOL2EjsznBH2JyTg0o zrjnQm8JyI15gviy88leZR5xtX9lUN94SnUqKaeWSFIDZtV6S1YURT0dBe9Cn5u7feF/ CfKqKyjRnNCFhIIBIQhR/XGmteGdS6nbKug4UQDZgNmYu7YzoL8loDkb3KJxWursHt80 FOsyvZyxnSJv2O857S4CWeURE+Qc5CjG4AJmNhEZjboWNZNtabuAyEYRoyoIl134UiNU XA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t8u0hhsb7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Sep 2023 12:01:18 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38MC1G9V004544 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Sep 2023 12:01:16 GMT Received: from [10.216.15.173] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Fri, 22 Sep 2023 05:01:08 -0700 Message-ID: <45f96567-553c-9214-eb7e-c75c6e09d78b@quicinc.com> Date: Fri, 22 Sep 2023 17:31:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH V2 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574 Content-Language: en-US To: Dmitry Baryshkov CC: , , , , , , , , , , , , , , , , , , , , , , , References: <20230825091234.32713-1-quic_devipriy@quicinc.com> <20230825091234.32713-6-quic_devipriy@quicinc.com> <652b55cc-87dd-46d1-e480-e25f5f22b8d8@quicinc.com> From: Devi Priya In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: xy5DeM2VzxIyKi60wg7aWl-9oz9aGM_2 X-Proofpoint-GUID: xy5DeM2VzxIyKi60wg7aWl-9oz9aGM_2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-22_09,2023-09-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 spamscore=0 adultscore=0 suspectscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309220102 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 22 Sep 2023 05:02:11 -0700 (PDT) On 9/20/2023 1:50 PM, Dmitry Baryshkov wrote: > On Wed, 20 Sept 2023 at 09:39, Devi Priya wrote: >> >> >> >> On 9/12/2023 7:38 PM, Devi Priya wrote: >>> >>> >>> On 8/25/2023 5:14 PM, Dmitry Baryshkov wrote: >>>> On Fri, 25 Aug 2023 at 12:15, Devi Priya >>>> wrote: >>>>> >>>>> Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 >>>>> based >>>>> devices. >>>>> >>>>> Signed-off-by: Devi Priya >>>>> --- >>>>> Changes in V2: >>>>> - Added depends on ARM64 || COMPILE_TEST in Kconfig >>>>> - Added module_platform_driver >>>>> - Dropped patch [2/6] - clk: qcom: gcc-ipq9574: Mark nssnoc >>>>> clocks as critical >>>>> & added pm_clk for nssnoc clocks >>>>> - Updated the uniphy clock names >>>>> >>>>> drivers/clk/qcom/Kconfig | 7 + >>>>> drivers/clk/qcom/Makefile | 1 + >>>>> drivers/clk/qcom/nsscc-ipq9574.c | 3109 ++++++++++++++++++++++++++++++ >>>>> 3 files changed, 3117 insertions(+) >>>>> create mode 100644 drivers/clk/qcom/nsscc-ipq9574.c >>>>> >>>>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig >>>>> index bd9bfb11b328..3ecc11e2c8e3 100644 >>>>> --- a/drivers/clk/qcom/Kconfig >>>>> +++ b/drivers/clk/qcom/Kconfig >>>>> @@ -203,6 +203,13 @@ config IPQ_GCC_9574 >>>>> i2c, USB, SD/eMMC, etc. Select this for the root clock >>>>> of ipq9574. >>>>> >>>>> +config IPQ_NSSCC_9574 >>>>> + tristate "IPQ9574 NSS Clock Controller" >>>>> + depends on ARM64 || COMPILE_TEST >>>>> + depends on IPQ_GCC_9574 >>>>> + help >>>>> + Support for NSS clock controller on ipq9574 devices. >>>>> + >>>>> config MSM_GCC_8660 >>>>> tristate "MSM8660 Global Clock Controller" >>>>> depends on ARM || COMPILE_TEST >>>>> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile >>>>> index 4790c8cca426..3f084928962e 100644 >>>>> --- a/drivers/clk/qcom/Makefile >>>>> +++ b/drivers/clk/qcom/Makefile >>>>> @@ -30,6 +30,7 @@ obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o >>>>> obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o >>>>> obj-$(CONFIG_IPQ_GCC_8074) += gcc-ipq8074.o >>>>> obj-$(CONFIG_IPQ_GCC_9574) += gcc-ipq9574.o >>>>> +obj-$(CONFIG_IPQ_NSSCC_9574) += nsscc-ipq9574.o >>>>> obj-$(CONFIG_IPQ_LCC_806X) += lcc-ipq806x.o >>>>> obj-$(CONFIG_MDM_GCC_9607) += gcc-mdm9607.o >>>>> obj-$(CONFIG_MDM_GCC_9615) += gcc-mdm9615.o >>>>> diff --git a/drivers/clk/qcom/nsscc-ipq9574.c >>>>> b/drivers/clk/qcom/nsscc-ipq9574.c >>>>> new file mode 100644 >>>>> index 000000000000..65bdb449ae5f >>>>> --- /dev/null >>>>> +++ b/drivers/clk/qcom/nsscc-ipq9574.c >>>>> @@ -0,0 +1,3109 @@ >>>>> +// SPDX-License-Identifier: GPL-2.0-only >>>>> +/* >>>>> + * Copyright (c) 2021, The Linux Foundation. All rights reserved. >>>>> + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights >>>>> reserved. >>>>> + */ >>>>> + >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> + >>>>> +#include >>>>> +#include >>>>> + >>>>> +#include "clk-alpha-pll.h" >>>>> +#include "clk-branch.h" >>>>> +#include "clk-pll.h" >>>>> +#include "clk-rcg.h" >>>>> +#include "clk-regmap.h" >>>>> +#include "clk-regmap-divider.h" >>>>> +#include "clk-regmap-mux.h" >>>>> +#include "common.h" >>>>> +#include "reset.h" >>>>> + >>>>> +/* Need to match the order of clocks in DT binding */ >>>>> +enum { >>>>> + DT_NSSNOC_NSSCC_CLK, >>>>> + DT_NSSNOC_SNOC_CLK, >>>>> + DT_NSSNOC_SNOC_1_CLK, >>>> >>>> Not using the index makes it seem that these clocks are not used, >>>> until one scrolls down to pm_clks. >>> Okay, got it >>>> >>>> BTW: The NSSNOC_SNOC clocks make it look like there is an interconnect >>>> here (not a simple NIU). >>> >>> Hi Dmitry, We are exploring on the ICC driver. In the meantime to >>> unblock PCIe/NSS changes getting merged, shall we use regmap_update_bits >>> and turn on the critical NSSNOC clocks, ANOC & SNOC pcie clocks in the >>> probe function of the gcc driver itself as like sm8550 driver to get the >>> changes merged? >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/qcom/gcc-sm8550.c#n3347 >> >> Hi Dmitry, >> Just curious to know if we could send out the next series with the >> proposed approach if that holds good. > > The answer really depends on the structure of your hardware. The issue > is that once you commit the device bindings,you have to support them > forever. So, if you commit the NSS clock support without interconnects > in place, you have to keep this ANOC/SNOC/etc code forever, even after > you land the interconnect. So I'd suggest landing the icc driver first > (or at least implementing and sending to the mailing list), so that we > can see how all these pieces fit together. Hi Dmitry, Unlike MSM chipsets, IPQ chipsets does not have any use case wherein the NOC clocks have to be scaled. So if these clocks can be enabled in the probe, there is no need for an interconnect driver at all. The same applies to both ipq9574 and ipq5332 SoCs. Thanks, Devi Priya > >> Thanks, >> Devi Priya >> >>>> >>>>> + DT_BIAS_PLL_CC_CLK, >>>>> + DT_BIAS_PLL_NSS_NOC_CLK, >>>>> + DT_BIAS_PLL_UBI_NC_CLK, >>>>> + DT_GCC_GPLL0_OUT_AUX, >>>>> + DT_UNIPHY0_NSS_RX_CLK, >>>>> + DT_UNIPHY0_NSS_TX_CLK, >>>>> + DT_UNIPHY1_NSS_RX_CLK, >>>>> + DT_UNIPHY1_NSS_TX_CLK, >>>>> + DT_UNIPHY2_NSS_RX_CLK, >>>>> + DT_UNIPHY2_NSS_TX_CLK, >>>>> + DT_XO, >>>> >>>> As I wrote, please move DT_XO closer to the beginning of the list. >>>> >>>>> +}; >>>>> + >>>>> +enum { >>>>> + P_BIAS_PLL_CC_CLK, >>>>> + P_BIAS_PLL_NSS_NOC_CLK, >>>>> + P_BIAS_PLL_UBI_NC_CLK, >>>>> + P_GCC_GPLL0_OUT_AUX, >>>>> + P_UBI32_PLL_OUT_MAIN, >>>>> + P_UNIPHY0_NSS_RX_CLK, >>>>> + P_UNIPHY0_NSS_TX_CLK, >>>>> + P_UNIPHY1_NSS_RX_CLK, >>>>> + P_UNIPHY1_NSS_TX_CLK, >>>>> + P_UNIPHY2_NSS_RX_CLK, >>>>> + P_UNIPHY2_NSS_TX_CLK, >>>>> + P_XO, >>>>> +}; >>>>> + >>>>> +static const struct alpha_pll_config ubi32_pll_config = { >>>>> + .l = 0x3e, >>>>> + .alpha = 0x6666, >>>>> + .config_ctl_val = 0x200d4aa8, >>>>> + .config_ctl_hi_val = 0x3c, >>>>> + .main_output_mask = BIT(0), >>>>> + .aux_output_mask = BIT(1), >>>>> + .pre_div_val = 0x0, >>>>> + .pre_div_mask = BIT(12), >>>>> + .post_div_val = 0x0, >>>>> + .post_div_mask = GENMASK(9, 8), >>>>> + .alpha_en_mask = BIT(24), >>>>> + .test_ctl_val = 0x1c0000c0, >>>>> + .test_ctl_hi_val = 0x4000, >>>>> +}; >>>>> + >>>>> +static struct clk_alpha_pll ubi32_pll_main = { >>>>> + .offset = 0x28000, >>>>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_NSS_HUAYRA], >>>>> + .flags = SUPPORTS_DYNAMIC_UPDATE, >>>>> + .clkr = { >>>>> + .hw.init = &(const struct clk_init_data) { >>>>> + .name = "ubi32_pll_main", >>>>> + .parent_data = &(const struct clk_parent_data) { >>>>> + .index = DT_XO, >>>>> + }, >>>>> + .num_parents = 1, >>>>> + .ops = &clk_alpha_pll_huayra_ops, >>>>> + }, >>>>> + }, >>>>> +}; >>>>> + >>>>> +static struct clk_alpha_pll_postdiv ubi32_pll = { >>>>> + .offset = 0x28000, >>>>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_NSS_HUAYRA], >>>>> + .width = 2, >>>>> + .clkr.hw.init = &(const struct clk_init_data) { >>>>> + .name = "ubi32_pll", >>>>> + .parent_hws = (const struct clk_hw *[]) { >>>>> + &ubi32_pll_main.clkr.hw >>>>> + }, >>>>> + .num_parents = 1, >>>>> + .ops = &clk_alpha_pll_postdiv_ro_ops, >>>>> + .flags = CLK_SET_RATE_PARENT, >>>>> + }, >>>>> +}; >>>>> + >>>> >>>> [skipped clock tables, LGTM] >>>> >>>>> +static const struct of_device_id nss_cc_ipq9574_match_table[] = { >>>>> + { .compatible = "qcom,ipq9574-nsscc" }, >>>>> + { } >>>>> +}; >>>>> +MODULE_DEVICE_TABLE(of, nss_cc_ipq9574_match_table); >>>>> + >>>>> +static int nss_cc_ipq9574_probe(struct platform_device *pdev) >>>>> +{ >>>>> + struct regmap *regmap; >>>>> + struct qcom_cc_desc nsscc_ipq9574_desc = nss_cc_ipq9574_desc; >>>>> + >>>>> + int ret; >>>>> + >>>>> + ret = devm_pm_runtime_enable(&pdev->dev); >>>>> + if (ret < 0) >>>>> + return ret; >>>>> + >>>>> + ret = devm_pm_clk_create(&pdev->dev); >>>>> + if (ret < 0) >>>>> + return ret; >>>>> + >>>>> + ret = of_pm_clk_add_clk(&pdev->dev, "nssnoc_nsscc"); >>>> >>>> As we are switching to DT indices, better add new API that takes index >>>> rather than mixing indices and names. >>> sure okay >>> >>> Thanks, >>> Devi Priya >>>> >>>>> + if (ret < 0) { >>>>> + dev_err(&pdev->dev, "Failed to acquire nssnoc_nsscc >>>>> clock\n"); >>>>> + return ret; >>>>> + } >>>>> + >>>>> + ret = of_pm_clk_add_clk(&pdev->dev, "nssnoc_snoc"); >>>>> + if (ret < 0) { >>>>> + dev_err(&pdev->dev, "Failed to acquire nssnoc_snoc >>>>> clock\n"); >>>>> + return ret; >>>>> + } >>>>> + >>>>> + ret = of_pm_clk_add_clk(&pdev->dev, "nssnoc_snoc_1"); >>>>> + if (ret < 0) { >>>>> + dev_err(&pdev->dev, "Failed to acquire nssnoc_snoc_1 >>>>> clock\n"); >>>>> + return ret; >>>>> + } >>>>> + >>>>> + ret = pm_runtime_get(&pdev->dev); >>>>> + if (ret) >>>>> + return ret; >>>>> + >>>>> + regmap = qcom_cc_map(pdev, &nsscc_ipq9574_desc); >>>>> + if (IS_ERR(regmap)) >>>>> + return PTR_ERR(regmap); >>>>> + >>>>> + clk_alpha_pll_configure(&ubi32_pll_main, regmap, >>>>> &ubi32_pll_config); >>>>> + >>>>> + return qcom_cc_really_probe(pdev, &nsscc_ipq9574_desc, regmap); >>>>> +} >>>>> + >>>>> +static const struct dev_pm_ops nss_cc_pm_ops = { >>>>> + SET_RUNTIME_PM_OPS(pm_clk_suspend, pm_clk_resume, NULL) >>>>> +}; >>>>> + >>>>> +static struct platform_driver nss_cc_ipq9574_driver = { >>>>> + .probe = nss_cc_ipq9574_probe, >>>>> + .driver = { >>>>> + .name = "qcom,nsscc-ipq9574", >>>>> + .of_match_table = nss_cc_ipq9574_match_table, >>>>> + .pm = &nss_cc_pm_ops, >>>>> + }, >>>>> +}; >>>>> + >>>>> +module_platform_driver(nss_cc_ipq9574_driver); >>>>> + >>>>> +MODULE_DESCRIPTION("QTI NSS_CC IPQ9574 Driver"); >>>>> +MODULE_LICENSE("GPL"); >>>>> -- >>>>> 2.34.1 >>>>> >>>> >>>> > > >