From: Frank Seidel <fseidel@suse.de>
Organization: SUSE LINUX Products GmbH
To: Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [RFC 4/13] Char: nozomi, tty index cleanup
Date: Sat, 10 Nov 2007 16:41:43 +0100
User-Agent: KMail/1.9.6 (enterprise 20070904.708012)
Cc: linux-kernel@vger.kernel.org
References: <2351011721234832519.slaby@pripojeni.net>
In-Reply-To: <2351011721234832519.slaby@pripojeni.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200711101641.44700.fseidel@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 822
Lines: 21

On Samstag 10 November 2007 00:45:30, you (Jiri Slaby) wrote:
> nozomi, tty index cleanup
> 
> - don't store unneeded copy of tty->index into port structure, tty->index
>   is available everywhere
> - mod tty->index by MAX_PORT where expected (otherwise array index out of
>   bounds)
The last point i can't retrace, as all those parts were already IMHO.
NTTY_TTY_MINORS is just an alias for MAX_PORT, but of course its much 
better readable and also shorter. But i doubt this prevents to an array
index to get out of bounds ;-)

but all applied without a change

Thanks,
Frank
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/