Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <34cec699-4d4e-6458-d49a-ae6d572e0a58@intel.com>
Date:   Fri, 22 Sep 2023 15:58:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH net-next 2/3] ice: fix undefined references from DPLL code
 when !CONFIG_PTP_1588_CLOCK
Content-Language: en-US
To:     Vadim Fedorenko <vadim.fedorenko@linux.dev>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
        Michal Michalik <michal.michalik@intel.com>,
        Milena Olech <milena.olech@intel.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, kernel test robot <lkp@intel.com>
References: <20230920180745.1607563-1-aleksander.lobakin@intel.com>
 <20230920180745.1607563-3-aleksander.lobakin@intel.com>
 <e5022460-fc45-5571-1f5b-2b81f7811a7d@linux.dev>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <e5022460-fc45-5571-1f5b-2b81f7811a7d@linux.dev>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2xBUUY0M3lmTUNWL0I1TndsM1g1dHlobzR2ODR4VjhKZnpwRktqUjBwYmhE?=
 =?utf-8?B?VkpGY3ZjMjJMRmxSZ1pScGhDV3ZVTkt3M2JWRTN4eTVSdjY1T1EyNnZQOXZk?=
 =?utf-8?B?aVhkWm0vL0hURHhsYzgzSVM0bUJwOUt5N3RFT3pVUjlwUGMyUHpzajl4TDNl?=
 =?utf-8?B?UEdLYXJ6ajRqKzIzaWY3WW1VL3hJNklNY3c1ZlJUNnJSRmFkb3dmNy9Ua3NZ?=
 =?utf-8?B?YVV5djlBYlpTeFRQUmZYSHhVVHJZSFZzSmxKTWUzUXRZbG0rYTQxeUVJaFBi?=
 =?utf-8?B?TERVdVVFbDZKVElrVm1KTElpSHhpbTJmQi8wczB2STZRMGlOdlRmdTFGZUVt?=
 =?utf-8?B?K05McWs0WUQ0cW1PeUU4SlI1VHJQMUI4dU9WRytXRXV3SXdjYmVUWktwQmhW?=
 =?utf-8?B?UDh1UGNLa0FGKzJId29oS2VGdlpQRVRNSTlzRHBxcy9SOFVPK0laVzROb3FV?=
 =?utf-8?B?ekRNUWJ2NUwyMDNiYzRiSEdiVnI3UG43K2o3RGxKSHdEeGRRbHk4Sm80NnJv?=
 =?utf-8?B?ZGh5dWNsTloyUFBkMzNxSktwT3lyNjJGSStxb0cxb254djVVeHNTaUlvTkg4?=
 =?utf-8?B?SUZHcDFuS05KbnZDNE9YWVNrdmVoWTFyUmJuNEhIRWY0NDVMQmMwSmszc3Fv?=
 =?utf-8?B?eThBQWIzK2hVSWo3U2wrNEJEbGxtN1orWmxSTDd5Y053T0FtNnIrWEE1NE15?=
 =?utf-8?B?VnZ1VGgvY2V5UUZOZlpVeHpibmQrWm12TTdNdUpJUlYzS0NmMTZPMjhJL2lk?=
 =?utf-8?B?TnNTNS8xdXpTZVlyb2tZSFhMazVRVWVNK1Z4ejN2TlBNZlZEY0VpZ2gwczhC?=
 =?utf-8?B?SlBWVFdtM28rQnlqNDh4UXN2ZlByTmFmMmtTNG12V01ibGFIYzFZU0JFUW9s?=
 =?utf-8?B?TFFhUWJiNXBxT1pWK0JhSGxreDM2OWx5ZXBEQjluNVNjdVpkT3ZnbUJ6RHJE?=
 =?utf-8?B?MjVxeVJJcVNENENvUkhzbnFwajA1Yzk2Y05aMlVHUFZFUkZKTG1tZC9HNW11?=
 =?utf-8?B?WUd0ZWpqS2UyWXRudjd5VUFTM0QwOXFPMjZjbERaeitJK2pyVTJITUk1cEt4?=
 =?utf-8?B?YzdCc0xNQWRrdGNjelBRbCtLWFlKNGtYaThYTWlTSzFYVWpHZklaVFZWRkFB?=
 =?utf-8?B?VnBvM3pPVDFROS96L3hJaXZVRncwWEpyY3BvOWFXQjBIQzJSZ1dkNjROL2wz?=
 =?utf-8?B?TkJzTUhYQjA5WjZTWTUreDJMSGRlb2tWUTZXSmZrUWlxU1kwaWkxV1pFSW9s?=
 =?utf-8?B?eGZ3cGUwSnpITTd4R3pjRmpwOFFaWTVHRlY0M2hOTDZZYzkvclNGNGk5NzI0?=
 =?utf-8?B?QWtYUWJUQTMyenpKT2owMHNCcTBRMHlZRi9NMnY4UlBtUG9POGUzTE9jb0ky?=
 =?utf-8?B?ekFCREZkMDMwYlVwWC9KRC9iOU53bWJNUG1nZ3lCc25ZakRwRHhKNGNDUytS?=
 =?utf-8?B?cVM3WXU3OWRXQ3NCOXE0WVZVL2JNK0NpblNmNVFSM1ZSTXgwQ1EvSnQwQXI5?=
 =?utf-8?B?V0wwaGNZTDdpSWV2V3BRdEhXYXgySFdhVDN4N3pNQzQ2TFo5V244WEFReGhn?=
 =?utf-8?B?SWhJY3pEQ202a3dxT2VReDF4V0hWQXl4WXBSVUEvNjJ2VlFEbjZVUUx1NjlK?=
 =?utf-8?B?S0xvN0ZDR0ROclVSd3Z3STR5d051RVFCdlNuSURjenJxNDFqcWNyU0dkSkJ2?=
 =?utf-8?B?K251cmUwN2xJWGhaYW5XMlpBLzBKV3ZXY3hQbnlXY1hHUVl4RlNxRGtwZk9Q?=
 =?utf-8?B?dTVNYm8vVUdGQTRoMXpTa0ZNOFJBbHBsdGhuVnNSS3ZwYnVoSjlHM3NvYjdX?=
 =?utf-8?B?VE41N3NTanFESTNiRzVzYlMvejRZQ0Q1ZFVjaExvWmh0MUw1bzEzRnU2OS9j?=
 =?utf-8?B?YU9pVkIyUnVDa2ZkVkoxQjV2UTZ6eG1xMGY3ZG5zM29uS3BKTlo2V2hhRXZF?=
 =?utf-8?B?ZmxvOTBDdmRhck8wcFAvc3dRRnZ3YlcvU1VVREFrekhSWXNhRG54N2E1K2h0?=
 =?utf-8?B?MnFxZ0JaWHVRZzB6SzFxQm5ZT1NPa3AyZ1gybXVqc3kvVnBTaGN2dFV2ZjRV?=
 =?utf-8?B?bW5WdWkxT21zcDZzR3BTaktxS20zVlkyVzZGQ3BJRmZGcG54dEhoOGJGRk1G?=
 =?utf-8?B?andhUUh4L3J4UVlVNCsrYkMvMlVPUjdtb2NKaU50UVM1L3p3ekh4UkJldHNO?=
 =?utf-8?B?V3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 16b1c2b0-8c33-4b76-7131-08dbbb742d79
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 13:59:45.9057
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3e87Q7N8bZeGH+XjR0l4G134A9t7FSefpQSJgaoyP7PmxgriN8uByAGncWym3hZ7fdoOOb8lvEb66xxTiyudvevgYbcO6ZZsdyYYKTZLqPc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8500
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 22 Sep 2023 07:01:11 -0700 (PDT)

From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Date: Fri, 22 Sep 2023 00:58:04 +0100

> On 20/09/2023 19:07, Alexander Lobakin wrote:
>> DPLL code in ice unconditionally calls several PTP functions which are
>> only built when CONFIG_PTP_1588_CLOCK is set. This throws a good bunch
>> of link errors:
>>
>> ERROR: modpost: "ice_cgu_get_pin_name"
>> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
>> ERROR: modpost: "ice_get_cgu_state"
>> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
>> OR: modpost: "ice_is_cgu_present"
>> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
>> ERROR: modpost: "ice_get_cgu_rclk_pin_info"
>> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
>> ERROR: modpost: "ice_cgu_get_pin_type"
>> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
>> ERROR: modpost: "ice_cgu_get_pin_freq_supp"
>> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
>>
>> ice_dpll_{,de}init() can be only called at runtime when the
>> corresponding feature flags are set, which is not the case when PTP
>> support is not compiled. However, the linker has no clue about this.
>> Compile DPLL code only when CONFIG_PTP_1588_CLOCK is enabled and guard
>> the mentioned init/deinit function calls, so that ice_dpll.o is only
>> referred when it gets compiled.
>>
>> Note that ideally ice_is_feature_supported() needs to check for
>> compile-time flags first to be able to handle this without any
>> additional call guards, and we may want to do that in the future.
>>
> 
> There is another fix under review [1], which came from Jacob.
> It converts the code a bit more, and will create conflicts.
> I would suggest to drop this patch until another series is fully
> reviewed.

I know, I already explained earlier in this topic that I sent the IDPF
fix separately and that series can be dropped.

> 
> [1]
> https://lore.kernel.org/netdev/20230921000633.1238097-1-jacob.e.keller@intel.com/

Thanks,
Olek