Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2925331rdb; Fri, 22 Sep 2023 12:12:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6Zaeby9Ju2KN4t8PAturl0SyW3nB9ZdJd960L/ZvTG0eNiH6d1+v2uAefRotuCZx32e6Q X-Received: by 2002:a17:903:2289:b0:1bd:d92d:6b2 with SMTP id b9-20020a170903228900b001bdd92d06b2mr473439plh.10.1695409925893; Fri, 22 Sep 2023 12:12:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695409925; cv=none; d=google.com; s=arc-20160816; b=UhTFvuLfUCtXiBSETlHeOW4E20g7Knw/89asPYcl6friQg3gFvjfUlLCgROp83ZDhE i4xugvpY6e7BEACCdmg3+lvkfKc/manpLybdgNDsex8IyurfRXo9NXVR3uy03CIhOJCh r/2WM1YZXQKxzvCGBBjYzJjN7HTBsFnkL5cZ0UVaLfAlpUSWrkFuTDZv6QoV6JtVVmWL yO9XQCdGZSXpGtxaIi9kbzWdrz6+Wtxo6pJ/s2ndIMpfrA82YKerLEpzraYJm9G6xbOo Tb4jDWnNXHJUs6qmGX4124lOQs3JusikCveu5HCo7htmBKWmeN9oA+xzcfV9EktOUfXN +pnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Xyo5smHq1lcBrq86jPuYK6bRn55xTRRhvulYa+HVpfs=; fh=Ys9jzPqCIo4mWIR0yCvD1vTl3gqZfQtM68VrZn+e7Hs=; b=hDCHkD7bsvuuV7yzHYjyP+QQLjWzOBK0ZqOU10tn3A3CDEiGQRaem60HM1NUYgI8ZK 4ppEmofgililADsIsDMoCPN2/iEDP8ZeyPErsXEGXDHwVOCbSLOmO1OibZBcZJEBz9Bf VJzmlVtpn1HRLxfetNIMXKZUPUwS0ci5EAoCqTr7aGrZ1thvjE5H6wer7L8hyZpZibkd lwDntyg7eqBHkq8CT6/2pHoJ7rBYBYZz8vgYoB5ytbVYTdeV+n308ERVweyse6L9bIqv BKHc0EvnDVP5Tp+QgwOo2tIG9UIo7jUSqaw4BJWcwPjKBL2ln7vTCIoN/ugH2LiTLyqF MToA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id b14-20020a170903228e00b001bb3406a5f7si4543284plh.11.2023.09.22.12.12.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 12:12:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D81CC825A8FD; Fri, 22 Sep 2023 11:43:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233461AbjIVSnF (ORCPT + 99 others); Fri, 22 Sep 2023 14:43:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233267AbjIVSnE (ORCPT ); Fri, 22 Sep 2023 14:43:04 -0400 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 576D5A9; Fri, 22 Sep 2023 11:42:58 -0700 (PDT) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1bd9b4f8e0eso22204175ad.1; Fri, 22 Sep 2023 11:42:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695408178; x=1696012978; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xyo5smHq1lcBrq86jPuYK6bRn55xTRRhvulYa+HVpfs=; b=mu1LYgBbLF6JvDQ+ABMeylsdOKjFs61wks4E8TH/3WAZQRInMJfj+WcXaUkRDzIwHd QWSKERxMelZKJjqCAi9/qi0zn/Q/bLsjSCG8vQ1TGCBO0mpoJJcIKgXA9qDFcWqgKrFv e7kKrL5L8pl5as4JWl5t+WbwvaWQsCDUSC3wNQWbsRmTKBhkK5QnuWxmytLWmCAlQz1e c5UlsRFqDkeMcOnqSsm+b9AkS6pWrVxzPDUQhthEfjUc8ywfaCzzavltV0mTkjLwvfNl 5A91yvfyiAsI1nNGHVNhY38TcDnpI5pAZOkqpOounNQGOXzMjUAOkz1skihwcXFnslyi z2eg== X-Gm-Message-State: AOJu0Yxdphzl5WG3r3Ex8rmd1nHJ7xfZXribQwL5zcn15LffD7276KZC qw6wbqu8TQRZLFj7PlL5IKY= X-Received: by 2002:a17:903:22c9:b0:1c5:b4a1:ff6 with SMTP id y9-20020a17090322c900b001c5b4a10ff6mr357180plg.45.1695408177720; Fri, 22 Sep 2023 11:42:57 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([20.69.120.36]) by smtp.gmail.com with ESMTPSA id ja2-20020a170902efc200b001c0c79b386esm3846381plb.95.2023.09.22.11.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 11:42:57 -0700 (PDT) Date: Fri, 22 Sep 2023 18:42:14 +0000 From: Wei Liu To: Saurabh Sengar Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, mikelley@microsoft.com, minipli@grsecurity.net, ssengar@microsoft.com Subject: Re: [PATCH v2] x86/hyperv: Remove hv_vtl_early_init initcall Message-ID: References: <1695358720-27681-1-git-send-email-ssengar@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1695358720-27681-1-git-send-email-ssengar@linux.microsoft.com> X-Spam-Status: No, score=2.6 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 22 Sep 2023 11:43:19 -0700 (PDT) X-Spam-Level: ** On Thu, Sep 21, 2023 at 09:58:40PM -0700, Saurabh Sengar wrote: > There has been cases reported where HYPERV_VTL_MODE is enabled by mistake, > on a non Hyper-V platforms. This causes the hv_vtl_early_init function to > be called in an non Hyper-V/VTL platforms which results the memory > corruption. > > Remove the early_initcall for hv_vtl_early_init and call it at the end of > hyperv_init to make sure it is never called in a non Hyper-V platform by > mistake. > > Reported-by: Mathias Krause > Closes: https://lore.kernel.org/lkml/40467722-f4ab-19a5-4989-308225b1f9f0@grsecurity.net/ > Signed-off-by: Saurabh Sengar > Acked-by: Mathias Krause Applied to hyperv-fixes. Thanks.