Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2949370rdb; Fri, 22 Sep 2023 13:02:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIoY6ZiYzvAwrheQehk5OH8z6XvdvQepSglrW71VUPnb/J2VJmUNmiOTXrznHrLTJ8+X49 X-Received: by 2002:a05:6a20:3d20:b0:135:7975:f55 with SMTP id y32-20020a056a203d2000b0013579750f55mr542773pzi.47.1695412935258; Fri, 22 Sep 2023 13:02:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695412935; cv=none; d=google.com; s=arc-20160816; b=L41W5YiTvRuxC1PnlGh2MtYfiby1x2wvEDNB6xZMZcXFiiDFFDiwHgx8glJdhtRoar BAl9v5h0TFpi2ISnD5ztIQKXSmAOfRT1mJIvjjSxkgnaI2A1k85h8ldfCS2Mu/LdjsUV jWbUW5du/lUkjnw3kDoGl63TpmlaoE3Merw/kFDJchiVVeG/uY/EuDmeAtLDnUOb45nh fKci4nm6F8gXrJjyJGYuWeLEh/egzybQ+cb94YNO3dSa0tVcOYiveZs3R+IgfpHGBBzc VnmYaD7BZD7sJ6xvvm00rLtx21ov4Zqcwdq7yU7NxVze4HJTIEZUz4eWDPzXuft2cQn+ 0KNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hdkJCshrm7+2NA6hvRhWRajvLtyMYVnCdJT2DMlaAKU=; fh=osRuhd8ymWapU0IYvZgvh/1X4iBtq6oxDgJSeRwvD6Y=; b=HDc0d+Xb0+8korho6Zr1Dsoc2ie/LsTAznvKtaFKDp3Jgod+foP1JCw8ZTGPYKy35f dOSs7W1M/YV+zWjAA82/8mVZL6tOARHa//OyXGwQSw5wCvQQCrkguzgsnq5pAtrYIuOn NuoY1bOfpLAlQeiEzGirMiuPw78GnSauu/d59wqZ8rOWJvS23g8edClGtK05rMeE5ECg wH1rRjczZ0sWhsJBjLB5p+ynGcUuyj+/1RJOnNmhIl+wD2gbBp7lhXdTtc0MRYI8xLQO xf5cZcnjcEKF5omxEPT8RfiuixZ0r7wdrLBbmzahhjQPNY/25fmOM+HZimGSId9pWQr8 hasQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XNSLV3GM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id l62-20020a639141000000b005781afa41b3si4509602pge.152.2023.09.22.13.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 13:02:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XNSLV3GM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 12C8480658E7; Fri, 22 Sep 2023 01:50:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232388AbjIVIub (ORCPT + 99 others); Fri, 22 Sep 2023 04:50:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230126AbjIVIu3 (ORCPT ); Fri, 22 Sep 2023 04:50:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 204D9195 for ; Fri, 22 Sep 2023 01:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695372573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hdkJCshrm7+2NA6hvRhWRajvLtyMYVnCdJT2DMlaAKU=; b=XNSLV3GMOa5EZiQhUOqflzus9CSvl+KaGRQBICagyVVnOCjT1WoVJgiMheqn2TyTkdi7ai KdTZkx/ZQwfxlZ5sVcRSiCUdA11nGiYsoOganAmDAlAoEYThnwFQRTcjS2jL1+eJ8wRehQ 7Li6Ugf7PWVkIw3EAM7+rRKy8cxurBU= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-C71-KhJUPMejREfGGRZhaw-1; Fri, 22 Sep 2023 04:49:28 -0400 X-MC-Unique: C71-KhJUPMejREfGGRZhaw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CB7D11C06EC4; Fri, 22 Sep 2023 08:49:27 +0000 (UTC) Received: from fedora (unknown [10.72.120.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5BFA1140E950; Fri, 22 Sep 2023 08:49:21 +0000 (UTC) Date: Fri, 22 Sep 2023 16:49:17 +0800 From: Ming Lei To: chengming.zhou@linux.dev Cc: axboe@kernel.dk, hch@lst.de, bvanassche@acm.org, kbusch@kernel.org, mst@redhat.com, damien.lemoal@opensource.wdc.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Chengming Zhou Subject: Re: [PATCH v2 4/5] blk-mq: update driver tags request table when start request Message-ID: References: <20230913151616.3164338-1-chengming.zhou@linux.dev> <20230913151616.3164338-5-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913151616.3164338-5-chengming.zhou@linux.dev> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE, SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 22 Sep 2023 01:50:39 -0700 (PDT) On Wed, Sep 13, 2023 at 03:16:15PM +0000, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > Now we update driver tags request table in blk_mq_get_driver_tag(), > so the driver that support queue_rqs() have to update that inflight > table by itself. > > Move it to blk_mq_start_request(), which is a better place where > we setup the deadline for request timeout check. And it's just > where the request becomes inflight. > > Signed-off-by: Chengming Zhou > --- Reviewed-by: Ming Lei Thanks Ming