Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2954236rdb; Fri, 22 Sep 2023 13:10:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2Fyw40p8nf2shqXFAk1lWBd0eWSbwWoc76OFAZU9+faEyxpt+vMt++TyyVZZ+Hejk7sEv X-Received: by 2002:a17:90b:3b8d:b0:274:9a85:2596 with SMTP id pc13-20020a17090b3b8d00b002749a852596mr726778pjb.32.1695413458674; Fri, 22 Sep 2023 13:10:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695413458; cv=none; d=google.com; s=arc-20160816; b=t/cXVhYx5ep51itI3Ou+w7Eo/k0Yk45scy74mB+pON1fOzsZw19CizoWKNgheti1sG TAhDUhF+hDqRiY9P1rjwQV9AmZdvpeJhSsi6IkWIprywzhY2BNOSpL4kr88wOqCmKRbt mNuzA+kIe6tjxe1zhWQs3e141US2+7uNS+5wBF3UlBACSnsdHLnRMxa8yRS7DVckgaGI AK3kQaR4IXkY5WaXCdkX7JFdiroTkIKvgvt7+Cj+Scy7O5+EfmWuzLh2SaOUQ7IG156v Q7+JGD6e/+HX1tLU6jlY+HhzVkFPYXSWQ0Dbp/x6EU8tS+Hh6w/Gu/uAHCNDBkb4vfqD K1yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=zzYBqbpr2f4KdaQs/QxcNPl5NMLnkIHVs8JrqSeArM8=; fh=tP8C7miElearLKeNdwG7wVnRIfBv898CvgVsTTJjS88=; b=T8secwUSdcUnl5Myb9hzIIBabgoNvBeHlfda9u8hwfJFBkD3eiLAgrEswBPOkTyZNr LAjsSrS55en9P8Mx1FDHODGQcDVEpr3LJJ4HrErhxmSyxzKlRBxqhoBdGV+tDp+Hh8Lu 67etvXlpIogPf8lkT1qiLDNU0TBXUYrb8qIG+oxmy4iuITObH4wc95iPotJYvZqea0zC cTVq6Gs+VbEXgAQgLMmq6UJOyTBl+H+UFaAxi2XDVnDSXsa49AvKZ8m2tgyJHwHpBOmS 4vrViArWV2Ds3vB9ZLAhAA+0Vm/+Aez4uE1loqcMdCt6bxWgl+FMd6aJ3E9U1GT8Kgry jKeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kiXM0287; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id bf18-20020a17090b0b1200b0026b6a7d9e43si4428155pjb.14.2023.09.22.13.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 13:10:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kiXM0287; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id DA1888089871; Fri, 22 Sep 2023 13:05:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232511AbjIVUF6 (ORCPT + 99 others); Fri, 22 Sep 2023 16:05:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231222AbjIVUF4 (ORCPT ); Fri, 22 Sep 2023 16:05:56 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 443BB19D; Fri, 22 Sep 2023 13:05:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A31BFC433C7; Fri, 22 Sep 2023 20:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695413147; bh=enJ0a4l3BE0ZdLon+dFG8Kc9jkMHxADxQvNfxaqNXMw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kiXM0287PPQdGa5bf0h4KRkI3Lkad5vpLAI17WtUPjhwPwb14rW+qiyUSHHQPPwhs qSbatTXAbEpqSgl5MKmO00NTvE8TGgrMXAFuLTnZnPLF0Yrz1d+J4NWeIfPUanzO5e T5iWhVMpxBSj7pKeuCuHI7w79EdripfbxhTBIRP6f7IicL766JUMaTgGd12uBy+EtO lT54AiQM/yImBjxzuTASYLD8VptwnRZhauIdxnl8mWt5NifTHRzAhe/lmGHvtRx5A7 z110J/Ak1gHj8zWPa3KtJdlEzRzFzlfYbfRRe5qnkJogfxMWqiQeRsu1RQhfEzFMDp 7bJB7APq8QNuw== Message-ID: <55ab5197-51ba-87bf-e24d-44ebc45f13d7@kernel.org> Date: Fri, 22 Sep 2023 13:05:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC] ata: libata: increase PMP SRST timeout to 10s Content-Language: en-US To: Matthias Schiffer Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <6309e45e-b1f7-0167-ff54-f1a86437a910@kernel.org> <1ed7c4dc-f026-4ac5-2011-afcdb1e962b0@kernel.org> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 22 Sep 2023 13:05:58 -0700 (PDT) On 2023/09/22 12:41, Matthias Schiffer wrote: >>> Even with the latest series applied, I still need my >>> ATA_TMOUT_PMP_SRST_WAIT change to avoid the "softreset failed (1st FIS >>> failed)" message (and get "softreset failed (device not ready)" instead). >> >> OK. Thank you for testing. >> For increasing the timeout, please send a proper patch. I will queue it. >> >> > > Will do. Do you see any downsides to the increased timeout? Otherwise, I'd > simply add a Fixes: tag for the last time the timeout was touched in > e7d3ef13d52a126438f687a1a32da65ff926ed57. No, I do not see any downside. Most drives do not need such long timeout for replying to a reset, so it should not be an issue. Increasing to 10s should be OK. But please be sure to mention in the commit message the adapter and drive you have that need this, so that we keep a trace of it. -- Damien Le Moal Western Digital Research