Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <f2527191-281a-72e1-2dfe-c2d96c8f81b7@intel.com>
Date:   Fri, 22 Sep 2023 08:07:42 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH v2 6/7] cxl/memdev: Fix a whitespace error
To:     Jeongtae Park <jtp.park@samsung.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Fan Ni <fan.ni@samsung.com>, <linux-cxl@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kyungsan Kim <ks0204.kim@samsung.com>,
        "Wonjae Lee" <wj28.lee@samsung.com>,
        Hojin Nam <hj96.nam@samsung.com>,
        Junhyeok Im <junhyeok.im@samsung.com>,
        Jehoon Park <jehoon.park@samsung.com>,
        "Jeongtae Park" <jeongtae.park@gmail.com>
References: <CGME20230922113350epcas2p230c0ea8019d20f8ae8d246a5566d3a64@epcas2p2.samsung.com>
 <20230922113636.3301482-1-jtp.park@samsung.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230922113636.3301482-1-jtp.park@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0VTRlF5eTRpNlVyYkt6RngvOFhaTXFmME13d3VIazh3RzFOTGk2U05zSEdO?=
 =?utf-8?B?alhZL1NhajBsNEdFK0FWSTVJaDNIYWFGQ1djRGJyOWVPWmZzRkJuZkNsK1Bj?=
 =?utf-8?B?eVlJTlZ2U3BscG5lMDY4UUY2dzh5cHVFWDAxV24yVmVLZFZUd1RxZHQwZXpS?=
 =?utf-8?B?NDBLeWMwZVFKMHhiWWt3eGs3NWFsaHd4UzFpU1M1Zi9WcUVPT3lYc09HS2pM?=
 =?utf-8?B?UnZFRFplOVFmS3YxZStFNTRtMkp6ZWQwaUwyY3dWV1NsL1ZML01jdWNVekNs?=
 =?utf-8?B?MzloMmE2dEtjVTg4ekJ3aFcyVXd0anIvSmNCYlBHYXhtTW94UFRpdlpMVkRp?=
 =?utf-8?B?c0JuMWtnUk9USEJCVjVqOTg4bnFaK0grdUczVFZKWnJxTVM2RlVBRnBlRCtZ?=
 =?utf-8?B?YVkxNHZ3YnVMVnlGcmFZNkwvaFozNU85ajN5dHJ0WVF6N1ZWWkpxY3VDbGZB?=
 =?utf-8?B?ZmVKTlg5NFFmVW9xWnNheWVVRVFPWDkyazNwdDBaM25zbnRNR1RtM2lLZ1FQ?=
 =?utf-8?B?amN2T2FwQXNnYzBob3phWDV3cmIvWDZvS0NSd0pLOTdGT2tuNGpxODZ3ZElJ?=
 =?utf-8?B?T0NNNld4WUV4eFpZVGxOT1FtYU8rNGZHSmNZb1hINlBjSFQzTTIrQ093UVBS?=
 =?utf-8?B?RHhwTEFydnU2SjdyN2wzSkJUOFZPVDZaUXpFLyt5Y3dkOHpjQkVMaWxNTG00?=
 =?utf-8?B?T1pvbVdrcHdQdnMxT0tBWFdPL3N5Zms4U3dnQk14UEFEcjdJTW1iSitUUFZK?=
 =?utf-8?B?K2ZJVURsSkN2TDUzb1FwYmdZL2lJT1g5c3JHZ1dDd3FNOHFUZW53T1lwWS92?=
 =?utf-8?B?T0plU2djbkphOXJhelNLK1VIUHg2UGtVeDRvY2FtbUZQTGpsajYxTXZhMkdr?=
 =?utf-8?B?YUpNRkdrZTRMb085TGFTUXJxbXJiazI2OExibjdUYWJhK2dkOFZrdTJpTWdY?=
 =?utf-8?B?M2Y0aU00VXFBeitqTU0rb0NKOXZNNVdVNUZZMGpQaWxDVjVVT3RGYm9uQXdi?=
 =?utf-8?B?NjNwbng2ZzV6L1NFRFE3RjNpMTJnT0Izbm9qbmFxUnBZdkg2V2x3dEo3bGxU?=
 =?utf-8?B?MHpFTFdYbUxUTlZsdnEySnE1N3M1SHU1YnVOK0VWdHN2R3hmSHlUYm4rRjdt?=
 =?utf-8?B?dTFjeXJ2N0xzT2tDUnZjcy9HNmZ3SUY5NXZSTFVzRE83QW9MNUtjaU5iQVU2?=
 =?utf-8?B?S3MxbHA5ang4M2tkZmxCdkt2OURxN2pIL0xyZWxUZk5iaVFTVXZsNC9DUFdx?=
 =?utf-8?B?RGZ4Z1RQZzRrYWxtT21FZ1BPZy9KVi9WK1RZR0l5TWRRSTFIQWxxZS9DdUVK?=
 =?utf-8?B?b3FCSUJyWVl1QmljZlVpYlRvZXoyOTdxeTlKaEtEb1NCQkw1bnlVbmFDUWRS?=
 =?utf-8?B?UDMwdTBodWg2ZFdBM0ZNS1dTQW54WWxkMTdqY05GZ2Z6Y29OOE54S2dlRnFW?=
 =?utf-8?B?M0twRTdkVGRYMGVlNk41Q0ZxYXFBYm05T0pkRzdaRCtvY25zZHNmTkZ1Qjl1?=
 =?utf-8?B?NVFHWjZUaDZPRnQ3TXJXNWFXUGVnenYyZEc5K1VmdkUxa3dHMlgwbG02ZGt6?=
 =?utf-8?B?YThMV0x0YU5MYlJ5MDQ5SmhKTmlmUElUZng2VU1UeUk1MEVrVFJJVnVLWkNs?=
 =?utf-8?B?VHpWUTQwQmc3ZDVnTGErZyttUmJDTzFrM3hrVDRxR21YdGJodzJMbGVRYWZP?=
 =?utf-8?B?YmFwNUhFak42Q1ZjSG13RlZQY0xEQ2xKU2VBbEJjYTg0a1F0K0RBMXZhUVg3?=
 =?utf-8?B?d3kvbjN1Q0NLMGtGL0hNZlJVUFpnYytFV29mT0xnSkMxMW15azE3SUlLUjl6?=
 =?utf-8?B?T3hGbXczTjFoS0Rhb2RuV0ZabHorTWk2V0tud3FPT3B4QjgwV1ZlTWFXSDE5?=
 =?utf-8?B?dE5GWFhHQjBqNnN1aDc4L2ZzY3Z4NThlWnhST2xya3RocnBEY3cyQ0J0VlRk?=
 =?utf-8?B?Qkg1eG93UHI5djlPWDkrZnV1QjU1YUpHSlZORWgxWFdsbUlXNjlPRlpmYU44?=
 =?utf-8?B?QWVGMTFnU0NtZlIzNXpiWnI4YVh3NUd0RW85WlNYQ3hXd2p6RUJ4NHA2RGg1?=
 =?utf-8?B?cWxVZ2tXRGRLbmxrdFBDZ1NHcWMxWGM4WFZub2J6emNuemsxTmlvNHVQakJr?=
 =?utf-8?Q?MMekiFFyg5G65Hts+qVLn10sn?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d527c96f-42a3-47de-2d2c-08dbbb7dae4d
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 15:07:47.5043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yZQsz//XSAPRpuFGCmM1CL+2bKHW2upOa9dYYdTtK3UG/vW2TctjrtJ2EqYw+ee2emcuYp8z6FExDwhxnWy72Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7931
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 22 Sep 2023 08:08:46 -0700 (PDT)


On 9/22/23 04:36, Jeongtae Park wrote:
> ERROR: code indent should use tabs where possible
> 
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/core/memdev.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index f99e7ec3cc40..7e8fca4707c0 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl)
>  }
>  
>  static const struct fw_upload_ops cxl_memdev_fw_ops = {
> -        .prepare = cxl_fw_prepare,
> -        .write = cxl_fw_write,
> -        .poll_complete = cxl_fw_poll_complete,
> -        .cancel = cxl_fw_cancel,
> -        .cleanup = cxl_fw_cleanup,
> +	.prepare = cxl_fw_prepare,
> +	.write = cxl_fw_write,
> +	.poll_complete = cxl_fw_poll_complete,
> +	.cancel = cxl_fw_cancel,
> +	.cleanup = cxl_fw_cleanup,
>  };
>  
>  static void devm_cxl_remove_fw_upload(void *fwl)