Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <8a4a6e1f-accb-92c2-ae14-9f6945e97f7a@intel.com>
Date:   Fri, 22 Sep 2023 16:40:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v5 0/5] Implement MTE tag compression for swapped pages
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Alexander Potapenko <glider@google.com>
CC:     <catalin.marinas@arm.com>, <will@kernel.org>, <pcc@google.com>,
        <andreyknvl@gmail.com>, <linux@rasmusvillemoes.dk>,
        <yury.norov@gmail.com>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <eugenis@google.com>,
        <syednwaris@gmail.com>, <william.gray@linaro.org>
References: <20230922080848.1261487-1-glider@google.com>
 <ZQ2mJ9rK7xNoMykL@smile.fi.intel.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <ZQ2mJ9rK7xNoMykL@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yi9LeFBVVkpFY3djUFJGa1MrUjY3eGtoeXhERUVscS95N3NIQW9ZY2ZaVDVZ?=
 =?utf-8?B?amtiOTY3WjNTcXZpQi9RME9XT29TeWJPU2JDNVRSelVHY2lrUG82WUpQUzVi?=
 =?utf-8?B?NWl0QkNzU1dXSktDSENsWUEwaExHTnF4a1ltRGZqaGhzSjdhUmZ1M3BIU3Yy?=
 =?utf-8?B?WFNVLythOWtZWTRJdzZpeVR6QXVIYmREcVVhdktFaTE3QTZZREpJK2JQVlRP?=
 =?utf-8?B?YjdtbjF2V1NqbUxDdXlGUUZuVEIwditWeTRqTG9IQUtCMDJKTWhpT0dELzhP?=
 =?utf-8?B?R2xpVEtvTTFieUpidVF1V1JVcGlQOWlqTEdWMTNhaGtubmdXR1d2cXdicTFo?=
 =?utf-8?B?emdxMGlncytFRWZXV0I3bG5VczFka1owM1BnQVRBQ0Ftajhsb0lsbDZEWnBG?=
 =?utf-8?B?bUJGc29WWm5xSFBDK1JJV2dBd21XUzJTTStyblI1Lzc2OGxuSE50Tmlia1ZF?=
 =?utf-8?B?d0xseGNzcEhQeE5LRHNXaHZpWGNRMFV4UDF2RndnS0VUV3JpK0puSXRWcStx?=
 =?utf-8?B?Z0N5OVJaVHpqTSs1UzJQZ3F5aDNxK1NSUjNrTkpRckl2ajRTc1NwTUphWXE4?=
 =?utf-8?B?R1Bid3VBSHB4dTFvNFFNV09ZRjMydFJibFBMelVudGhrSTRxdHZ6UE84ZkZp?=
 =?utf-8?B?U2YvcHdzb2NpWjg5eUdzNjhLUFVvQkxUOHlkU0dOSUp3VlVNREh6ZUUydmhu?=
 =?utf-8?B?VzRJcGZ0MkVDTW1ycHBNcVlSTXdqeEgzQ2NpbSs4eEFRV1NRQ1psaFprYnRY?=
 =?utf-8?B?eTZZRzc3YitLQ0twMkdIQVFnT293QWdRRWIzRkNLOTY2bTFWWHpIckVFZmZQ?=
 =?utf-8?B?RUNpZEgyL3VibFR1SGdyVWh0MjRtT3Y2bDdaTE02YmswUER3SUR0WmovRSti?=
 =?utf-8?B?R0xrN3AzZnk3OHNTZkdLNmwzWWRsczhsTlBaelczVU5iNS9YY08yVksxNEoy?=
 =?utf-8?B?YktrRG50VHorT09NajUxS1VkOTgwQ0Yxb1l0RXY0S1JDdi9ld3hUMVdiall0?=
 =?utf-8?B?ejFRbjJ6VVZERGRsRUg2T252dFIzMGZGSnhvQ2hZd0Z5Mmpwc1BFeWoxY25n?=
 =?utf-8?B?b0VoSDkrdjNtNHIwNFVDNW9kc1dtOWNQZ0dVR0Q4SFdsRmtaTGFoR1c5UTBG?=
 =?utf-8?B?UzFHcVNyZVd0ZmE3WCtYNVNtdExFTlV0TTB2NUNObHdRM1BuSFV5aUVPcjFN?=
 =?utf-8?B?a3h0R2M3RHJ1SjArSVJVQmtoQ3lIaFNOQUs3VW9laWljUS9hN0Q4aXBEVnlR?=
 =?utf-8?B?V3hZbGlob1FqNElHKzFCaFR3SndJdTVseFNYekt4eUtqbTA5NEgvMnErWkR3?=
 =?utf-8?B?dnNMbEc5RDVmNzZjYzR0ZVR6dzRvbTR1bE41ZmJna2ZUSTNuWDlOOWRlRWRT?=
 =?utf-8?B?SDRhSzlFeXAxdVR1NldnVGdJRUdseUM5SzdrckZyYzkydTJNd3VKdmRvUFpa?=
 =?utf-8?B?OFVIWWZyZ0FlU1ZiRVRmb2psLytuWUphell5aWExMmtZT0xPSEV3Yk9ZVDlt?=
 =?utf-8?B?eHNHVUVMaGtLck9CcjlnQVBXdGxhTnRLa2xETWRML29YSVpLK2NLKzhpRXZa?=
 =?utf-8?B?djlxQWVsWjRPOXlTUTF5SkdEQlJzSlZ0NUlvS05lTmprSUE2UWpmanNqZkU2?=
 =?utf-8?B?VW5BVnpXd25UcFN1QnloWkdzaWJycndDbkloaVdqRC9jclBXVFNPYVF3OTht?=
 =?utf-8?B?Y3BzbUNwUkZ5QVN6U0pPd1BQeFZzcC9WN1NmSW45YTBDWENkOExreWpMSG5E?=
 =?utf-8?B?K3ZqTHA5U2MvTEhzQXBSVUtRUGhoNWZFNitxNWh4OVRQaitLc0pqZU1aQ3hx?=
 =?utf-8?B?S0d5cUpUWldJa3BLdE5CcnlKbUphTUVNVWJaZ3dIN21Xb3ZNRm1XWTRDcDY0?=
 =?utf-8?B?TTRPTy9kN0ZiNU5UUkRwakt0NmxPOXJLNU8zK01mWUVlSHd6OHZUZ2dyY21P?=
 =?utf-8?B?ZDVlNzJEbm1aSjFkMC83aytmaEhsK3kzb3g2UU5WQmtBWmsvNHUveDMvOUMx?=
 =?utf-8?B?UzNORmsvMEQzUWVnZ3RpY0JneUk0MUpGdGxCMW1SQlkzU1FDVnl5RlNVeEVx?=
 =?utf-8?B?SVhqRFhQRU42ZEdvTVZlOS9WdnlNb1YrVllHZjh6TitHQ2hNRDhLL2tsZHBz?=
 =?utf-8?B?M0V3emxTV3ZtM0tlVi81NFNuWnRXVHpRN3JNNU1DZWtvUEw4akx5Mkx2MjR4?=
 =?utf-8?Q?+HO4aHIfUcG0go5QkpysX6g=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 086a736a-ec92-4f36-77bb-08dbbb7a01bc
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 14:41:29.4599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bcwW7Zk3yB9gSj8cf31eX7XHBjam4tYHuMMre8fol2rwi/kWJcPP2Hl7o5lBvvbeuq2if0zq1u9Xl9nChsaoHqLM4dq+gmrqRRP0cPV7pPk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6456
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 22 Sep 2023 07:42:27 -0700 (PDT)

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Fri, 22 Sep 2023 17:35:19 +0300

> +Cc: Olek, who internally is being developed something similar to your first
> patch here.

Oh, thanks.
The patch you mentioned properly implements cross-boundary accesses,
mine does not :D
But I guess we want to keep them both to keep the latter as optimized as
the current bitmap_{get,set}_value8()?

> 
> On Fri, Sep 22, 2023 at 10:08:42AM +0200, Alexander Potapenko wrote:
>> Currently, when MTE pages are swapped out, the tags are kept in the
>> memory, occupying PAGE_SIZE/32 bytes per page. This is especially
>> problematic for devices that use zram-backed in-memory swap, because
>> tags stored uncompressed in the heap effectively reduce the available
>> amount of swap memory.
>>
>> The RLE-based algorithm suggested by Evgenii Stepanov and implemented in
>> this patch series is able to efficiently compress fixed-size tag buffers,
>> resulting in practical compression ratio between 2.5x and 4x. In most
>> cases it is possible to store the compressed data in 63-bit Xarray values,
>> resulting in no extra memory allocations.
>>
>> Our measurements show that the proposed algorithm provides better
>> compression than existing kernel compression algorithms (LZ4, LZO,
>> LZ4HC, ZSTD) can offer.

[...]

Thanks,
Olek