Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2974823rdb; Fri, 22 Sep 2023 13:58:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDKo87HOYHofjJk2RAW5rnLdJ0sVo7smdqiKnE3WvvbLF0WOMth25aq8M7cIhsfefBsMSF X-Received: by 2002:a17:902:9a01:b0:1bd:f7d7:3bcd with SMTP id v1-20020a1709029a0100b001bdf7d73bcdmr478331plp.50.1695416317977; Fri, 22 Sep 2023 13:58:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695416317; cv=none; d=google.com; s=arc-20160816; b=rC2l6GHFbYBzR6znmVgtJRfFa3IqR1dZgtPYpU1bU+i2nnvOrEqw3iuxKZ/G27gxB0 wk2Q9BIVU+iE4aG/OpIc9OqqsmCG3+Ay/THQWDO7N7DNftq50A07MIRP+Y+TXTxbX4GZ cVq0cYkureayMNyrF0WRw1RLmpA+aLH2hzmceEKoXKar6sl0vOLPNTrDJJNwRrKlQj7G YSqNeCD8CFNGjPts9o/S2l3PR2IkWpDDmC3zxHuz2A+nGoywYrcda0/MsOrPcIrVYohM WX43FBWl2jxcx67v2VY066o8X9lNDArAyPXuKDohpSzdWHpY5EV2bsGx6xV+nNFtvT0U VBig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Kr0odj6JhUT/TJpT6+hnZVphvzB0F4cClELpGdwr1V8=; fh=OksKZZNI/daotvGVtww+Km6gP/vutqq/7dfNFb+UU1Y=; b=uVBczk/hqwN3eEnnOilarXoDi/wfdYmwUwRV4dAJGrYYewK8EbHSl4qMzzT9UuFCkc 4Prmnchne5wA46oE7Dh6q4hg5wd5hNZXytwTvU5D+W0j0g/N75EUxCZyp4GfP0t7KaFB 7x/9WYQQLk7To4EeQO8IoG0Zjk4wSqZ1WEzcc2lGRY4EcCXhUA03phNjMmS59Ltd92dg lVn79ZiSfe3XTKSgrv78lV2oslWZcTCQfbHJUZjUQnUu+kXT65W2ImIsKaJs2hcomq71 EZPttMAr6fyys5DdTG2evTt8yQ+ws9xzAiQ6U5D9mbH7hL1gLAnMMY8Lse6fAZfo/zAA CTHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id km7-20020a17090327c700b001c4640de545si4183912plb.48.2023.09.22.13.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 13:58:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 195BC81A9B74; Fri, 22 Sep 2023 13:56:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229678AbjIVU4Q (ORCPT + 99 others); Fri, 22 Sep 2023 16:56:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbjIVU4P (ORCPT ); Fri, 22 Sep 2023 16:56:15 -0400 X-Greylist: delayed 16653 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 22 Sep 2023 13:56:08 PDT Received: from orthanc.universe-factory.net (orthanc.universe-factory.net [IPv6:2001:19f0:6c01:100::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE379CA; Fri, 22 Sep 2023 13:56:08 -0700 (PDT) Received: from avalon.lan (unknown [IPv6:2001:19f0:6c01:100::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by orthanc.universe-factory.net (Postfix) with ESMTPSA id 66F891F5E2; Fri, 22 Sep 2023 22:56:06 +0200 (CEST) From: Matthias Schiffer To: Damien Le Moal Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH] ata: libata: increase PMP SRST timeout to 10s Date: Fri, 22 Sep 2023 22:55:16 +0200 Message-ID: X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 22 Sep 2023 13:56:25 -0700 (PDT) X-Spam-Level: ** On certain SATA controllers, softreset fails after wakeup from S2RAM with the message "softreset failed (1st FIS failed)", sometimes resulting in drives not being detected again. With the increased timeout, this issue is avoided. Instead, "softreset failed (device not ready)" is now logged 1-2 times; this later failure seems to cause fewer problems however, and the drives are detected reliably once they've spun up and the probe is retried. The issue was observed with the primary SATA controller of the QNAP TS-453B, which is an "Intel Corporation Celeron/Pentium Silver Processor SATA Controller [8086:31e3] (rev 06)" integrated in the Celeron J4125 CPU, and the following drives: - Seagate IronWolf ST12000VN0008 - Seagate IronWolf ST8000NE0004 The SATA controller seems to be more relevant to this issue than the drives, as the same drives are always detected reliably on the secondary SATA controller on the same board (an ASMedia 106x) without any "softreset failed" errors even without the increased timeout. Fixes: e7d3ef13d52a ("libata: change drive ready wait after hard reset to 5s") Signed-off-by: Matthias Schiffer --- include/linux/libata.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/libata.h b/include/linux/libata.h index f217327a779c..7c3e591a5fc9 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -256,7 +256,7 @@ enum { * advised to wait only for the following duration before * doing SRST. */ - ATA_TMOUT_PMP_SRST_WAIT = 5000, + ATA_TMOUT_PMP_SRST_WAIT = 10000, /* When the LPM policy is set to ATA_LPM_MAX_POWER, there might * be a spurious PHY event, so ignore the first PHY event that -- 2.42.0