Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2976977rdb; Fri, 22 Sep 2023 14:02:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBUJrtnIvmg2tMksXPSMzpt5woTUWVFTb1N6sGvzF3aueUhTqBV5bk5fqBen9qsQ3qU0cX X-Received: by 2002:a05:6a21:a5a2:b0:13f:65ca:52a2 with SMTP id gd34-20020a056a21a5a200b0013f65ca52a2mr780131pzc.5.1695416544142; Fri, 22 Sep 2023 14:02:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695416544; cv=none; d=google.com; s=arc-20160816; b=AwXMmxUGrewAoAQEgvGh+k9Alh5KWGv32f2QS2UTcU7SOLbMaEIFdUq6fGMjkid9zP k11AiZfgIIW0Af2aHGVmYqSWl9TOudcHnK0FC6qnejduYO1RaRyIcto0sMQKmuCYO+Yw RN5LdwRdJpFsxyVUmyHkar0flG55LiGuGwDhbv6dVr3PgrkwOkyr0mVSuogLVnqGlXdH eWC1Z1EoSlkDzlL2cMiLBUQ1JdzVqSaGnKal1NR1gIq8h2wYW4kVQ8TgzPi+cagOpxtp pe6qnVgG+vWmOTspMZaXJYat89IPfD2kTlzZ8JBQqBMxsd7oBumgc46bZuPJ+A7JVgoY A5Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=Opx6dAlM/IbsWqR32g+NmII+tBb3IBm0l1al56npJMk=; fh=stmSkAvucvK5TkBdnwJhqOsIY+3LxKSNU/hD0a8xyRw=; b=fOqUZVH+jhpcoj99513A456sRkj8acYDulK6sG8/ytNcmwKqFjWBHAGB6wzat7N6o0 SOaVBkjv7nyWhTrWIaB1td5pZkN9VZKHa8fumNB0u6iR3Kt3NCn32UJGxy56GD6TeFjn 785BcKSC++D3QnnDzMwLbgcIKXv0lIPnVNsNMITjxuGOWTwlUIvY6klE+Ynq8HUTq6Ud P26zopTwBJ6YM7AQbyqVRWjlLJWiPrj5bYDGufuFQFLLbiYjWfp3ELvDJfekvAAn1Is1 PDPyTTcACWc+wFGXFXBfqczirdmaCKsjU9uf/Zh5B0B8IXv7UzbVHti6OQIAfAfSWXro Yo7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=gAbPPTK5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id s132-20020a63778a000000b00578cc95d3fbsi4659099pgc.635.2023.09.22.14.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 14:02:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=gAbPPTK5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 310628080D44; Fri, 22 Sep 2023 04:46:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233764AbjIVLqA (ORCPT + 99 others); Fri, 22 Sep 2023 07:46:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231284AbjIVLp7 (ORCPT ); Fri, 22 Sep 2023 07:45:59 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71B06FB for ; Fri, 22 Sep 2023 04:45:53 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:d3ea:1c7:41fd:3038]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id B27F56607298; Fri, 22 Sep 2023 12:45:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695383152; bh=MoMkptljEz1wEeXfbVsyAz0hGh9sZ9dJCPGyUcLkgRM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gAbPPTK5nC9/gENoEpD7H/GLKGT/0Pcigwu/MkVfY0HfBH2bL8qQxy1nJlZnGBEF9 uKKMPY9G/lHfxFLQYMWoIEJKAD0ws61WQazeiOjgwWdxgYcxMq1r6hZyi0F92SmVZM IRX4XA2QGGebm67C1Cozt8DurmVxShzeVzF3Zhw3BnJbmfNHAIMIUbXRtKL/xtcCrH 8MVM0+BCGRax5aeXfo/ztZCLyPxarp1e+wIISHSK/h/Cc/TU+4IEt9AShp32sR4FWq oKmmtj9rx0LwnJHZPSN8CFbtfI4gykvk3fDs2Da65SCrY7OEtdLU8uXDHUh+qd4I6Q kv4XMgooNOXpA== Date: Fri, 22 Sep 2023 13:45:48 +0200 From: Boris Brezillon To: Danilo Krummrich Cc: airlied@gmail.com, daniel@ffwll.ch, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, sarah.walker@imgtec.com, donald.robson@imgtec.com, christian.koenig@amd.com, faith.ekstrand@collabora.com, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH drm-misc-next v4 7/8] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation Message-ID: <20230922134548.7ede67c0@collabora.com> In-Reply-To: <20230920144343.64830-8-dakr@redhat.com> References: <20230920144343.64830-1-dakr@redhat.com> <20230920144343.64830-8-dakr@redhat.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 22 Sep 2023 04:46:03 -0700 (PDT) On Wed, 20 Sep 2023 16:42:40 +0200 Danilo Krummrich wrote: > + /** > + * @DRM_GPUVM_RESV_PROTECTED: GPUVM is protected externally by the > + * GPUVM's &dma_resv lock I think we need to be more specific, and list the fields/operations that need to be externally protected when DRM_GPUVM_RESV_PROTECTED is set. > + */ > + DRM_GPUVM_RESV_PROTECTED = (1 << 0),