Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <51ff0094-5c7b-824b-8b3c-2439e5477725@intel.com>
Date:   Fri, 22 Sep 2023 10:59:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v10 10/10] x86/resctrl: Display RMID of resource group
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>,
        Babu Moger <babu.moger@amd.com>
CC:     <corbet@lwn.net>, <reinette.chatre@intel.com>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <paulmck@kernel.org>, <akpm@linux-foundation.org>,
        <quic_neeraju@quicinc.com>, <rdunlap@infradead.org>,
        <damien.lemoal@opensource.wdc.com>, <songmuchun@bytedance.com>,
        <peterz@infradead.org>, <jpoimboe@kernel.org>,
        <pbonzini@redhat.com>, <chang.seok.bae@intel.com>,
        <pawan.kumar.gupta@linux.intel.com>, <jmattson@google.com>,
        <daniel.sneddon@linux.intel.com>, <sandipan.das@amd.com>,
        <tony.luck@intel.com>, <james.morse@arm.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bagasdotme@gmail.com>, <eranian@google.com>,
        <christophe.leroy@csgroup.eu>, <jarkko@kernel.org>,
        <adrian.hunter@intel.com>, <quic_jiles@quicinc.com>
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-11-babu.moger@amd.com>
 <CALPaoCj46dDCFruHW3EcqRQ90SZpOsKK2UVPzb+88rzs5aTTJg@mail.gmail.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <CALPaoCj46dDCFruHW3EcqRQ90SZpOsKK2UVPzb+88rzs5aTTJg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkorMlVpUTArSU1IZ2NMR2dnYjM3VXlaWG1xNWVsQjFQMGxYZi9jS3FLdFhW?=
 =?utf-8?B?MEd0ekZUMkdscXBDZE9HS0RqQjN1ei84NWE1eWt4elc2aVRyY1diWXBoRWZP?=
 =?utf-8?B?UEZ5U1dHM3BCcDl6dkltLzJzNXhTMTJMT1hDelVKbHlSc1ZBQmNkWGtReHdB?=
 =?utf-8?B?SXFSTFh3SHBIQ2NCc1B0eGdYZGpXK0hpbzd1MTIvUUtlZG5DZThRZ0JqTXpj?=
 =?utf-8?B?Qlg3aEtUQmwvRHgyaWkyK29tc21IbkdSdTcwQjJvUEZHS2E5a2VCMTlqdFdq?=
 =?utf-8?B?bExCUG5RQjlDNENJL3lIb2Z3YWl0K0lramUzNG1qUHdCUTIxZS9VbVhzb3FQ?=
 =?utf-8?B?MHlrYUlTQkFBWEtiY1gwSU9lcSttSnUvVitVNDUxcHZOWlQzUjYweFRLRTEv?=
 =?utf-8?B?Q1NVN0d4VHJYbWh4eVpCbk5PcTNXc29nbjZMTkVoVlk4ZFdBYmxtUWpWLzVk?=
 =?utf-8?B?d3h0SDVrTy9mRnJqeFFXWUtKQWs0MEZpa2JXNk9TbnJ5SThzMC9VRkoxWEUw?=
 =?utf-8?B?Qkx1UDU3SndhaitGR1d2Qy9jNzNwN1lHRUZOc0RpdVJuanhpQjVaOTRkc1ow?=
 =?utf-8?B?dkY3ZSthWHRaajl4WnRweFFIZ1VrTmdsL0NyREJQeHNtMks2R0ZJeGpibUoy?=
 =?utf-8?B?Y29vSjUzZVh1VUtoQlZ2SnNCLzVSRFZvbjJHTUFYT3A3YWVzM0hYSDMvb0ZJ?=
 =?utf-8?B?WkhlUldVTG12cTVSbkljK0poZ0RFczlZRHJET1pSRmhjZStqN2QxdDJSTjZZ?=
 =?utf-8?B?aTVndFdXa3l4U0gzczI1ZGlkL3Y4NHhGczJWUkVMZlNzMGpOOVN3emR6bVE3?=
 =?utf-8?B?RHdsL2FaaEVLMmJFTS81SDRMMWNRRHFuSTZLQTFhNG5lTmErWmk4KzVXakd3?=
 =?utf-8?B?ZElaTEs4NnpBd0g1cDRaVTdvM2VXQUQ2SEVTaUZvdjhmellTalFQSWlWcHZX?=
 =?utf-8?B?K1BNdjRwV2R2Q2xodVArWC9xMUV5RGMveWE0Zk9hNnMxK3ZQcTBsaUY4bERm?=
 =?utf-8?B?eDR4RHZtWm8vclIrNk13cy9pK1pIZGVwNmNhZW5GdkxQaVgwUWxBV29uc2xl?=
 =?utf-8?B?ZUtLMHMrVVVkWmNMR084YmFGMTZtSC83R0dNdVlOM0o3WkhzZVhYN3FlUEE4?=
 =?utf-8?B?b3ZIMHNIbzJncUZTaWluVnB6YlJUWU9udnZlVlF5TUNOSmdjMDJJenl2akNk?=
 =?utf-8?B?ckhvMmZLamw5bjUvYmJuUlBVTWQzNHFWd2kzR3BwUXhrV2hITG0rY2RwdlA2?=
 =?utf-8?B?UHE4SndoNFdFd3lpYTlMUXlwMVliL1RRU1VVSkM1SmRkVHNtMm5pcTBTWWlT?=
 =?utf-8?B?RHVQSVQvK3M0S1dmenFyQ1MvcjlWZ01zSDBmYi9sWGMzTXZiemhWeHg2ZzlR?=
 =?utf-8?B?VWcvYlM4alVMU0tSNGs5S3VNT2ZKRUxmdFJIN1AzbmxoUUFiRThoNzUzRDNV?=
 =?utf-8?B?aHlvRmNQRTNoNWNDTUNJcHNvUXFMcTkvN2VBY1BxSld3Rnl2am9RRWhPZlVv?=
 =?utf-8?B?djVaYWZBaTl0QVF4Vk0vMzlQQ1pvUFZrUkxxZVNtdi9XTmU0ZzlJWkxKdThM?=
 =?utf-8?B?Um5DUXJwbDRncDc3WndyRkRnN3NFaS9IMTRIMVNDUCtpeVExWHE0TkZQRlRL?=
 =?utf-8?B?SjhoVjllVHlRb0FMWmk0RDdIMEw2dU5vSDV2UldSTkdHTVFFL1RtVkhKU3Vl?=
 =?utf-8?B?K3gwMWVNYUduMTZwMHJYb1hNWjNxc3N3MlIrUEVDYlNMWk9tNlpHbk9wcTFM?=
 =?utf-8?B?VmZDQS96UDVLcGJKVDRBdjVYR3BReUE1cnoxTzBrVjRBRHNlU3JRU0crK05O?=
 =?utf-8?B?ZWdZR1pObFRmcWgrcVBScW5xbDA2c1BWUEUwYVVYcGRLNXk5Q3B6elpTZUJJ?=
 =?utf-8?B?TjBMNUNLVmJseUNvbTZJQ3BUd1pjelV1a2ZybUV2dVFNUDZVeTdwbnZMZkxD?=
 =?utf-8?B?K1Q1a3dzUFZueFFxa1JCWS9CQmNqWFpXanZIMUYzLzgvSFZad2dDa0ErbWVv?=
 =?utf-8?B?UmZ6VHJpTzhZbFVFRUdLaFRXQkRockg1a0RLZnpNQXEzSlZDT21hWDd2MVAx?=
 =?utf-8?B?REFlZ2JvRFAzc3YrbXkxeWRZTmIyRmI3Y3ByZWsvY1NnNUViVjBLRUw2cnA3?=
 =?utf-8?Q?w4GDKhl3s1POufJspK8JSPdPb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e4cedb51-1df6-4e20-2e5f-08dbbb95a56f
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 17:59:20.5377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VrUGwEAck37c1wzk6EkrxyqeydUZ5ILzGw45hSwwmGj/xzhkIBh83M2KEJ4dwKRyTL2EgbmQfYCkTsWt+VZh8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7448
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 22 Sep 2023 12:36:32 -0700 (PDT)

Hi, Peter,

On 9/22/23 07:36, Peter Newman wrote:
> Hi Babu,
> 
> On Sat, Sep 16, 2023 at 12:42 AM Babu Moger <babu.moger@amd.com> wrote:
>>
>> In x86, hardware uses RMID to identify a monitoring group. When a user
>> creates a monitor group these details are not visible. These details
>> can help resctrl debugging.
>>
>> Add RMID(mon_hw_id) to the monitor groups display in resctrl interface.
>> Users can see these details when resctrl is mounted with "-o debug" option.
> 
> When I reviewed this, I went through the whole series second-guessing
> the wording above and wondering whether "monitoring groups" applied to
> CTRL_MON groups.
> 
> I was able to confirm that mon_hw_id did appear and had a believable
> value in CTRL_MON groups which had allocated monitors. (and I added
> some comma-separated PID lists to the tasks node)
> 
> for the series:
> Tested-By: Peter Newman <peternewman@google.com>

Please use "Tested-by" instead of "Tested-By" (the "By" is wrong).

> 
>> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
>> index a07fa4329b65..b4910892b0a6 100644
>> --- a/arch/x86/kernel/cpu/resctrl/internal.h
>> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
>> @@ -296,6 +296,11 @@ struct rdtgroup {
>>    *     --> RFTYPE_BASE (Files common for both MON and CTRL groups)
>>    *         Files: cpus, cpus_list, tasks
>>    *
>> + *             --> RFTYPE_MON (Files only for MON group)
> 
> If monitoring is supported, all groups are MON groups. I think the
> "only" above caused me to second guess whether this takes into account
> CTRL_MON groups getting the RFTYPE_MON flag set dynamically.
> 
> However, I think the documentation above is still technically accurate.
> 
> for the series:
> Reviewed-By: Peter Newman <peternewman@google.com>

Please use "Reviewed-by" instead of "Reviewed-By" (the "By" is wrong).

Thanks.

-Fenghua