Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <28c862d9-ca39-2dda-86dd-9ccc206c3a1d@ti.com>
Date:   Fri, 22 Sep 2023 09:38:14 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] arm: dts: omap: Apply am57xx-idk overlays to base dtbs
To:     Tony Lindgren <tony@atomide.com>, Rob Herring <robh@kernel.org>
CC:     =?UTF-8?Q?Beno=c3=aet_Cousson?= <bcousson@baylibre.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230911214609.2201040-1-robh@kernel.org>
 <20230912065946.GC5285@atomide.com>
Content-Language: en-US
From:   Andrew Davis <afd@ti.com>
In-Reply-To: <20230912065946.GC5285@atomide.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/12/23 1:59 AM, Tony Lindgren wrote:
> * Rob Herring <robh@kernel.org> [230911 21:46]:
>> DT overlays in tree need to be applied to a base DTB to validate they
>> apply, to run schema checks on them, and to catch any errors at compile
>> time.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> Note that I have no idea if this combination of overlays makes sense.
> 

It does make sense, but it is only one of many valid combinations. I'm
guessing the goal here is just to make sure they all get applied in
at least one way so the scheme check runs. In that case this is fine
other than it might give the impression this is the only valid combinations.

Also now we end up with these odd `am57{1,2}x-idk-overlays.dtb` files
which also might confuse folks, I wonder if there is some way to
apply and check, but not ship/install these..

Andrew

> Adding Andrew to review this.
> 
> Regards,
> 
> Tony
> 
> ---
>>   arch/arm/boot/dts/ti/omap/Makefile | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
>> index d2b590004fed..d0c76d09fe70 100644
>> --- a/arch/arm/boot/dts/ti/omap/Makefile
>> +++ b/arch/arm/boot/dts/ti/omap/Makefile
>> @@ -129,6 +129,11 @@ dtb-$(CONFIG_SOC_AM43XX) += \
>>   am57xx-evm-dtbs := am57xx-beagle-x15.dtb am57xx-evm.dtbo
>>   am57xx-evm-reva3-dtbs := am57xx-beagle-x15-revc.dtb am57xx-evm.dtbo
>>   
>> +am571x-idk-overlays-dtbs := am571x-idk.dtb \
>> +	am571x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2587.dtbo
>> +am572x-idk-overlays-dtbs := am572x-idk.dtb \
>> +	am572x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2045.dtbo
>> +
>>   dtb-$(CONFIG_SOC_DRA7XX) += \
>>   	am57xx-beagle-x15.dtb \
>>   	am57xx-beagle-x15-revb1.dtb \
>> @@ -145,6 +150,8 @@ dtb-$(CONFIG_SOC_DRA7XX) += \
>>   	am574x-idk.dtb \
>>   	am57xx-idk-lcd-osd101t2045.dtbo \
>>   	am57xx-idk-lcd-osd101t2587.dtbo \
>> +	am571x-idk-overlays.dtb \
>> +	am572x-idk-overlays.dtb \
>>   	dra7-evm.dtb \
>>   	dra72-evm.dtb \
>>   	dra72-evm-revc.dtb \
>> -- 
>> 2.40.1
>>