Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp3022153rdb; Fri, 22 Sep 2023 15:54:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNda69arOWyCJyYPtVoBxC81/m183df/5KvnNfHOh9PRGUXRROCLmLOwMwl1s6qL9aiVb6 X-Received: by 2002:a05:6a00:1401:b0:692:780a:de90 with SMTP id l1-20020a056a00140100b00692780ade90mr730875pfu.30.1695423273356; Fri, 22 Sep 2023 15:54:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695423273; cv=none; d=google.com; s=arc-20160816; b=LtK69bPQgSqocY+sMeXoZ87XmyTxG68bxr9ATeguwlT31wmO+Oi25s9pEJjEHRYAta CPQuqcuBQvnoHksKeo+iakYR+CjEQ7rVGAZNXGci9IPsz/x/fYn5BX2hX1G6Z7U3EYzW 1xDfGlcMB2GhyAhRfz7775w6WeT2pjM4O/a5SLyzleYovWL+kjWUOACN8iXlyAC9HjOa ABxn0YhMzpT6g+h4J906oURlE3QF9PMFl7HRRo2CuPbzfVFrJUFs2A2XT/6WcnDXdY+w uri5/B4ya8fRHAI/DxZdx0EDMjboOwMkzkb6xKqxkoS/dFwraCR1eJQHwNbjHhA6tzJP 1SvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=PPHFLbzbu9ybEyhND16lIWSNA3s9x9LVTO8n/V1wcvE=; fh=yYoLPJNwILzVcFWMQbz/lqtTYYIrWZ8SpAmLNb3AM7E=; b=w0Tcs84F+LRECy+6JcYZaR2Z8//ynxrbcNP+YMaLzhDyMONtiHHHhb+ox1e8NX7WMg 9Z/GJTupN/nKQ9LLY8R4PqcEeB6W3bwCNqnnyPWjvCxfpawxLJX7phNX+dKxznFq83Wq WMWmt7JKHjCw9j3YGU2eRS1YAk+whJajjCgDujMbGzEPgKjgtIt3x9cJqaGYPfWjg0r6 MMtA2EXkbeBXN5r/vZKDPOV+F3rki2VWOsFKOT+V1fUKudrR29Z9OImeeyVIKTEVYCnu p5N+KAxLYcBYYBgSfztKS+/BFf67yRG7WFyNu7YNfR6zzTpVI/aEGIZs2c10BxRJT4VT I/eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=SdX6tRI4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id a21-20020a63e855000000b00578d7a3a4fdsi4637131pgk.563.2023.09.22.15.54.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 15:54:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=SdX6tRI4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 71660807BEEC; Fri, 22 Sep 2023 10:20:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229863AbjIVRUZ (ORCPT + 99 others); Fri, 22 Sep 2023 13:20:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjIVRUY (ORCPT ); Fri, 22 Sep 2023 13:20:24 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 593E1F1 for ; Fri, 22 Sep 2023 10:20:18 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DC67C433C7; Fri, 22 Sep 2023 17:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695403218; bh=IRau8b5XGe3qEYgJQvRo4yzSY5zEVQssEPPROArtjug=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SdX6tRI4jMHI7b7K67i9g314zNNszN6vEJLecg9UFiF+cebpsKDyHIsQrhvfjBQX0 ky6HdGeB74v+yS+mYqEe0HJyTJzY6Imvxt3ZexpbbSQPfZowZhxVOVf7tquOmjTbgJ tQ8PkASq2Vb+F0t7Nm0KIO9RjyGhZBmZkYaCaObQ= Date: Fri, 22 Sep 2023 10:20:16 -0700 From: Andrew Morton To: "Zach O'Keefe" Cc: Yang Shi , Saurabh Singh Sengar , David Hildenbrand , Matthew Wilcox , Saurabh Singh Sengar , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Greg KH Subject: Re: [EXTERNAL] Re: [PATCH v3] mm/thp: fix "mm: thp: kill __transhuge_page_enabled()" Message-Id: <20230922102016.95cab3640b17155a846874d9@linux-foundation.org> In-Reply-To: References: <37c2b525-5c2c-d400-552c-9ccb91f4d7bf@redhat.com> <3e08d48b-7b70-cc7f-0ec1-12ad9b1a33db@redhat.com> <3408ff54-f353-0334-0d66-c808389d2f01@redhat.com> <9f967665-2cbd-f80b-404e-ac741eab1ced@redhat.com> <20230906065817.GA27879@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20230920054454.GA26860@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 22 Sep 2023 10:20:26 -0700 (PDT) On Fri, 22 Sep 2023 09:56:21 -0700 "Zach O'Keefe" wrote: > >From this back/forth with David/Matthew, seems like we're OK saying, > "this was a mistake", and that we can take the patch (need some form > of Ack or Reviewed-by from them first, to confirm) Yup. And please let's update the changelog to reflect the details which have been discussed thus far. If the change *makes sense* for the current kernel then let's proceed, regardless of the broken driver issue. But adding a cc:stable would require extra argumentation, which I will be interested to read ;)