Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <f28c872d-6087-030b-7897-5d530589991b@amd.com>
Date:   Fri, 22 Sep 2023 10:49:58 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v10 10/10] x86/resctrl: Display RMID of resource group
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>,
        Babu Moger <babu.moger@amd.com>
Cc:     corbet@lwn.net, reinette.chatre@intel.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, fenghua.yu@intel.com,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com
References: <20230915224227.1336967-1-babu.moger@amd.com>
 <20230915224227.1336967-11-babu.moger@amd.com>
 <CALPaoCj46dDCFruHW3EcqRQ90SZpOsKK2UVPzb+88rzs5aTTJg@mail.gmail.com>
From:   "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <CALPaoCj46dDCFruHW3EcqRQ90SZpOsKK2UVPzb+88rzs5aTTJg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWNUQ0lLa3NlTC9Ha3g0WXJabUtydE82NUdEMmd5YVZCNFR1TTYzNFlteVBs?=
 =?utf-8?B?RWlGQmJTSFJnNkFudEtLSHZGb2UxME55OG41YVNiYnNkZW5oVnc4eVpZZjcw?=
 =?utf-8?B?OWdySUYwdTZmS3VOb0RCNEtNOVpBMmtBQjRYeTluS0F5Q3FkT3NQWHdabFd2?=
 =?utf-8?B?WVR5RHpia04xb2kyVXJ4WnB4QUcxdnNZWkRKVG1wWUNtODJrbWFvZFJacVV1?=
 =?utf-8?B?K1V0enQzUmZDbDMrajVUSXlqRVRNQ3NmYlh1MTRxaU5NRDVpRVhRMEFlVy85?=
 =?utf-8?B?dlhIUXVmd1h3cWFiSG1pU1dSV2RtYmVYdm1NUk1XdVlSSVZ1NlNpODZLSFcx?=
 =?utf-8?B?Rm5weVB2Mkw3WU5lT0E1RGZrR2tvUVJIT21wbVZOUU1ZNE9xWUVqTktUczgr?=
 =?utf-8?B?Q1JyZ0Y2UTYwVlI1bXZOYjdmWnVXZzhSUTFKdHVKUlJJQ0FON0RwS3FrZm9R?=
 =?utf-8?B?cWM2MWtMZU9jeWx2WXF0WnN5R2F2aFU0L0tLM0cydnFoZElZRXhRdUd4cG5a?=
 =?utf-8?B?N1JrUWZHRGU5YVZZdXVrdGVZaFk5QzBPUGE2R2psVlIxNmdqb2pFeXlWTE1J?=
 =?utf-8?B?NlUwUTFCeU0zYlkzcjh3SXhxRmJGQ3JIcHhVU1ZUdW9BQ1N0R293d2FFaUlZ?=
 =?utf-8?B?eG5USHZQRVpUenRTVTVvNHR6d2xxQnBZenlUbWVLbUcvTEdjeFZza3FCS0ZG?=
 =?utf-8?B?MGJ2QWp3MThxc3p3aFRPZWNTaUFTbkpGaituaXZGZVRGWkdwWGM2Y1ZzMldI?=
 =?utf-8?B?QjYwVDdla3VDNkZLVktycDNDbE0vMmR6UktBVnJ2YTlZc05pRnFxSGw3MXhr?=
 =?utf-8?B?NGZMd0I2a0xQM1Qyc3VIS29yYU1SakNSVDU2UDJtcFgxYWZhZmRoazBvWE1k?=
 =?utf-8?B?bi8xSVV4K2oyR25xa3JIOFZGdkpnRmFmSEZkSlBCOWhiZllkZkZINXJUdlpL?=
 =?utf-8?B?dHBic3NIZUJEd0w1YWpVUmpCV3hLQzBrN1hPT00wbTFaU0V3QnpIZGFoZHo2?=
 =?utf-8?B?dTZ3cnNaZXFTVHh3OFdRK1RjN1dYd29RZFR4UTlIM2drRW5SY1RFZUlnVHEz?=
 =?utf-8?B?R3RrME5SZG1ISStCK0xQaFhNeW5SMzJVYVZKT29YWGtLbnIzQ1pKNlJJOE9J?=
 =?utf-8?B?U05EOVpMWHNIdTNPSzNINFZZTFZhLzg3Yjhpa0E2YS9LTUdiZGJWS3hsYWlN?=
 =?utf-8?B?a0ZpQlpRbnltK1VUb0hKQThpbmR4TnUrMDkvVWZNa3V3b2dYcFV6bVZzTDIr?=
 =?utf-8?B?OGRmTU1XbCthQ2tDR0Z2eVRCSVZMSGRwZGhDQzc0ZE5HMzJ2YkRMVnczRDdz?=
 =?utf-8?B?a1ZaZVBVQSs1c2NpM1NLVVBybEpBSzcybG01b1Z6Y1NYN1Bjb2R0NlJPTGs3?=
 =?utf-8?B?VGRBVmxmSGFlQnVOZ3JYZjBKbktkWWVBYkpBVVNxeFp6U1pPaDNxK0Y5UU1v?=
 =?utf-8?B?c3F2R3V4ZHRYWWtwZGZ4VGQ2MlprWVJENDM5OFRvdzZQYTNURTY0aXEzdVkz?=
 =?utf-8?B?Y1R0WmRSN2VPMXBwY2g2c05OaUR0eWNQRWJvUGhOdlJEK2xUVFc5RnRrU1pw?=
 =?utf-8?B?d05XOWl5bWJhNVNEWkZjZFNsb1JXT3JCRGRIYlRaMWgyZHkzdnVCWGMwOGdS?=
 =?utf-8?B?OW50aEJ6Wk5BYzVobXhqeTRhQ0R1eGJ3ZGN1ZVg4bXZ4QUk1SEMvQlhFbjNw?=
 =?utf-8?B?V3FNL0pyVzhPNXJ2bUZXdVNBRnEzRTVnSU1wZFVqcXYvQjFQa3ZVaGwxM1Q0?=
 =?utf-8?B?REVFc2JrcGxPMFJJaWVpQmdPWUduUVJ2UGlzV0p4Q01XVVlxeDQ4M0tXWDFD?=
 =?utf-8?B?ZzYvUWh6a09tNHhDb3J3ZTFEaEpVTXhqWXpZdzBxMGpDOFUydXVTOHdjV1BJ?=
 =?utf-8?B?Q01GUGc2WGMxNUg0bG1mRGIzVEZIaElxUUpnVmNkOEJWQjYyVGY4OUp4R29K?=
 =?utf-8?B?ekIrbW0xM0wzWmw3YXdjbnEwQ2lHKzRDZXdmR3hzV291MWptL1pzTkd1MWQ4?=
 =?utf-8?B?THBmeGNNSXJZTWdqSzF6Q1B3aEd5bG8zMTYrUFkyUDI3Tm5iUytkMFZ4LzhP?=
 =?utf-8?B?d0FxWXk1SS9HN0x6a3IxZXgwVTZTQVE2WXZmWlk3OVBlcWxnTUNXR3RmOXo0?=
 =?utf-8?Q?tb0k=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 169d7f30-5c7b-40f5-98e9-08dbbb839685
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 15:50:04.5582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kJykkdRZy3g3vIo5YttDBKYhEz6gZ2a8tXFiAGr6T6e9OPn9CWs/s6PnahvfjJqX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5253
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 22 Sep 2023 08:50:24 -0700 (PDT)

Hi Peter,

On 9/22/2023 9:36 AM, Peter Newman wrote:
> Hi Babu,
>
> On Sat, Sep 16, 2023 at 12:42 AM Babu Moger <babu.moger@amd.com> wrote:
>> In x86, hardware uses RMID to identify a monitoring group. When a user
>> creates a monitor group these details are not visible. These details
>> can help resctrl debugging.
>>
>> Add RMID(mon_hw_id) to the monitor groups display in resctrl interface.
>> Users can see these details when resctrl is mounted with "-o debug" option.
> When I reviewed this, I went through the whole series second-guessing
> the wording above and wondering whether "monitoring groups" applied to
> CTRL_MON groups.
>
> I was able to confirm that mon_hw_id did appear and had a believable
> value in CTRL_MON groups which had allocated monitors. (and I added
> some comma-separated PID lists to the tasks node)
>
> for the series:
> Tested-By: Peter Newman <peternewman@google.com>
Thank you.
>
>> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
>> index a07fa4329b65..b4910892b0a6 100644
>> --- a/arch/x86/kernel/cpu/resctrl/internal.h
>> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
>> @@ -296,6 +296,11 @@ struct rdtgroup {
>>    *     --> RFTYPE_BASE (Files common for both MON and CTRL groups)
>>    *         Files: cpus, cpus_list, tasks
>>    *
>> + *             --> RFTYPE_MON (Files only for MON group)
> If monitoring is supported, all groups are MON groups. I think the
> "only" above caused me to second guess whether this takes into account
> CTRL_MON groups getting the RFTYPE_MON flag set dynamically.
>
> However, I think the documentation above is still technically accurate.
Thanks. If there is another revision, I am open to remove "only" from 
this text.
>
> for the series:
> Reviewed-By: Peter Newman <peternewman@google.com>

Thanks

Babu