Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <de20c603-6521-1ab7-3bab-67e6a278bd1e@intel.com>
Date:   Thu, 21 Sep 2023 15:58:26 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH 7/7] cxl/trace: Enclose a multiple statements macro in a
 do while loop
To:     Jeongtae Park <jtp.park@samsung.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Fan Ni <fan.ni@samsung.com>, <linux-cxl@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kyungsan Kim <ks0204.kim@samsung.com>,
        "Wonjae Lee" <wj28.lee@samsung.com>,
        Hojin Nam <hj96.nam@samsung.com>,
        Junhyeok Im <junhyeok.im@samsung.com>,
        Jehoon Park <jehoon.park@samsung.com>,
        "Jeongtae Park" <jeongtae.park@gmail.com>
References: <20230921025110.3717583-1-jtp.park@samsung.com>
 <CGME20230921024832epcas2p35c4d3c20f7a70b023db64cd0db823eb8@epcas2p3.samsung.com>
 <20230921025110.3717583-8-jtp.park@samsung.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230921025110.3717583-8-jtp.park@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUZJSkl4K2tXMVVsMmZpaWl6bXNVRFZRK1hqbHdjNVNuZHBlVlpaaXNvTHdX?=
 =?utf-8?B?a0JyYzQ0TU90dkg3UWpJNXNQSHdXaDJ5NjJad1E3ckgyL055azRmTDlvcWpB?=
 =?utf-8?B?NkRDR3NXWHNxSXRCZFIyYXQvWGNQMitrd0RvVWFwM2JWRzVQZEpLUy91d3Va?=
 =?utf-8?B?bnZIVld2WWltS3pRUVgvN0M1MmJFZkJWa0pOeUJDRk4xM1dKMjVSRG9NTzQy?=
 =?utf-8?B?QlBmWkEvd2NMcEdJUldXdEJpYzNjOTJMdmFoYVk2cWF6MVVNbitDQlNzTlJW?=
 =?utf-8?B?ZXJxT1JKYUF0S0Qvbks5VTM4VndydUVuMVB5dnh3TVNzSDNGN3dJeFRSZDNm?=
 =?utf-8?B?YVFadEFNbzgrT25iNktMbkhiVnRZMmRqbWxkbXlseXhiWFBWU05KUDJ3eXIv?=
 =?utf-8?B?NzM4K3FHOWRQUmZJQjNnVXdOVmNpN29qU0JqMEkxR3pablRaNGRHZ3pCV1oy?=
 =?utf-8?B?SFFETU5SbFh2UVVXaXc1RTl4SlloSktlUSs5RG9OdS91aDE5ZUhpbW1hbXJ4?=
 =?utf-8?B?TFJZMWswUTZYcUVZbVRCMlp4MGdKU3EzY1c4WG10Wkpxa2VyQ0dPS0EzVlBO?=
 =?utf-8?B?ek83MWVnQ0hvZ0pMeVVsam95SzNrQXJjc2NpazQ5STdWa0gzWjVMdi9tM0p4?=
 =?utf-8?B?SjZua2VNUE00dW9XYjc3MlRXRllFa20vNmttMnFOS21mdHcraCtaVExkVWZ2?=
 =?utf-8?B?TjNDd2thMENjdTFibVJDcWxpeHUzWDR1VTVOQXREY3NpQm1sdnp6Q1dlcXVu?=
 =?utf-8?B?OGphS2dHUHlCMVZZRzV5RVlrZyswZU1iSDhOUTFVVTloUEFzY1Vpb1hYMFZW?=
 =?utf-8?B?Tko1Sm5xZ1BSeG1reGQ3SUFCc0hCUkdpc0JwQjNUTEp0dmdRVXBqbERhcHZ6?=
 =?utf-8?B?NWVqakhvOHFnSEZnVlJQVjExWDR1aDdjNTJxcFdsTkR0UlVSSXlHNm9ndXBE?=
 =?utf-8?B?bkEzOHhrLzgrd3JVQXJhVEJLbWowRlM1N3lxZXZWMjhnckRiTnVVd0h6bjYz?=
 =?utf-8?B?Z3FNMWEydUdtVHhiaGZGZGtWeUhlTUlJalVEOGw3ek4yVUhmcytJNXJpeG14?=
 =?utf-8?B?OFJhbVBLYy8wRTVUaUpWaHdqbkhINkh2bW8zTWE0Y1huSmN0T01mOFN1UkJo?=
 =?utf-8?B?R3huTGFDWVYycUlrRU92azFiS3lvU3FGNk02MHFqU2hBR053aVgyaWNlVU9L?=
 =?utf-8?B?WGNYTlBHY1hrY1doU1ZGU3lvaUl6QTNpcFFnMmo2ekJQclh1R0I2ZVRzZGlU?=
 =?utf-8?B?U2hRb1lmcmxEUytoM21FNUtEMWNFbVRsajJMYmJrMmJocVlBRjQ4VFlVUlFN?=
 =?utf-8?B?bXRmSDYrUDBuTDRvN3dkREF5V09GdnFzMi81RWN6dE54elh0RS9yemc3dHN4?=
 =?utf-8?B?RFhFR3JvU1ZTRVU2OVdaWlAralk5NlpVL2dsYVZ1ZUtKS04yTHpYeE42dTV3?=
 =?utf-8?B?TTZpNS9xM1A0N1d5bEdtQzkrZnJIb2ZXeUM1SzgzRkh2bGdFQm4ybElBRUN0?=
 =?utf-8?B?c1lSRlFUL21sQ2tWOEc3eXE4RVRoY2lkS3hYdFFLM0xURFJOYmNCbStRZjlE?=
 =?utf-8?B?KzhZS3Z5aFNOV0d0dFdIcFduUzZGNnJyZmh2a25XRlZxYWhWU2VXSzFwMEhE?=
 =?utf-8?B?OGtrb1MwSUtEUmJ3OXFRV0h4UFZOcU5GL2dRdDBJb3hwS2pEK1JuMDVXdzJj?=
 =?utf-8?B?UmV6akZuWC9qWDdHVGoySEdxemNBclVibkhhVnRWbGR5UlFCVkVsNDJ5aUhO?=
 =?utf-8?B?SVV2Uk00SWZFa0FtT0RWLzVhNEt3Y0pVWU1lMWVFNC9ZYkZzcjBSeDBuNUpS?=
 =?utf-8?B?UWJVRE9TcURuOXQwVzNyOHFvbG5zVjdaZzRXOXlpWGlRaGhkdHE3RmFXS2tU?=
 =?utf-8?B?WDVldU9vd0tSdis0M0hCODk4ekgzTTBjVzN0bGNEUEJjK0NHd3JtOTFVeXkr?=
 =?utf-8?B?TS96QjVCQUhORkNrUDNucUZERTlhRXp1alpzRTdxUCtZRFFZTS83aS9Hb3Vl?=
 =?utf-8?B?eUN2LzR5RFVIaEEzeVlSTTBKYVdxZ3B0cm1INlVpMGZMUUNDUUpEYXVRQW5O?=
 =?utf-8?B?Wk5YaVdBcFFDRmk1V0U4Y01TMTdrdFAxNWh1YlJkY0Z1ekJVbGFSanVhYktG?=
 =?utf-8?Q?X8LnJ4B9PHHI3HpxMbVaCXlJN?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2712ceec-df37-4c85-8c69-08dbbaf64629
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 22:58:30.6918
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aUWsagyIVwkcfJwZF7t3+twh200qdkKFAigUaxVIoAW531sPVZcNdXELzwOOIQkzXxLoPAZrIg/V3eDSl1KmuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6988
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 21 Sep 2023 15:58:52 -0700 (PDT)


On 9/20/23 19:51, Jeongtae Park wrote:
> ERROR: Macros with complex values should be enclosed in parentheses
> 
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>

I think that goes against typical traceevent macros layout. I would ignore checkpatch warnings on traceevent stuff. 


> ---
>  drivers/cxl/core/trace.h | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h
> index 7aee7fb008a5..e2338773dcd6 100644
> --- a/drivers/cxl/core/trace.h
> +++ b/drivers/cxl/core/trace.h
> @@ -199,17 +199,19 @@ TRACE_EVENT(cxl_overflow,
>  	__field(u8, hdr_maint_op_class)
>  
>  #define CXL_EVT_TP_fast_assign(cxlmd, l, hdr)					\
> -	__assign_str(memdev, dev_name(&(cxlmd)->dev));				\
> -	__assign_str(host, dev_name((cxlmd)->dev.parent));			\
> -	__entry->log = (l);							\
> -	__entry->serial = (cxlmd)->cxlds->serial;				\
> -	memcpy(&__entry->hdr_uuid, &(hdr).id, sizeof(uuid_t));			\
> -	__entry->hdr_length = (hdr).length;					\
> -	__entry->hdr_flags = get_unaligned_le24((hdr).flags);			\
> -	__entry->hdr_handle = le16_to_cpu((hdr).handle);			\
> -	__entry->hdr_related_handle = le16_to_cpu((hdr).related_handle);	\
> -	__entry->hdr_timestamp = le64_to_cpu((hdr).timestamp);			\
> -	__entry->hdr_maint_op_class = (hdr).maint_op_class
> +	do {									\
> +	    __assign_str(memdev, dev_name(&(cxlmd)->dev));			\
> +	    __assign_str(host, dev_name((cxlmd)->dev.parent));			\
> +	    __entry->log = (l);							\
> +	    __entry->serial = (cxlmd)->cxlds->serial;				\
> +	    memcpy(&__entry->hdr_uuid, &(hdr).id, sizeof(uuid_t));		\
> +	    __entry->hdr_length = (hdr).length;					\
> +	    __entry->hdr_flags = get_unaligned_le24((hdr).flags);		\
> +	    __entry->hdr_handle = le16_to_cpu((hdr).handle);			\
> +	    __entry->hdr_related_handle = le16_to_cpu((hdr).related_handle);	\
> +	    __entry->hdr_timestamp = le64_to_cpu((hdr).timestamp);		\
> +	    __entry->hdr_maint_op_class = (hdr).maint_op_class;			\
> +	} while (0)
>  
>  #define CXL_EVT_TP_printk(fmt, ...) \
>  	TP_printk("memdev=%s host=%s serial=%lld log=%s : time=%llu uuid=%pUb "	\