Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <2f4bd46c-664e-4253-8d57-16bd46dd3be8@cornelisnetworks.com>
Date:   Fri, 22 Sep 2023 09:25:39 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] IB/hfi1: replace deprecated strncpy
To:     Leon Romanovsky <leon@kernel.org>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Justin Stitt <justinstitt@google.com>
Cc:     linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
References: <20230921-strncpy-drivers-infiniband-hw-hfi1-chip-c-v1-1-37afcf4964d9@google.com>
 <169537858725.3339131.15264681410291677148.b4-ty@kernel.org>
Content-Language: en-US
From:   Dean Luick <dean.luick@cornelisnetworks.com>
In-Reply-To: <169537858725.3339131.15264681410291677148.b4-ty@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEFTc3NxREdKUFVEai9RNmV6aXFzSWF4VkNKU1BRYlEzcWdFTElyTVRwOG50?=
 =?utf-8?B?dW5kUDVZUlR5dFZMUHExVzh5eFRRZWk1QTJQK0lPRC9lNVZjZlE3MjRTdmVj?=
 =?utf-8?B?YzZEamVZOTIvVDBDa2JRYWtzSStKZlNmTlBpUWtBRkkrNHFqY1lpZmZUb3Ay?=
 =?utf-8?B?Nm5RMjVCRUI0WkxIMjNVRE4xc2liczJxWnZhbVJYdEJBd1p1Q2xjcGlETnVx?=
 =?utf-8?B?b2RzM3hvcm9zcHduYW1OaFBsZXNpVENFazNoN2FlRUVlU3FHRFNuMnpiNFlt?=
 =?utf-8?B?QWVhSXFjOHNSU2hyc09sS04yOStGTG11T01RS1BZdjkvaG0wSHJBQkRmdWV0?=
 =?utf-8?B?SFNsRi8xUG11TStuYUtzc3RFaE5oaHU4a2o2RWhXb0Noc2ZGbE1qME4vaWln?=
 =?utf-8?B?SHA2NmZjL2xadzZrOXZ5bHM0cjRTbUtMZHVnMmxBQ2F1Q1p4S2VSclFLWUZZ?=
 =?utf-8?B?RmE2M3R6bUFvcUxKRHNrRlFiYWhGcU5VSW1hTmRObDhuNmJyWUdYV1B0VU1x?=
 =?utf-8?B?aFd0Q3dmRzB4NlJRSGc3djErVXVTdkRmYURWUWhjbjZPTHNUcDYvR0V4OWVX?=
 =?utf-8?B?eWU4TkZEZ3Z4b1VvNjBadk9PcWFKYTU5NWZGWVJSbm45bm9yTUI2YWF6VlVL?=
 =?utf-8?B?Z2Z2aGo4NUNta1lvTlhDUStJMXZlTDZaM2NnVzFOUWJMZFpvWDNMK3VpamVB?=
 =?utf-8?B?REhoZkJOOGpRZFdPelFhSUNCaUJtY3lLZSt3SlYxK2hzVWM4Z1FwOFdSQkZI?=
 =?utf-8?B?QnJEWG5veXVRUFhnMW9CbWFHdUVyeFRtU2w2YnFEODVtZ1h3UXZTbzNydERm?=
 =?utf-8?B?NjR1TEVSRlJMamxOSWRidm91bWVsU1paTGtxTkRCKzMxd2JpZ1NPWThsemZh?=
 =?utf-8?B?M0lMT2J2cUJ4ZVU2OWVUSkZ0WGg2UEtBRHpla0Mwb2pxbG5rQW40UHN4dFFv?=
 =?utf-8?B?WjJZUk56dUI4VitjNlNqSXg5QVpoR0xyZGJoczVKci9keXl3VGVNMDh1VkZq?=
 =?utf-8?B?RHNyK2VmY2E3MWN5VmRoOEY3cHZsUWFQQ0pjNHJaTW9TbDZQRjFiZ3ZXdW92?=
 =?utf-8?B?RWZlcXlWcHNJd3paUkx5YmhuVWt3RjNSYlc2aHl5eE8yQUJNR0s1dFdNRnJx?=
 =?utf-8?B?UTRjeHdmbldCb2srRkRyV0VrMkpGMXJod3FqVW53WlZxNG1VNWlNQ0xUdGZU?=
 =?utf-8?B?d2ZpM0JNZEROcGQxWDkvOUFaSzMrMm9RQ3FyRzd5NmVMNVM0SGNOYm1DQ1ov?=
 =?utf-8?B?UFJNcmRxT2tTbjBuSVFiZHpUVjZwUkRlandhYzlWM28rRlNlcTNRcVptaUMw?=
 =?utf-8?B?N29RTkU1V2x2elAvWmZkdXlhM212RWJTRjNhcGFzbWJxcE45QTQ5bVViNlIx?=
 =?utf-8?B?U2NSMnBVSmFvSmR5Q2Yzd1BwRHhuVUtjMHpudWxHeGFjNHVIZStNVFFkWTky?=
 =?utf-8?B?ZTRXRW4vMlN1czcva29IemVHdlBmQlQ0ZmN3SjhIY2gySHBoTU1hcjBxZ0lB?=
 =?utf-8?B?MThVallncm1LOTVWU0R1b3NkdVR4SzJ2ay93VWpEdDZseHdOYWxuRWZwQUkx?=
 =?utf-8?B?MS9ucU5zM0Y4OWplUVJ2YzVyR29wVHV6UlNNSWpzTFZIb2x6SlpZVTN4UnZH?=
 =?utf-8?B?ZllPNmtCT04xYVNZdElNMVpDUDc4MGROV1UyRml3QVRXYStsNmlKdjJMb3V1?=
 =?utf-8?B?WER2YmpvMjA5VnFGMWJhMVpYdUJxNXBlS2xsZVNkTUhRVFZyV25icDJwUHFU?=
 =?utf-8?B?VklkQXozN0NaM3ZUTWZVdXo1cW5LYlY5bjF3LzhYa3RHaTlxMGgvZk9lQ2xo?=
 =?utf-8?B?b0M3NkdWeFl6RnkyblJWQ2ZoUkQycmxsTk9QeFd3ZXJJMlhuSktCZ09hd09R?=
 =?utf-8?B?WXFlbVBGZnBUVUlzUGIvbGl0bTlVdFNhRDA5NGVrRUQ5OU9IN0oveE40UFRR?=
 =?utf-8?B?VDBETlNZNDhNTHNFUFYxUlQrQk5VWGJxTkd1YWRWSk14VURGeHN0UHZSLy9N?=
 =?utf-8?B?MHN1cU9xSXpENURJaCtDQ2IvK01sYlJEK0VEU1NXbW80Rm1XRk5UN2lHYlUr?=
 =?utf-8?B?NFVzQXhmL2FHbkhqL0xvUkR2TlQ4dkxuVWorQ1JrSWFCUldJVitISTFWMVc3?=
 =?utf-8?B?aFIzNWp0NzdKNFlBaGY5Qm9haHVadkF4c1F2T3pJMDk3WmdDS004NmYrVGZM?=
 =?utf-8?B?NlE9PQ==?=
X-OriginatorOrg: cornelisnetworks.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33dc326f-0c99-4fb2-a4a4-08dbbb77ce0e
X-MS-Exchange-CrossTenant-AuthSource: BL0PR01MB4131.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 14:25:44.0696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4dbdb7da-74ee-4b45-8747-ef5ce5ebe68a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KR9gIQHsX7DgiC1sT44U1FY6hGWVffIeN1BLOKCv/XyQeGpGgoqQ9/ubSNIpfSMl/D0/eiawuae5NFLQoZfQjnqRXc67glTcsCRVGVF/duU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR01MB6943
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 22 Sep 2023 07:25:58 -0700 (PDT)

On 9/22/2023 5:29 AM, Leon Romanovsky wrote:
>
> On Thu, 21 Sep 2023 07:17:47 +0000, Justin Stitt wrote:
>> `strncpy` is deprecated for use on NUL-terminated destination strings
>> [1] and as such we should prefer more robust and less ambiguous string
>> interfaces.
>>
>> We see that `buf` is expected to be NUL-terminated based on it's use
>> within a trace event wherein `is_misc_err_name` and `is_various_name`
>> map to `is_name` through `is_table`:
>> | TRACE_EVENT(hfi1_interrupt,
>> |        TP_PROTO(struct hfi1_devdata *dd, const struct is_table *is_ent=
ry,
>> |                 int src),
>> |        TP_ARGS(dd, is_entry, src),
>> |        TP_STRUCT__entry(DD_DEV_ENTRY(dd)
>> |                         __array(char, buf, 64)
>> |                         __field(int, src)
>> |                         ),
>> |        TP_fast_assign(DD_DEV_ASSIGN(dd);
>> |                       is_entry->is_name(__entry->buf, 64,
>> |                                         src - is_entry->start);
>> |                       __entry->src =3D src;
>> |                       ),
>> |        TP_printk("[%s] source: %s [%d]", __get_str(dev), __entry->buf,
>> |                  __entry->src)
>> | );
>>
>> [...]
>
> Applied, thanks!

It is unfortunate that this and the qib patch was accepted so quickly.  The=
 replacement is functionally correct.  However, I was going to suggest usin=
g strscpy() since the return value is never looked at and all use cases onl=
y require a NUL-terminated string.  Padding is not needed.

>
> [1/1] IB/hfi1: replace deprecated strncpy
>       https://git.kernel.org/rdma/rdma/c/c2d0c5b28a77d5
>
> Best regards,

External recipient