Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp3070298rdb; Fri, 22 Sep 2023 18:07:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEVEmdjSSYuIXuTYySSfZi8y+BfObPJtQDNLOXwGcitJe+w5J7xOhWsqKhGNrSn/QGf74gq X-Received: by 2002:a54:4802:0:b0:3ae:24bb:381f with SMTP id j2-20020a544802000000b003ae24bb381fmr1156887oij.46.1695431273736; Fri, 22 Sep 2023 18:07:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695431273; cv=none; d=google.com; s=arc-20160816; b=hjjG3/f/RwosFjbZoZdrUaTgjZV61q7KC6wbwnBAnDXvo/h5aGz3NwsyczqLioPzhs 4Z3qel/SwRPB/ppA9f1yg1yNYqXOLzI8MWF9kHE13l0wIOTjjOIFZKi6LRSs00Nee3mc bpkTwsjOWFJLewoll9dBwSqGf1pS1RMbulEEQiOUaq4OLWub+56uxSJ0/mnfYteAvM/D vqafI5Gu8OHucqAxz4EA/08nUENouTeokXO0QXzoffCV5bcwCOTpPZNbJDDUvG7Lu6oX avBI9dO2f+mXmG5iC5elTgGoJywFEyaZhyOTFK5SGcuIJZfCtICNUrNBYOO5fk3WrW2N C5MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=neFKDss4Eoz4zqBDkZFgiJEWmdfT57VEWXtM0Jgtcu8=; fh=TJwjTeN8ge1GP++VXr8jf8qKNM9lm2tp3FtbN/iZGPw=; b=S6Vx9YZjvq1KPbN4FruO24YT8o5iSynu22HBuR6EaNZ/Kkzru4LNBZs9wQY7HINmLX DfU1yUC9frT6nahbqSUKMmckwFazJdJ4dCtqHYSAIlEkUv4ny9G3i1E0mT+y9clexaNi HVWZYl2/+5HdabnwRDvrBZEsVa1WLm/yPPm92WtXlYSBsYQd5wTGbBfagqoUI0F7nlmh 1Ml78MVLKZt1YKwv39nPVx418Jl+n+EZFQSofN9u06Ju7OcL1cwNunJj2o/9mCo61vBd n5PgrYX+ktTwJrz6dJ08n+SpOrjWdqpQu+apN8mBsfETxL30uwuIhLvnad46Son1qY/P rTQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=NO2GxxrA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id z14-20020a056a001d8e00b00690c23d353asi4854819pfw.217.2023.09.22.18.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 18:07:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=NO2GxxrA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id C0C5083B008D; Fri, 22 Sep 2023 11:00:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232808AbjIVSAP (ORCPT + 99 others); Fri, 22 Sep 2023 14:00:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234292AbjIVSAD (ORCPT ); Fri, 22 Sep 2023 14:00:03 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BB1ECD3 for ; Fri, 22 Sep 2023 10:59:55 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2c124adf469so43409041fa.0 for ; Fri, 22 Sep 2023 10:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695405593; x=1696010393; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=neFKDss4Eoz4zqBDkZFgiJEWmdfT57VEWXtM0Jgtcu8=; b=NO2GxxrARKtVZOSuIAMt9Ix6EPjYW5hGkY5KMhlhPvlklZuBBhdfW3kQzC5UIS0Gcu noUJVp1dkiwSLCuovsS6cydQnDXH5XO0oIM8TJa8aHmqSkWc0U4djBl2EYpwmbdTenLW vcxon6A//JrFRuM567ICtp58sVYzH8TcEqvFnfhqISxB/TlRsu+WI0S2TS8QM2H8sJzG daE25I68Iq6ByjiVUOX/McVVxqTLPVx+wNqyzVrYjk3mtwbMlk7VZtjfSvuX6jdrEtlv jaNpj23Rwq3D197kfypZs0chiG70X45KWoPd8usq1ljHbZxU6qyxmR9Fp46Kd0XMX9Vs ToCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695405593; x=1696010393; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=neFKDss4Eoz4zqBDkZFgiJEWmdfT57VEWXtM0Jgtcu8=; b=wrxHch18/Og1mvFEobNNBatUbDqqvA4dhqP/x3MkO5sBqO20w8159w+caX++p1X+zH 0M4xdxlvbJ1VDfXb/oZQwMp0xIVs8Ed1EU/d7KEs5Jl4kH+fLOM1AIsAbZ7aJpV0CRAr hsXKg7sOlTJok4u3z94yMR1NdahPjxvandO/ZRWc2esvBKyiumEYMi7MhsUP/D65s3SN vZAy+yeiJAIJsuK6ovWMKlyXfm/GvYcfc6r3JEJwMpPAPkhIrE5hlV6Cla86/TYxhsX7 fZMh6BDdWozZf0JvsQPtK9giQPHIs3310wTWa5fv2A7HX9jDiDI/Rzw/BnRlbB3qPDP4 iEXw== X-Gm-Message-State: AOJu0YwXAxwyq2B9ty2x9UOG3H8zQwleqKRgDyajbhe146bGzpVAoYIR Og+ue/UtR5rMkAAniBQYWXWHsS3vF7B+zvtfdLqlAw== X-Received: by 2002:a05:6512:2512:b0:503:8fb:f738 with SMTP id be18-20020a056512251200b0050308fbf738mr259391lfb.17.1695405593333; Fri, 22 Sep 2023 10:59:53 -0700 (PDT) MIME-Version: 1.0 References: <20230922082542.466579-1-yosryahmed@google.com> <20230922100310.102aa12ac2bdf0568e6e7432@linux-foundation.org> In-Reply-To: <20230922100310.102aa12ac2bdf0568e6e7432@linux-foundation.org> From: Yosry Ahmed Date: Fri, 22 Sep 2023 10:59:13 -0700 Message-ID: Subject: Re: [PATCH 0/2] mm: memcg: fix tracking of pending stats updates values To: Andrew Morton Cc: Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , =?UTF-8?Q?Michal_Koutn=C3=BD?= , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 22 Sep 2023 11:00:27 -0700 (PDT) On Fri, Sep 22, 2023 at 10:03=E2=80=AFAM Andrew Morton wrote: > > On Fri, 22 Sep 2023 08:25:40 +0000 Yosry Ahmed wr= ote: > > > While working on adjacent code [1], I realized that the values passed > > into memcg_rstat_updated() to keep track of the magnitude of pending > > updates is consistent. It is mostly in pages, but sometimes it can be i= n > > bytes or KBs. Fix that. > > Clashes with "memcg: remove unused do_memsw_account in > memcg1_stat_format", and maybe other things. Can you please redo > against mm-unsstable or linux-next? Done, sent v2: https://lore.kernel.org/linux-mm/20230922175741.635002-1-yosryahmed@google.= com/ Thanks!