Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Fri, 22 Sep 2023 17:59:21 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        "Chang S. Bae" <chang.seok.bae@intel.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Nikolay Borisov <nik.borisov@suse.com>
Subject: Re: [patch V3 19/30] x86/microcode: Clarify the late load logic
Message-ID: <20230922155921.GJZQ252T5TbOVCYDc1@fat_crate.local>
References: <20230912065249.695681286@linutronix.de>
 <20230912065501.961705755@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230912065501.961705755@linutronix.de>
Precedence: bulk

On Tue, Sep 12, 2023 at 09:58:13AM +0200, Thomas Gleixner wrote:
> +	ret = microcode_ops->request_microcode_fw(0, &microcode_pdev->dev);
> +	if (ret != UCODE_NEW)
> +		return ret == UCODE_NFOUND ? -ENOENT : -EBADFD;

I know this is short but let's make it more boring and readable pls:

	if (ret != UCODE_NEW) {
		if (ret == UCODE_NFOUND)
			return -ENOENT;
		else
			return -EBADFD;
	}

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette