Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <20230922013750.874131-1-joshdon@google.com> <ZQ1Ml8fudWETJkY6@gmail.com>
In-Reply-To: <ZQ1Ml8fudWETJkY6@gmail.com>
From:   Josh Don <joshdon@google.com>
Date:   Fri, 22 Sep 2023 15:58:48 -0700
Message-ID: <CABk29Nv8FPOaTeOsJMNrsiZYSGdLeCRazBsD6nLSwdZ+ha8NZg@mail.gmail.com>
Subject: Re: [PATCH v2] sched: fix warning in bandwidth distribution
To:     Ingo Molnar <mingo@kernel.org>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 22, 2023 at 1:13=E2=80=AFAM Ingo Molnar <mingo@kernel.org> wrot=
e:
>
> So instead of uglifying the code with seldom-tested !CONFIG_SMP #ifdefs,
> please fold the !SMP code into SMP code: make ->throttled_csd_list
> unconditional in a preparatory patch (even if it's essentially unused on
> !SMP), then add what is basically your v1 patch as a second patch in the
> series to fix the bug.
>
> We want to unify as much of the SMP and !SMP codepaths as possible, even
> when it casuses a bit of runtime overhead for !SMP.

Yep, makes perfect sense, I'll respin this patch.

Thanks,
Josh