Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Sat, 23 Sep 2023 08:16:04 +0800
From:   Gary Guo <gary@garyguo.net>
To:     Alice Ryhl <aliceryhl@google.com>
Cc:     Wedson Almeida Filho <wedsonaf@gmail.com>,
        rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Benno Lossin <benno.lossin@proton.me>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        linux-kernel@vger.kernel.org,
        Wedson Almeida Filho <walmeida@microsoft.com>
Subject: Re: [PATCH 2/2] rust: arc: remove `ArcBorrow` in favour of
 `WithRef`
Message-ID: <20230923081604.6e2de521@gary-lowrisc-laptop>
In-Reply-To: <CAH5fLgj_wQtmW4A6-4wPeP-Qmk2ga2NoVRwZDujjYvHWY7Bk3A@mail.gmail.com>
References: <20230921213440.202017-1-wedsonaf@gmail.com>
        <20230921213440.202017-3-wedsonaf@gmail.com>
        <CAH5fLgj_wQtmW4A6-4wPeP-Qmk2ga2NoVRwZDujjYvHWY7Bk3A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3BiQXhVMm8wcEIzWGFrT255bDJpaW9XNGt1OUxKQk9vVTlxa1NkK0phWXJx?=
 =?utf-8?B?UTJXK1QvTkN5WEExQmpDek5rOHlVSzhKVnFnbjFHZWlNRFdaMW1BN05sb1Jy?=
 =?utf-8?B?ak9hSnNQQ1N4ajZxdTV3cDVsa2pyL1hBRURlSm51T3g0M1pBNlQxdjlEYit3?=
 =?utf-8?B?QkZ4Y1NqNnpBSUdKU2lGWGladERSZml2WlRxdFVQcGtmZityQ29rZjNNWTFG?=
 =?utf-8?B?RGhPQzYvejV4RURZM0M5cDJLY0hNaEJZaUFRSGNnRzVGSk50dE5QanBJOUdw?=
 =?utf-8?B?ditqdkord1BPcEZFYlRGdEcyRHZ2ZURCMURaQmZwLzZLcVhmWEVWTUtsSis0?=
 =?utf-8?B?QTRWcTBFQS9QQ3BJdlFIWDRaRHdZaXdOb0RxNXpmL0RKRjdxcFBwR0R5M2Yx?=
 =?utf-8?B?T29yMTdvMi9HcUtWVGhueWZtQzlib0dGdVdVaWZic2lSV1F6V0Y2S2Z0SkVC?=
 =?utf-8?B?WWdTeGZQOXcrbkM3WnhXK1R4S0hDZjJkc3Bsc0NCcGRDL1BCU2pTb2YzUFl1?=
 =?utf-8?B?Q2NlMU9ncFJSQjZxSnBYaVE5N2dsaFRuRDdNRGtXWGtOdU94ZGpna09ZRzRq?=
 =?utf-8?B?dHFYUXFLalhNbHVpQ2Z2RkxBazFrbGNsRXp6aFZiWFlWS2xnaXJCNGZhOEt3?=
 =?utf-8?B?MWxOQXhoUEFHTnFSUlRMUVE4WWU1SGtja0FMbTllMUJtem1vdmJiclRnalhE?=
 =?utf-8?B?Vmh0VG1ndUFGUE8rcHBMUFRjSUYxM016MnJGZ1c0a0xFL2pwVWpMNVBCZ0xv?=
 =?utf-8?B?TVVBU0dLaXc3a3lZakNCRndJR2x6QlRzdXhEdWkvRUt6WjMzWlU2TXprWFZv?=
 =?utf-8?B?YldybDVIRjR1M2JyMWtrYzFIZEpFdDNTcWVYeWR0UTQwb1BHeEJTSEJNNmFP?=
 =?utf-8?B?RDdsczRZYm9GZENLbGphNXhpLzZIeUMxMDF0ZnZ1eW53MjVwak9nTjBmODFP?=
 =?utf-8?B?bFVQMGJCRGxFNW9YbUpiVXhlTzh5UHdMbzdYK09oUFRnSjVqRHFwSy9sK2Yx?=
 =?utf-8?B?U0Y2OGRFcVFHMGlPNlA2UXpLcVNPeVluOVhJMTFvTTdJQUhjVGZaVXk4YkxH?=
 =?utf-8?B?RXE4WXNhZXBwc1FkTmNMclBWSTZlRjczMEdEWTEvVTVYNTlzU1ZSTExocU16?=
 =?utf-8?B?cTU2RU1xVEVJaGo1Y3BhbjljUGsySStCTjdFVURDbVNzQ0dVajZzeC9FTllr?=
 =?utf-8?B?ZzROSWRBZzE0NVUvTlh3QVRQbEdSbVltS0lvQmMzZlMvd2dKQ1BTZ1lFa2RD?=
 =?utf-8?B?UHBFTW1VamI4bHZpMlZtNHNiUkxnbFBzSG1nZ1Q0RTMwN3lyRU9LWHo0blNy?=
 =?utf-8?B?ZThIckZOVFkrQ0plWHFmWWlNNWg4MmNJV1BBcWp1OVhZL1hUVzN0NEU0UkxZ?=
 =?utf-8?B?cm1LRlIxZ3JVMWdoR0hxUWlGb3BldXZIVm1jdlE2WU9FcVR5NVJYQTNyMUE4?=
 =?utf-8?B?TTBYVUc0bFFUbzF5cmErM1JPRnNyNHpTTVl1VFR0bzFhZlV3VzlaUCt6NVdH?=
 =?utf-8?B?RDEzdndabHFEUTVMMmN0ZFJ6ajdvQlc0TzR2K0lIM2Z0TlpldXQwR3JPWHZJ?=
 =?utf-8?B?WENhcUJtdEdvZ1M1UzJPNzRFTnZLNnBzR1NhV3BuUm1mN2V2TmtqczhuQnNT?=
 =?utf-8?B?VUphL2NrNEFJa2NQOTJPK2NyQWZxZk9tSUZsVFQxWlFEQUFPa3QrY0ppbHRa?=
 =?utf-8?B?dkxKaURqaWFmQlVrTGRCVnFpOUFhemdwd1VmWVdDWXM1RGcyNUV3NFQzQVFa?=
 =?utf-8?B?TDZiZkFNb21WWFJCRW9TdC9za21CelFWbW4zT1RjWndCVmVLcU1sQnhaNUNW?=
 =?utf-8?B?cC9HWjY2SkRZek9CTkxJUUtBU2o0RHExN1hmMVRtZEc1UkVrbEZVdUR5bUZi?=
 =?utf-8?B?RVdiVVgvWjZmbHhwQ0hsVFk5ZTUxWjNIKy90NFdnNU5LaTR4V0lkbmFqbEZN?=
 =?utf-8?B?eDlJamlBWS9Hc3FpUjlCTVJVSkR5TEt0RW83dnJoWENyYVpqd1I3RTJuendx?=
 =?utf-8?B?Z0F3ZTBQOGEzUFRWT2g1UFBYczBqcHUxU21XdDJ0bUU2a1BiTnZqTEdEOHpO?=
 =?utf-8?B?TUxIQ2VjK21JV2NLZTdobHVFMmw5VjVnUmc2bDd0bU9SUThZOE1GRngxVGZs?=
 =?utf-8?Q?JbTJXts3PQ+EM1UC5IFCF5GM6?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bdbca71-8fb1-4612-98aa-08dbbbca506d
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2023 00:16:21.0990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mONA7g61Y2eYYj2MYCo8IwWXH1xmcPugvBUkXBzTn0rshYk0ZyjZoSMLDKEmhPZsJ81Zhken2Qy6zrhtG5eRxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB6861
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 22 Sep 2023 17:16:42 -0700 (PDT)
X-Spam-Level: **

On Fri, 22 Sep 2023 17:29:58 +0200
Alice Ryhl <aliceryhl@google.com> wrote:

> On Thu, Sep 21, 2023 at 11:35=E2=80=AFPM Wedson Almeida Filho
> <wedsonaf@gmail.com> wrote:
> >
> > From: Wedson Almeida Filho <walmeida@microsoft.com>
> >
> > With GATs, we don't need a separate type to represent a borrowed object
> > with a refcount, we can just use Rust's regular shared borrowing. In
> > this case, we use `&WithRef<T>` instead of `ArcBorrow<'_, T>`.
> >
> > Co-developed-by: Boqun Feng <boqun.feng@gmail.com>
> > Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> > Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com> =20
>=20
> I wonder whether "WithArc" is a better name? After all, arc is short
> for "atomic refcount".
> I also think it's nice to include Arc in the name of the type.
>=20
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Or just call it with `WithRc` -- we don't use `aloc::rc::Rc` in the
kernel so there's no need to emphasis that this one is atomic :)

I personally think the `WithRef` name is fine, we have a smart pointer
called `ARef` after all :)

Best,
Gary