Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp3139148rdb; Fri, 22 Sep 2023 21:55:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJ1QC4tdt8maA9rY3t+6WkkDYbCMx4v0in4wxacOK5RS9/YKC/CXYbmmPAWukEx3wamZWL X-Received: by 2002:a05:620a:280a:b0:770:70d6:417c with SMTP id f10-20020a05620a280a00b0077070d6417cmr1545007qkp.33.1695444947433; Fri, 22 Sep 2023 21:55:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695444947; cv=none; d=google.com; s=arc-20160816; b=JrqaMBi2YKrR6j4hpyC7CBzjagO7xuw7h6nXLjrPEBzk+Ldz4QtfXu/iu6fKYLx7oD yNML0+N5UkQTdX7ljDRTK1hqb2fBWjGlTHDpSKaBd+DrtWUbZF4V7uOaQiLjrmwc5WVZ u5wLPpSEv13/T4HklbVBjXGNUkNRFKOjXPRhNddMuJFu+Lz1HA2kfCHpTlhFQwIl19Q4 N+vWTEHgMa18EJ87b7lt/rkYMV/3E5QVHcte53z+B5VM6517Axcw9Oyur2BZD3nuiBau sAydH47w4HyE8mUtW0kRMXomKZiUVbX3w/U/wRohS4mWwpuZL3KMDGry3dBemE0eNWZb t8gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tXxf1RoiosXQhC+2G8YZWoday3+5yhFzk5HBzXNQsK4=; fh=qpXk4Vqrb9b8Kue1777uazO91/fo1b/tXI+vumJhqG8=; b=odb7aVgJ1ITwTBIW5baLIwq2k67gTxQRpx32i5tWh8VH4Kv8bk257pptvhwbT78idV ggSUZT38FRMf7k/rHglZ8QJI7fNcVG6f1ULvx7Iiqfv+qRu0QBnl5eZYVTWjKPP435Ia jyeBZQHlcY0NzY4W7ZK8P4Ws1UX2ABjcfrEWzmG1iQMfW/WeK6jEJ3xlkcHJFvVSJPYJ 3A4RyidV77XUCxRT4LXKfgZ1nx/ZOLIdCl+Ww6ssWlOxhvmmSOcWuktFt+1LXnigZanl SRN/gIgm4OeI0954GkGcPFL3pJuMcsaBKkQJ9cLiAtsGrJfLOsFSMESrEmqME+xqgppB EMBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VBjUeQwE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id eb2-20020a056a004c8200b00690fe0f6e0dsi5205130pfb.68.2023.09.22.21.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 21:55:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VBjUeQwE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 1F3DC82B432E; Fri, 22 Sep 2023 20:55:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230098AbjIWDy7 (ORCPT + 99 others); Fri, 22 Sep 2023 23:54:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbjIWDy5 (ORCPT ); Fri, 22 Sep 2023 23:54:57 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 882AE100 for ; Fri, 22 Sep 2023 20:54:51 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id d75a77b69052e-414e78cdc11so19541501cf.0 for ; Fri, 22 Sep 2023 20:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695441290; x=1696046090; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tXxf1RoiosXQhC+2G8YZWoday3+5yhFzk5HBzXNQsK4=; b=VBjUeQwE2wECv8PNFipWLCFqoBNhqLghT1xNTc3LgFbQatJBVQkQLB9W+4Fu8c9528 A2CX+/pFCZDfEc/FdL/jlrLJRouFcPcWg5ELokwDQ8e7mG2YaB19zWNhVOVIXZjaUAHr Tu1El7gpsa6khUXfn0Yry7GPUFfLWcBmCxosw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695441290; x=1696046090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tXxf1RoiosXQhC+2G8YZWoday3+5yhFzk5HBzXNQsK4=; b=DGjFnMbZm0rYwejar4WieWIo5s352vHZHgz875fe616HBufPNa9MmmUemx+n1gYN6a efY67/6vQDC9eOHA3+TSuXvmpznQtvgygCyHhKQdJ9sHc3uk8yQlo/oGNNsY8czbkJkH 3sMk3EEowIRTbYo5z7iSjOqVA2voIsqRBTPDRdqhkuQT4Wk09+m32V4Iret/6kD0ZdHZ OodUJTf5qEdt43Xcv/ggORXIxZehVWffrMI2i5gXCou9ToGi5z8WMLBBFGUR38Z2+ppm 1UooeBnrg9Xu6iUTIusUHLMhcOOwwY5luus+b2gl66TqGW0brAsJV/d7WJ7/EKsIHHsK z4xw== X-Gm-Message-State: AOJu0YyW+YXtU2y53u3GsPrVzR/wXPTMVyemHE1gA1hTb1QMzYI4KI3q kJn/fhDEe4kXdCDX7nebcHBbvw== X-Received: by 2002:ac8:7e90:0:b0:417:e0ff:931e with SMTP id w16-20020ac87e90000000b00417e0ff931emr1491182qtj.41.1695441290599; Fri, 22 Sep 2023 20:54:50 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id g11-20020a63b14b000000b00577cda166ffsm3901318pgp.35.2023.09.22.20.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 20:54:49 -0700 (PDT) From: Kees Cook To: linux-kernel@vger.kernel.org, Mark Rutland Cc: Kees Cook , dianders@chromium.org, sumit.garg@linaro.org, swboyd@chromium.org Subject: Re: [PATCH v2] lkdtm/bugs: add test for panic() with stuck secondary CPUs Date: Fri, 22 Sep 2023 20:54:18 -0700 Message-Id: <169544125511.3844201.2326680356367331620.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230921161634.4063233-1-mark.rutland@arm.com> References: <20230921161634.4063233-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 22 Sep 2023 20:55:01 -0700 (PDT) X-Spam-Level: ** On Thu, 21 Sep 2023 17:16:34 +0100, Mark Rutland wrote: > Upon a panic() the kernel will use either smp_send_stop() or > crash_smp_send_stop() to attempt to stop secondary CPUs via an IPI, > which may or may not be an NMI. Generally it's preferable that this is an > NMI so that CPUs can be stopped in as many situations as possible, but > it's not always possible to provide an NMI, and there are cases where > CPUs may be unable to handle the NMI regardless. > > [...] I added a line to tests.tst and applied this to for-next/hardening, thanks! [1/1] lkdtm/bugs: add test for panic() with stuck secondary CPUs https://git.kernel.org/kees/c/5fb07db970cf Take care, -- Kees Cook