Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Sat, 23 Sep 2023 08:12:51 +0800
From:   Gary Guo <gary@garyguo.net>
To:     Wedson Almeida Filho <wedsonaf@gmail.com>
Cc:     rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Benno Lossin <benno.lossin@proton.me>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Alice Ryhl <aliceryhl@google.com>,
        linux-kernel@vger.kernel.org,
        Wedson Almeida Filho <walmeida@microsoft.com>
Subject: Re: [PATCH 2/2] rust: arc: remove `ArcBorrow` in favour of
 `WithRef`
Message-ID: <20230923081251.2f702cc7@gary-lowrisc-laptop>
In-Reply-To: <20230921213440.202017-3-wedsonaf@gmail.com>
References: <20230921213440.202017-1-wedsonaf@gmail.com>
        <20230921213440.202017-3-wedsonaf@gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IpGLQrlY1zlusGyp05OLLzzuRmfq4gJyY8kmIWiWmFTrQNCPik432dUhpvxp?=
 =?us-ascii?Q?BT5su0tCyNMiIdN3G9fGwdQRetA4R1Tu5oTQkQbJ7P/pWvmHu/HsXVJOapWX?=
 =?us-ascii?Q?4R9mdKbzSms8LmZ4Z09dOWs2YQAwurhFWjjUZ8qx/cSRq/ETyMYZX3UH006j?=
 =?us-ascii?Q?B1MvAHqx3Ci0oR6J2ccqYqfDfYJqHM6IUxQTbBAe9n0oz4TBsLdh56iBecAj?=
 =?us-ascii?Q?320D/j8UsqjZbZOxbmg7pXw4jkPNyAPQd47gVzi2mbYAvY8a6qhFe9MkQ1AK?=
 =?us-ascii?Q?uADNQH3N62bI5rwPJxxmrd0KX7D2KbBAPgmdmO+moMh9LZiEeD9eWl24oeYF?=
 =?us-ascii?Q?S+ie0r4O4CDZ61iH+AeZzQq0B3SuDD2xJBlQwsk0izerTLH6DEJgfDPcqrGx?=
 =?us-ascii?Q?kyGawrZgYtRF7QZDytaC4ypsASUVJi8vdI84sgOJCPWGKtrUQMBbm23Mlube?=
 =?us-ascii?Q?jKKxn5bmJzlLSyE0F+TFUIdNGlTzKxReT14J7WiB3JtgKtxNoN7h9FsNF8oQ?=
 =?us-ascii?Q?lt5UThM0IFzr9P2u32fqtfRX847haq772EwthzHTCfa+PqM7RHkhIjzzP6fZ?=
 =?us-ascii?Q?mSlF0TPjD2e11yYCBjMh9Wn5y0o4TlPWxWZG3Yk965rzpE61aAq2iMebaFfI?=
 =?us-ascii?Q?H1dsvkZynZAmDICM/4HhyCW8m7p+uqBjrZZL+M4WfxP+n4O1H/fhAvf4DXOh?=
 =?us-ascii?Q?zSfuWK7OntcOesRyy8xBdrq51ka4dUBuY9oU9dtGHM2t3nc+g2Vuj9vB6+05?=
 =?us-ascii?Q?i8T78qjU8ql05lnyJa8kQX3Vtxvb9UKmPZ7jI5PrfAsSuyzpl/jESpTEZ9tV?=
 =?us-ascii?Q?MjK6f0si71aXNJFUVzqcfsF4KtW4vW0/X5fS9I5cM5pSWqBFcwpzHJoWX8rG?=
 =?us-ascii?Q?E1g+Z4hRHXytYtjUlFD3Om4OGbsGDjewO1GQzAtKJScXE9Vv/IIHir0teKU1?=
 =?us-ascii?Q?b62raNxdSViaOSTFZatVjYtrAvn+8r41e3Eupj+cZxQIzBxAlhYKXeE1wTqp?=
 =?us-ascii?Q?Vq+lX1bsxd1yQM6olcjxqjyJWEKJjEEMO3VoagFCLa+dCyxhUNGw7CZynZCw?=
 =?us-ascii?Q?ZJiDJqRkd2Mm407Po+dZbMwsvojuqRQbBIunLV9cF7bl3p7kt8P0LXqUDynC?=
 =?us-ascii?Q?pxzJFtNO0tbtUx3qoxWZK9vvkNUmj8jvOrlm3/WJL6QZ0d1Ur3Z+dYKf0MtN?=
 =?us-ascii?Q?le0UWA+gNFgi3qxothgh6RT5S/iCxcIgJdysEYGI9PB7fn+6G8Y2g3thkGa6?=
 =?us-ascii?Q?bKjZV34KUIz0yG33tVfokITEhMwHaw6R0KqIGVGxlsrITKuGtSR1KIs3cRFi?=
 =?us-ascii?Q?ShqfiNFfTPZ2CpX5V6TYOnC9b6yrxvUyglz95gVTwJ/Ib3XR8TM7LPQXftHk?=
 =?us-ascii?Q?r7NO4ULqihMvymIUy2yEAMdny1t8uNZQ0jb8MHUxp2YsBQpqxh4Bca4eFoxs?=
 =?us-ascii?Q?bxVAZw1JFFD3Epjg7R58lFV+tj+HBLajFbCLfdeMxF2MSgoV8/AqOjyvJ+Mx?=
 =?us-ascii?Q?AcKyjHtVLMvR9AkIt4dr7HpawuV/dx6VIs2F2tIhl76quw9q3Txmgs8nls78?=
 =?us-ascii?Q?90HXB1DeQRncjD9nNpbdFdwBILDcLPWQr0OHjSXo?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 00bee959-a4a2-4cf6-3bb7-08dbbbc9dd0a
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2023 00:13:07.7172
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rbi13nnvpKwBHDmrBea3NH/4IBP0sq1nvBSUElXRowuT/3eGKguYO3Jw9dBhvJNflu85eP6/3rTyBALVzac8JQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB6861
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 22 Sep 2023 17:13:18 -0700 (PDT)
X-Spam-Level: **

On Thu, 21 Sep 2023 18:34:40 -0300
Wedson Almeida Filho <wedsonaf@gmail.com> wrote:

> From: Wedson Almeida Filho <walmeida@microsoft.com>
> 
> With GATs, we don't need a separate type to represent a borrowed object
> with a refcount, we can just use Rust's regular shared borrowing. In
> this case, we use `&WithRef<T>` instead of `ArcBorrow<'_, T>`.
> 
> Co-developed-by: Boqun Feng <boqun.feng@gmail.com>
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

The implementation looks good to me, thanks Wedson.

A minor thing that worth considering is to implement `AlwaysRefCounted`
to `WithRef` and reimplement `Arc` with `ARef<TaskRef<T>>` or add
conversion functions between them.

It feels natural to have this this impl (because `WithRef` is indeed
always ref counted), but on the other hand I don't currently foresee
anyone to currently want to use this API :(

> ---
>  rust/kernel/sync.rs     |   2 +-
>  rust/kernel/sync/arc.rs | 180 ++++++++++++++--------------------------
>  2 files changed, 62 insertions(+), 120 deletions(-)