Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Cc:     "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Camelia Groza <camelia.groza@nxp.com>,
        Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor@kernel.org>,
        Sean Anderson <sean.anderson@seco.com>,
        Maxime Chevallier <maxime.chevallier@bootlin.com>,
        Vinod Koul <vkoul@kernel.org>,
        Kishon Vijay Abraham I <kishon@kernel.org>
Subject: [RFC PATCH v2 net-next 02/15] phy: introduce the PHY_MODE_ETHTOOL mode for phy_set_mode_ext()
Date:   Sat, 23 Sep 2023 16:48:51 +0300
Message-Id: <20230923134904.3627402-3-vladimir.oltean@nxp.com>
In-Reply-To: <20230923134904.3627402-1-vladimir.oltean@nxp.com>
References: <20230923134904.3627402-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R/IE8Kxf2kbD5sK49xlUaeFrEwp4sO7iBwdBoO4NBc2nXvWN7jHMNvm3hSDZ?=
 =?us-ascii?Q?2Pdp3Lo4ycAGJMMso37omyrmR/CzqnKmhrM6SsIHtGahQv/ROCcGtSo+eNg0?=
 =?us-ascii?Q?HbSYlA4Q7ozlaNE889PXv0jdRTee2/PwtOYP+FrUMR6IXdhENxwRPAVirCLE?=
 =?us-ascii?Q?I2hosw56dFPM5LXj6SRMTlq29ThJylvv1bC3DvAFhzrWt8TiCvrsH6Tjf68E?=
 =?us-ascii?Q?Q4s2ZpxgLzEs0gtPsXS3H22aBzMvnoJRRH8PoKYa1SBjCkr2/JjQhzySvrDZ?=
 =?us-ascii?Q?C+N3CJhqWSULa7/NHdTpxFMwfNIyQn6BM70p3IHx6egxAjY1c+qi9iD1HTNq?=
 =?us-ascii?Q?FxnQFjqOqQY7IN+QTktk9wFn1X3F+QZfW9eA0UBDZLGFewXkoFT1M4VyviTl?=
 =?us-ascii?Q?5xJFJfIT2s7DiK/B2sHezwlRlhA3j/q74tcAhKNz5MN3xo+f2mx2Q2Lp7fUJ?=
 =?us-ascii?Q?CSLxG/lJ4zAk2KlYOfIx/hdAODVbyPatlzLhuj5s8GgTBlwr4s03afXYFYKS?=
 =?us-ascii?Q?EqH6RSXcJZkPIelFXGQrV+RYgWc+2jXTTcS+lRGrvt7mG/f3VOjkHZHo7ns9?=
 =?us-ascii?Q?yFSPhuVYrFg4vywOIwiSCuhnnCgYHvVLdgwlTnSXw+VLlhcGBohdX32cgs4c?=
 =?us-ascii?Q?MRNvwDYrG8bWtsTCxVMYB1R0Z2c5AqpIcCalBFidu4XChVcQ9efLmLYvxwC2?=
 =?us-ascii?Q?kedgDfn8YO9mJd2XlZV1Nemgcj3pMCD5JtnpnDOFq053xCfX+/LM0nmsbqon?=
 =?us-ascii?Q?fJro9mI/0ggWcPYIwpQtksOKkoKCfgQHJUQp9JVqUXaed7J60KOzdLPP0nAa?=
 =?us-ascii?Q?6H5OywEdH8ZqB4NS1zgtJnInXCRIHwPO1yJV7gJnXSzL8Yu8i1BReFsIxdf5?=
 =?us-ascii?Q?ITny99J6PqtxJPnVpSATQ+vykCwnmDJ6j9skrXCW8nC85tElAaTirFd6CMqF?=
 =?us-ascii?Q?U676Je4QsI5OBvGTrvDX47ynMfFW1R9ZiElzW1LnudTTGdJp/IxnG/r9/0mf?=
 =?us-ascii?Q?QOu4D/1k1GTLdVA6FRwfV2bD06Thk1+XWhOoyleJFR6lZmUjz28YL2Eqxp55?=
 =?us-ascii?Q?33Oe2oRydssVd7M3lwOLVihvJKOYiXzjPkmdZwzLH66NI3X4hd1sf+95Ktcg?=
 =?us-ascii?Q?4yNdN9KDFJmUD7DPPRv68hlJZ7SW6RGPDLD3fnnMYNGJ8Hv15YIRFq9+84Rw?=
 =?us-ascii?Q?pZ4nmqRpOOToiS2+5beFzQcSC/pyIAlgOQnQoiBj8k4mGrq6tBFpGEFgCEuN?=
 =?us-ascii?Q?ZHNVv8Ogs1LuLoMVxDTGESW17/Vo2dW3A233VLYgz/689l7ImtWKmyNvZmDo?=
 =?us-ascii?Q?WCJMuA6Fu3Ovtx1o/h/+VpxswSZMknplqnEX3WIMyq8vieWWAdzG/2YKInKS?=
 =?us-ascii?Q?Jx634tRC/E3QDKJw8WBdcQ/hq2oeinwIYEydvB2627VJdstXhMa1J+0h/T1O?=
 =?us-ascii?Q?wyENs06TczXvqLBXfzCV8perjm/go2KOLvtuQ76Jr0YdszwGvJhH76jlM78s?=
 =?us-ascii?Q?Z2YXSuT2ZnuZPlTbfceV7XUYgfSWFrviC1atu9VIY4hafybfgC9P4FJND7zt?=
 =?us-ascii?Q?hwCuxgtM9BHeX81GU4lNNcvi546GXCFoaKzG9G1C8ao2p6K6qjtOP/30yNww?=
 =?us-ascii?Q?Ag=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ebe1571-e53a-45ba-34d9-08dbbc3be58f
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2023 13:49:24.5258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WN0zbgKSr7IbtrN+B24lY/U491xxOPXwrPEqQUNFdnHgRDYkvpTyHqKnjrUUOkN9AkUAn/neHovZ9Xen8ghhxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8396
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 23 Sep 2023 06:49:50 -0700 (PDT)

In networking, we have 2 distinct data types:

- phy_interface_t describes the link between a MAC (or MAC-side PCS) and
  an attached PHY or SFP cage

- enum ethtool_link_mode_bit_indices describes the link between a local
  PHY and a remote PHY (for example, gigabit RJ45 twisted copper pairs)

Currently, phy_set_mode_ext(PHY_MODE_ETHERNET) takes arguments of the
phy_interface_t type, and there is no way to pass an argument of the
enum ethtool_link_mode_bit_indices type. The new PHY_MODE_ETHTOOL
intends to address that.

It is true that there is currently some overlap between these data
types, namely:

 phy_interface_t                enum ethtool_link_mode_bit_indices
 -----------------------------------------------------------------
 PHY_INTERFACE_MODE_10GKR       ETHTOOL_LINK_MODE_10000baseKR_Full_BIT
 PHY_INTERFACE_MODE_1000BASEKX  ETHTOOL_LINK_MODE_1000baseKX_Full_BIT

but those overlaps were deemed to be mistakes, and PHY-to-PHY link modes
should only be added to ethtool_link_mode_bit_indices going forward.
Thus, I believe that the distinction is necessary, rather than hacking
more improper PHY modes. Some of the PHY-to-PHY link modes which may be
added in the future (to ethtool_link_mode_bit_indices and not to
phy_interface_t) are:

	ETHTOOL_LINK_MODE_100000baseKP4_Full_BIT
	ETHTOOL_LINK_MODE_100000baseCR10_Full_BIT
	ETHTOOL_LINK_MODE_25000baseKR_S_Full_BIT
	ETHTOOL_LINK_MODE_25000baseCR_S_Full_BIT

One user of PHY_MODE_ETHTOOL will be the MTIP backplane AN/LT + Lynx
SerDes PHY combo, where the backplane autoneg protocol (IEEE 802.3
clause 73) selects the operating PHY-to-PHY link mode.

There are electrical differences between the PHY-to-PHY backplane link
modes (like ETHTOOL_LINK_MODE_10000baseKR_Full_BIT) and their
non-backplane counterparts (like PHY_INTERFACE_MODE_10GBASER), namely
the number of TX signal equalization taps and their configurability.
This further justifies distinguishing between them in the generic PHY
API.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v1->v2: rename PHY_MODE_ETHERNET_PHY to PHY_MODE_ETHTOOL at Russell's
suggestion

 include/linux/phy/phy.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
index 6be348f1fa0e..72ef4afcda81 100644
--- a/include/linux/phy/phy.h
+++ b/include/linux/phy/phy.h
@@ -39,6 +39,7 @@ enum phy_mode {
 	PHY_MODE_UFS_HS_B,
 	PHY_MODE_PCIE,
 	PHY_MODE_ETHERNET,
+	PHY_MODE_ETHTOOL,
 	PHY_MODE_MIPI_DPHY,
 	PHY_MODE_SATA,
 	PHY_MODE_LVDS,
@@ -52,7 +53,7 @@ enum phy_media {
 };
 
 enum phy_status_type {
-	/* Valid for PHY_MODE_ETHERNET */
+	/* Valid for PHY_MODE_ETHERNET and PHY_MODE_ETHTOOL */
 	PHY_STATUS_CDR_LOCK,
 };
 
-- 
2.34.1