Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   Leon Romanovsky <leon@kernel.org>
To:     Yishai Hadas <yishaih@nvidia.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        Jack Morgenstein <jackm@dev.mellanox.co.il>,
        Roland Dreier <roland@purestorage.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/mlx4: Fix the size of a buffer in add_port_entries()
Date:   Sat, 23 Sep 2023 21:54:16 +0300
Message-ID: <169549523606.309442.12357071231764109578.b4-ty@kernel.org>
In-Reply-To: <0bb1443eb47308bc9be30232cc23004c4d4cf43e.1695448530.git.christophe.jaillet@wanadoo.fr>
References: <0bb1443eb47308bc9be30232cc23004c4d4cf43e.1695448530.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


On Sat, 23 Sep 2023 07:55:56 +0200, Christophe JAILLET wrote:
> In order to be sure that 'buff' is never truncated, its size should be
> 12, not 11.
> 
> When building with W=1, this fixes the following warnings:
> 
>   drivers/infiniband/hw/mlx4/sysfs.c: In function ‘add_port_entries’:
>   drivers/infiniband/hw/mlx4/sysfs.c:268:34: error: ‘sprintf’ may write a terminating nul past the end of the destination [-Werror=format-overflow=]
>     268 |                 sprintf(buff, "%d", i);
>         |                                  ^
>   drivers/infiniband/hw/mlx4/sysfs.c:268:17: note: ‘sprintf’ output between 2 and 12 bytes into a destination of size 11
>     268 |                 sprintf(buff, "%d", i);
>         |                 ^~~~~~~~~~~~~~~~~~~~~~
>   drivers/infiniband/hw/mlx4/sysfs.c:286:34: error: ‘sprintf’ may write a terminating nul past the end of the destination [-Werror=format-overflow=]
>     286 |                 sprintf(buff, "%d", i);
>         |                                  ^
>   drivers/infiniband/hw/mlx4/sysfs.c:286:17: note: ‘sprintf’ output between 2 and 12 bytes into a destination of size 11
>     286 |                 sprintf(buff, "%d", i);
>         |                 ^~~~~~~~~~~~~~~~~~~~~~
> 
> [...]

Applied, thanks!

[1/1] IB/mlx4: Fix the size of a buffer in add_port_entries()
      https://git.kernel.org/rdma/rdma/c/d7f393430a17c2

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>