Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <9a311ce3-0d29-af39-5533-c1cad6de1300@microchip.com>
Date:   Sat, 23 Sep 2023 14:44:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH] mmc: Fix force card detect in sdhci
Content-Language: en-US
To:     Mathieu Moneyron <mathieu.moneyron@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
        Eugen Hristev <eugen.hristev@collabora.com>
CC:     Ludovic Desroches <ludovic.desroches@microchip.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        <linux-mmc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20230830092314.624212-1-mathieu.moneyron@gmail.com>
 <096e9122-23b8-5a36-7779-28994187c620@intel.com>
From:   Aubin Constans <aubin.constans@microchip.com>
In-Reply-To: <096e9122-23b8-5a36-7779-28994187c620@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 04/09/2023 09:38, Adrian Hunter wrote:
> + Eugen Hristev  > > On 30/08/23 12:23, mathieu wrote: >> On the ATMEL at91 when using 
the non-removable flag in device tree >> and not using the card-detect 
pin inside the device-tree pinctrl, >> the card detect pin is physically 
still used which can cause >> unknown behaviour when this pin is used 
for other purposes.
Hi Mathieu,

On which SoC(s) exactly, has this behaviour been observed?

Also, has this issue been discussed in any separate support request, in such
case we could retrieve some background from it?

By "unknown behaviour", do you mean "the card insertion status would
follow whatever electrical level is seen on the card-detect pin"?

>>  >> From my interpretation this seems to be caused by a hardware design 
 >> flaw and the real hardware is not working as intended by the >> 
documentation. >>
>>
>> Signed-off-by: Mathieu Moneyron <mathieu.moneyron@gmail.com>
>>
>> ---
>>  drivers/mmc/host/sdhci-of-at91.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-at91.c 
>> b/drivers/mmc/host/sdhci-of-at91.c
>> index 69fef88e7..4fd6bfbf6 100644
>> --- a/drivers/mmc/host/sdhci-of-at91.c
>> +++ b/drivers/mmc/host/sdhci-of-at91.c
>> @@ -51,10 +51,15 @@ struct sdhci_at91_priv {
>>  static void sdhci_at91_set_force_card_detect(struct sdhci_host *host)
>>  {
>>      u8 mc1r;
>> +    u8 ctrl;
>>
>>      mc1r = readb(host->ioaddr + SDMMC_MC1R);
>>      mc1r |= SDMMC_MC1R_FCD;
>>      writeb(mc1r, host->ioaddr + SDMMC_MC1R);
>> +
>> +    ctrl = readb(host->ioaddr + SDHCI_HOST_CONTROL);
>> +    ctrl |= SDHCI_CTRL_CDTEST_INS | SDHCI_CTRL_CDTEST_EN;
>> +    writeb(ctrl, host->ioaddr + SDHCI_HOST_CONTROL);
>>  }
>>
>>  static void sdhci_at91_set_clock(struct sdhci_host *host, unsigned 
>> int clock)

Kind regards,
Aubin