Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
MIME-Version: 1.0
References: <20230922081026.2799-1-quic_tengfan@quicinc.com> <20230922081026.2799-6-quic_tengfan@quicinc.com>
In-Reply-To: <20230922081026.2799-6-quic_tengfan@quicinc.com>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Sat, 23 Sep 2023 22:12:19 +0300
Message-ID: <CAA8EJpq1NAOZTOmBUUnkeLDThvxosj=MzNHo=5VAXnRPQci68g@mail.gmail.com>
Subject: Re: [PATCH v4 5/6] arm64: dts: qcom: sm4450-qrd: add QRD4450 uart support
To:     Tengfei Fan <quic_tengfan@quicinc.com>
Cc:     agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        tglx@linutronix.de, maz@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        catalin.marinas@arm.com, will@kernel.org, geert+renesas@glider.be,
        arnd@arndb.de, neil.armstrong@linaro.org, nfraprado@collabora.com,
        rafal@milecki.pl, peng.fan@nxp.com, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, quic_tsoni@quicinc.com,
        quic_shashim@quicinc.com, quic_kaushalk@quicinc.com,
        quic_tdas@quicinc.com, quic_tingweiz@quicinc.com,
        quic_aiquny@quicinc.com, kernel@quicinc.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 22 Sept 2023 at 11:13, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>
> Add uart support for QRD4450 for enable uart console.
>
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> index 00a1c81ca397..e354bad57a9e 100644
> --- a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> @@ -10,9 +10,24 @@
>         model = "Qualcomm Technologies, Inc. SM4450 QRD";
>         compatible = "qcom,sm4450-qrd", "qcom,sm4450";
>
> -       aliases { };
> +       aliases {
> +               serial0 = &uart7;
> +       };
>
>         chosen {
> -               bootargs = "console=hvc0";
> +               stdout-path = "serial0:115200n8";
>         };
>  };
> +
> +&qupv3_id_0 {
> +       status = "okay";
> +};
> +
> +&tlmm {
> +       /* Reserved for other subsystems */
> +       gpio-reserved-ranges = <0 4>, <136 1>;
> +};

Is this also related to the UART support? it looks like it is a
separate patch, which should likely have the Fixes tag

> +
> +&uart7 {
> +       status = "okay";
> +};
> --
> 2.17.1
>


-- 
With best wishes
Dmitry