Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   Mikhail Khvainitski <me@khvoinitsky.org>
To:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mikhail Khvainitski <me@khvoinitsky.org>
Subject: Re: [PATCH] HID: lenovo: Add middleclick_workaround sysfs knob for cptkbd
Date:   Sun, 24 Sep 2023 01:58:29 +0300
Message-ID: <20230923231522.94060-1-me@khvoinitsky.org>
In-Reply-To: <20230918145042.37368-1-me@khvoinitsky.org>
References: <20230918145042.37368-1-me@khvoinitsky.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk


So, while I was waiting for the review of the patch, I've come up with
much better idea: we can just autodetect if stock and buggy or
patched and bug-free firmware is used and have no need to introduce
additional sysfs knob. So the patch which implements this follows in
the next message.

While the patch is ready to be merged as is (of course, if there are
no comments from reviewers), I thought about the following: may be we
should add a message to dmesg upon detecting stock and buggy firmware
that user should consider patching the firmware? If so, what is the
best place to put an instruction to? Post a link to dmesg? Can the
link point directly to Dennis' blog or its better to put it somewhere
else (with credits, of course)?

Thanks.